Download as
Browse Code »

Commit 4e6065c448a3461e55141c1d6ec4f1603fd4efa9

Authored by Rodrigo Souto
1 parent 208311e8
Exists in master and in 29 other branches add_member_task_reject_details, admin_visible_profile, article-list-template, community_notifications, contact_admin_translation, event_fixes, fix_comments_pagination, fix_rails4_organization_ratings, fix_sign_up_form, follow_step_fix, forum_topic_creation, mirror_block_improvements, multi_env_on_remote_user, new_security, noosfero_spb_ci, organization_ratings_improvements, organization_ratings_link_to_profile_stable-spb-1.3, organization_ratings_translations_fix, profile_api_improvements, ratings_minor_fixes, remote_user_fix, send_email_to_admins, stable-spb-1.3, stable-spb-1.3-fixes, stable-spb-1.4, stable-spb-1.5, suggest_rejected_value, web_steps_improvements, xss_terminate_custom_options

[stoa] Avoiding crash if no field is passed to matches

Showing 2 changed files with 5 additions and 1 deletions   Show diff stats
plugins/stoa/lib/stoa_plugin/usp_user.rb
  Diff comments   View file @4e6065c
... ... @@ -15,7 +15,7 @@ class StoaPlugin::UspUser < ActiveRecord::Base
15 15 def self.matches?(usp_id, field, value)
16 16 usp_id.to_s.gsub!(/[.-]/,'')
17 17 user = StoaPlugin::UspUser.find_by_codpes(usp_id.to_i)
18   - return false if user.nil? || !user.respond_to?(field) || value.blank?
  18 + return false if user.nil? || field.blank? || !user.respond_to?(field) || value.blank?
19 19 case field.to_sym
20 20 when :cpf
21 21 value.to_s.gsub!(/[.-]/,'')
... ...
plugins/stoa/test/unit/usp_user_test.rb
  Diff comments   View file @4e6065c
... ... @@ -43,5 +43,9 @@ class StoaPlugin::UspUserTest < ActiveSupport::TestCase
43 43 assert StoaPlugin::UspUser.exists?('0000123456')
44 44 assert StoaPlugin::UspUser.matches?(123456, :cpf, '00012345678')
45 45 end
  46 +
  47 + should 'return false if field is nil' do
  48 + assert !StoaPlugin::UspUser.matches?(123456, nil, '00012345678')
  49 + end
46 50 end
47 51  
... ...