avoid exception in recent content block used in environment without portal community defined

Leandro Santos
1 parent 13239c9a
Showing 2 changed files with 12 additions and 1 deletions Show diff stats
plugins/recent_content/lib/recent_content_block.rb
plugins/recent_content/test/unit/recent_content_block_test.rb
@@ -33,7 +33,7 @@ class RecentContentBlock &lt; Block
   end
  
   def parents
-    self.holder.articles.where(type: 'Blog')
+    self.holder.nil? ? [] : self.holder.articles.where(type: 'Blog')
   end
  
   def root
@@ -156,4 +156,15 @@ class RecentContentBlockViewTest &lt; ActionView::TestCase
     assert_equal [article.id], block.api_content['articles'].map {|a| a[:id]}
   end
  
+  should 'parents return an empty array for environment without portal community' do
+    environment = fast_create(Environment)
+    block = RecentContentBlock.new
+    box = mock()
+    block.stubs(:box).returns(box)
+    box.stubs(:owner).returns(environment)
+
+    assert_nil environment.portal_community
+    assert_equal [], block.parents
+  end
+
 end
...	...	@@ -33,7 +33,7 @@ class RecentContentBlock < Block
33	33	end
34	34
35	35	def parents
36		- self.holder.articles.where(type: 'Blog')
	36	+ self.holder.nil? ? [] : self.holder.articles.where(type: 'Blog')
37	37	end
38	38
39	39	def root
...	...
...	...	@@ -156,4 +156,15 @@ class RecentContentBlockViewTest < ActionView::TestCase
156	156	assert_equal [article.id], block.api_content['articles'].map {\|a\| a[:id]}
157	157	end
158	158
	159	+ should 'parents return an empty array for environment without portal community' do
	160	+ environment = fast_create(Environment)
	161	+ block = RecentContentBlock.new
	162	+ box = mock()
	163	+ block.stubs(:box).returns(box)
	164	+ box.stubs(:owner).returns(environment)
	165	+
	166	+ assert_nil environment.portal_community
	167	+ assert_equal [], block.parents
	168	+ end
	169	+
159	170	end
...	...