ActionItem893: retrieving urls from profile to get right hostname

Daniela Feitosa
1 parent 8c2a1563
Showing 15 changed files with 86 additions and 34 deletions Show diff stats
app/controllers/public/account_controller.rb
app/helpers/application_helper.rb
app/models/person.rb
app/views/blocks/profile_info_actions/person.rhtml
app/views/home/index.rhtml
app/views/profile_editor/index.rhtml
app/views/search/communities.rhtml
app/views/shared/user_menu.rhtml
test/functional/account_controller_test.rb
test/functional/admin_panel_controller_test.rb
test/functional/application_controller_test.rb
test/functional/profile_controller_test.rb
test/integration/login_to_the_application_test.rb
test/test_helper.rb
test/unit/person_test.rb
@@ -261,7 +261,11 @@ class AccountController &lt; ApplicationController
   end
   def go_to_user_initial_page
-    redirect_back_or_default(:controller => "profile_editor", :profile => current_user.login, :action => 'index')
+    if environment == current_user.environment
+      redirect_back_or_default(user.admin_url)
+    else
+      redirect_back_or_default(:controller => 'home')
+    end
   end
 end
@@ -121,13 +121,22 @@ module ApplicationHelper
   end
   def link_to_homepage(text, profile = nil, options = {})
-    profile ||= current_user.login
-    link_to text, homepage_path(:profile => profile) , options
+    p = if profile
+          Profile[profile]
+        else
+          user
+        end
+
+    link_to text, p.url, options
   end
   def link_to_myprofile(text, url = {}, profile = nil, options = {})
-    profile ||= current_user.login
-    link_to text, { :profile => profile, :controller => 'profile_editor' }.merge(url), options
+    p = if profile
+          Profile[profile]
+        else
+          user
+        end
+    link_to text, p.admin_url.merge(url), options
   end
   def link_to_document(doc, text = nil)
@@ -154,8 +154,8 @@ class Person &lt; Profile
     person.user.save!
   end
-  def is_admin?
-    role_assignments.map{|ra|ra.role.permissions}.any? do |ps|
+  def is_admin?(environment)
+    role_assignments.select { |ra| ra.resource == environment }.map{|ra|ra.role.permissions}.any? do |ps|
       ps.any? do |p|
         ActiveRecord::Base::PERMISSIONS['Environment'].keys.include?(p)
       end
@@ -2,7 +2,7 @@
   <%if logged_in? && (user != profile) %>
     <% if !user.already_request_friendship?(profile) and !user.is_a_friend?(profile) %>
-      <li><%= link_to content_tag('span', __('Add friend')), { :profile => user.identifier, :controller => 'friends', :action => 'add', :id => profile.id }, :class => 'button with-text icon-add' %></li>
+      <li><%= link_to content_tag('span', __('Add friend')), user.url.merge(:controller => 'friends', :action => 'add', :id => profile.id), :class => 'button with-text icon-add' %></li>
     <% end %>
     <% if user.is_a_friend?(profile) && profile.enable_contact? %>
-<%= flash[:notice] %>
-
 <%= @environment.description %>
 <div id='home-search' style='text-align: center'>
@@ -21,7 +21,7 @@
   <%= file_manager_button(_('Edit Appearance'), 'icons-app/design-editor.png', :controller => 'themes', :action => 'index') %>
-  <%= file_manager_button(_('Edit Header and Footer'), 'icons-app/header-and-footer.png', :controller => 'profile_editor', :action => 'header_footer') unless profile.enterprise? && environment.enabled?('disable_header_and_footer') && !user.is_admin? %>
+  <%= file_manager_button(_('Edit Header and Footer'), 'icons-app/header-and-footer.png', :controller => 'profile_editor', :action => 'header_footer') unless profile.enterprise? && environment.enabled?('disable_header_and_footer') && !user.is_admin?(environment) %>
   <%= file_manager_button(_('Manage Content'), 'icons-app/cms.png', :controller => 'cms') unless environment.enabled?('disable_cms') || profile.community? %>
@@ -14,7 +14,8 @@
 <% if logged_in? %>
   <% button_bar do %>
-    <%= button(:add, _('New community'), :controller => 'memberships', :action => 'new_community', :profile => current_user.person.identifier) %>
+    <%# FIXME shouldn't the user create the community in the current environment instead of going to its home environment? %>
+    <%= button(:add, _('New community'), user.url.merge(:controller => 'memberships', :action => 'new_community')) %>
   <% end %>
 <% end %>
@@ -15,9 +15,9 @@
     <div id="user_menu_ul">
       <ul>
-        <li><a href="<%= homepage_path(:profile => current_user.login) %>"
-               help="<%= _('Go to your home page.') %>"
-               ><span class="icon-menu-home"></span><%= __('My Home Page') %></a></li>
+        <li>
+          <%= link_to( '<span class="icon-menu-home"></span>' + __('My Home Page'), user.url, :help => _('Go to your home page.'))%>
+        </li>
         <!-- li><a href="#"><span class="icon-menu-blog"></span> Meu Blog</a></li -->
@@ -32,16 +32,16 @@
                                      :help => _('Control panel: change your picture, edit your personal information, create content or change the way your home page looks.')
                                  ) %></li>
-        <%=
-          '<li>'+ link_to( '<span class="icon-menu-"></span>'+ _('Admin'),
-                           { :controller => 'admin_panel' }, :id => 'link_admin_panel',
-                           :help => _('Access the site administration panel.')
-                         ) +
-          '</li>' if user.is_admin?
-        %>
+        <% if user.is_admin?(environment) %>
+          <li><%= link_to( '<span class="icon-menu-"></span>'+ _('Admin'),
+                             {:controller => 'admin_panel' },
+                             :id => 'link_admin_panel',
+                             :help => _('Access the site administration panel.')
+                             )%></li>
+        <% end %>
         <li><%= link_to( '<span class="icon-menu-logout"></span>'+ _('Logout'),
-                                  { :controller => 'account', :action => 'logout'},
+                                  {:controller => 'account', :action => 'logout'},
                                   :id => 'link_logout',
                                   :help => _('This link takes you out of the system. You should logout if other people are willing to use the same computer after you.')
                                 ) %></li>
@@ -40,6 +40,16 @@ class AccountControllerTest &lt; Test::Unit::TestCase
     assert_redirected_to :controller => 'profile_editor', :action => 'index', :profile => 'quire'
   end
+  should 'redirect to home when login on other environment' do
+    e = Environment.create!(:name => 'other_environment')
+    e.domains << Domain.new(:name => 'other.environment')
+    e.save!
+    u = create_user('test_user', :environment => e).person
+    post :login, :user => {:login => 'test_user', :password => 'test_user'}
+
+    assert_redirected_to :controller => 'home'
+  end
+
   def test_should_fail_login_and_not_redirect
     @request.env["HTTP_REFERER"] = 'bli'
     post :login, :user => {:login => 'johndoe', :password => 'bad password'}
@@ -275,7 +285,8 @@ class AccountControllerTest &lt; Test::Unit::TestCase
   end
   should 'correct redirect after login' do
-    post :login, :user => {:login => 'johndoe', :password => 'test'}
+    user = create_user('correct_redirect').person
+    post :login, :user => {:login => 'correct_redirect', :password => 'correct_redirect'}
     assert_redirected_to :controller => 'profile_editor'
   end
@@ -24,11 +24,6 @@ class AdminPanelControllerTest &lt; Test::Unit::TestCase
   end
   should 'manage the correct environment' do
-    Environment.destroy_all
-
-    default = Environment.create!(:name => 'default env', :is_default => true)
-    Environment.stubs(:default).returns(default)
-
     current = Environment.create!(:name => 'test environment', :is_default => false)
     current.domains.create!(:name => 'example.com')
@@ -408,4 +408,20 @@ class ApplicationControllerTest &lt; Test::Unit::TestCase
     get :index, :profile => p.identifier
     assert_tag 'title', :content => p.name + ' - ' + p.environment.name
   end
+
+  should 'display menu links for my environment when logged in other environment' do
+    e = Environment.create!(:name => 'other_environment')
+    e.domains << Domain.new(:name => 'other.environment')
+    e.save!
+
+    login_as(create_admin_user(e))
+    uses_host 'other.environment'
+    get :index
+    assert_tag :tag => 'div', :attributes => {:id => 'user_menu_ul'}
+    assert_tag :tag => 'div', :attributes => {:id => 'user_menu_ul'}, 
+                :descendant => {:tag => 'a', :attributes => { :href => 'http://other.environment/adminuser' }},
+                :descendant => {:tag => 'a', :attributes => { :href => 'http://other.environment/myprofile/adminuser' }},
+                :descendant => {:tag => 'a', :attributes => { :href => '/admin' }}
+  end
+
 end
@@ -172,7 +172,7 @@ class ProfileControllerTest &lt; Test::Unit::TestCase
     community = Community.create!(:name => 'my test community')
     community.add_admin(@profile)
     get :index, :profile => community.identifier
-    assert_tag :tag => 'a', :attributes => { :href => "/myprofile/#{@profile.identifier}" }, :content => 'Control panel'
+    assert_tag :tag => 'a', :attributes => { :href => /\/myprofile\/#{@profile.identifier}/ }, :content => 'Control panel'
   end
   should 'show create community in own profile' do
@@ -12,7 +12,8 @@ class LoginToTheApplicationTest &lt; ActionController::IntegrationTest
     get '/account/login_popup'
     assert_response :success
-    login('ze', 'test')
+    create_user('test_user').person
+    login('test_user', 'test_user')
     assert_cannot_login
     assert_can_logout
@@ -66,7 +66,7 @@ class Test::Unit::TestCase
   end
   def create_admin_user(env)
-    admin_user = User.find_by_login('adminuser') || create_user('adminuser', :email => 'adminuser@noosfero.org', :password => 'adminuser', :password_confirmation => 'adminuser')
+    admin_user = User.find_by_login('adminuser') || create_user('adminuser', :email => 'adminuser@noosfero.org', :password => 'adminuser', :password_confirmation => 'adminuser', :environment => env)
     admin_role = Role.find_by_name('admin_role') || Role.create!(:name => 'admin_role', :permissions => ['view_environment_admin_panel','edit_environment_features', 'edit_environment_design', 'manage_environment_categories', 'manage_environment_roles', 'manage_environment_validators'])
     RoleAssignment.create!(:accessor => admin_user.person, :role => admin_role, :resource => env) unless admin_user.person.role_assignments.map{|ra|[ra.role, ra.accessor, ra.resource]}.include?([admin_role, admin_user, env])
     admin_user.login
@@ -134,10 +134,27 @@ class PersonTest &lt; Test::Unit::TestCase
     env = Environment.create!(:name => 'blah')
     person = create_user('just_another_person').person
     env.affiliate(person, role)
-    assert ! person.is_admin?
+    assert ! person.is_admin?(env)
     role.update_attributes(:permissions => ['view_environment_admin_panel'])
     person = Person.find(person.id)
-    assert person.is_admin?
+    assert person.is_admin?(env)
+  end
+
+  should 'separate admins of different environments' do
+    env1 = Environment.create!(:name => 'blah1')
+    env2 = Environment.create!(:name => 'blah2')
+
+    # role is an admin role
+    role = Role.create!(:name => 'just_another_admin_role')
+    role.update_attributes(:permissions => ['view_environment_admin_panel'])
+
+    # user is admin of env1, but not of env2
+    person = create_user('just_another_person').person
+    env1.affiliate(person, role)
+
+    person = Person.find(person.id)
+    assert person.is_admin?(env1)
+    assert !person.is_admin?(env2)
   end
   should 'get a default home page and a RSS feed' do
	@@ -2,7 +2,7 @@		@@ -2,7 +2,7 @@
2	<%if logged_in? && (user != profile) %>	2	<%if logged_in? && (user != profile) %>
3		3
4	<% if !user.already_request_friendship?(profile) and !user.is_a_friend?(profile) %>	4	<% if !user.already_request_friendship?(profile) and !user.is_a_friend?(profile) %>
5	- <li><%= link_to content_tag('span', __('Add friend')), { :profile => user.identifier, :controller => 'friends', :action => 'add', :id => profile.id }, :class => 'button with-text icon-add' %></li>	5	+ <li><%= link_to content_tag('span', __('Add friend')), user.url.merge(:controller => 'friends', :action => 'add', :id => profile.id), :class => 'button with-text icon-add' %></li>
6	<% end %>	6	<% end %>
7		7
8	<% if user.is_a_friend?(profile) && profile.enable_contact? %>	8	<% if user.is_a_friend?(profile) && profile.enable_contact? %>
1	-<%= flash[:notice] %>
2	-
3	<%= @environment.description %>	1	<%= @environment.description %>
4		2
5	<div id='home-search' style='text-align: center'>	3	<div id='home-search' style='text-align: center'>
	@@ -21,7 +21,7 @@		@@ -21,7 +21,7 @@
21		21
22	<%= file_manager_button(_('Edit Appearance'), 'icons-app/design-editor.png', :controller => 'themes', :action => 'index') %>	22	<%= file_manager_button(_('Edit Appearance'), 'icons-app/design-editor.png', :controller => 'themes', :action => 'index') %>
23		23
24	- <%= file_manager_button(_('Edit Header and Footer'), 'icons-app/header-and-footer.png', :controller => 'profile_editor', :action => 'header_footer') unless profile.enterprise? && environment.enabled?('disable_header_and_footer') && !user.is_admin? %>	24	+ <%= file_manager_button(_('Edit Header and Footer'), 'icons-app/header-and-footer.png', :controller => 'profile_editor', :action => 'header_footer') unless profile.enterprise? && environment.enabled?('disable_header_and_footer') && !user.is_admin?(environment) %>
25		25
26	<%= file_manager_button(_('Manage Content'), 'icons-app/cms.png', :controller => 'cms') unless environment.enabled?('disable_cms') \|\| profile.community? %>	26	<%= file_manager_button(_('Manage Content'), 'icons-app/cms.png', :controller => 'cms') unless environment.enabled?('disable_cms') \|\| profile.community? %>
27		27
	@@ -14,7 +14,8 @@		@@ -14,7 +14,8 @@
14		14
15	<% if logged_in? %>	15	<% if logged_in? %>
16	<% button_bar do %>	16	<% button_bar do %>
17	- <%= button(:add, _('New community'), :controller => 'memberships', :action => 'new_community', :profile => current_user.person.identifier) %>	17	+ <%# FIXME shouldn't the user create the community in the current environment instead of going to its home environment? %>
		18	+ <%= button(:add, _('New community'), user.url.merge(:controller => 'memberships', :action => 'new_community')) %>
18	<% end %>	19	<% end %>
19	<% end %>	20	<% end %>
20		21
	@@ -408,4 +408,20 @@ class ApplicationControllerTest < Test::Unit::TestCase		@@ -408,4 +408,20 @@ class ApplicationControllerTest < Test::Unit::TestCase
408	get :index, :profile => p.identifier	408	get :index, :profile => p.identifier
409	assert_tag 'title', :content => p.name + ' - ' + p.environment.name	409	assert_tag 'title', :content => p.name + ' - ' + p.environment.name
410	end	410	end
		411	+
		412	+ should 'display menu links for my environment when logged in other environment' do
		413	+ e = Environment.create!(:name => 'other_environment')
		414	+ e.domains << Domain.new(:name => 'other.environment')
		415	+ e.save!
		416	+
		417	+ login_as(create_admin_user(e))
		418	+ uses_host 'other.environment'
		419	+ get :index
		420	+ assert_tag :tag => 'div', :attributes => {:id => 'user_menu_ul'}
		421	+ assert_tag :tag => 'div', :attributes => {:id => 'user_menu_ul'},
		422	+ :descendant => {:tag => 'a', :attributes => { :href => 'http://other.environment/adminuser' }},
		423	+ :descendant => {:tag => 'a', :attributes => { :href => 'http://other.environment/myprofile/adminuser' }},
		424	+ :descendant => {:tag => 'a', :attributes => { :href => '/admin' }}
		425	+ end
		426	+
411	end	427	end
	@@ -172,7 +172,7 @@ class ProfileControllerTest < Test::Unit::TestCase		@@ -172,7 +172,7 @@ class ProfileControllerTest < Test::Unit::TestCase
172	community = Community.create!(:name => 'my test community')	172	community = Community.create!(:name => 'my test community')
173	community.add_admin(@profile)	173	community.add_admin(@profile)
174	get :index, :profile => community.identifier	174	get :index, :profile => community.identifier
175	- assert_tag :tag => 'a', :attributes => { :href => "/myprofile/#{@profile.identifier}" }, :content => 'Control panel'	175	+ assert_tag :tag => 'a', :attributes => { :href => /\/myprofile\/#{@profile.identifier}/ }, :content => 'Control panel'
176	end	176	end
177		177
178	should 'show create community in own profile' do	178	should 'show create community in own profile' do
	@@ -12,7 +12,8 @@ class LoginToTheApplicationTest < ActionController::IntegrationTest		@@ -12,7 +12,8 @@ class LoginToTheApplicationTest < ActionController::IntegrationTest
12	get '/account/login_popup'	12	get '/account/login_popup'
13	assert_response :success	13	assert_response :success
14		14
15	- login('ze', 'test')	15	+ create_user('test_user').person
		16	+ login('test_user', 'test_user')
16	assert_cannot_login	17	assert_cannot_login
17	assert_can_logout	18	assert_can_logout
18		19
	@@ -66,7 +66,7 @@ class Test::Unit::TestCase		@@ -66,7 +66,7 @@ class Test::Unit::TestCase
66	end	66	end
67		67
68	def create_admin_user(env)	68	def create_admin_user(env)
69	- admin_user = User.find_by_login('adminuser') \|\| create_user('adminuser', :email => 'adminuser@noosfero.org', :password => 'adminuser', :password_confirmation => 'adminuser')	69	+ admin_user = User.find_by_login('adminuser') \|\| create_user('adminuser', :email => 'adminuser@noosfero.org', :password => 'adminuser', :password_confirmation => 'adminuser', :environment => env)
70	admin_role = Role.find_by_name('admin_role') \|\| Role.create!(:name => 'admin_role', :permissions => ['view_environment_admin_panel','edit_environment_features', 'edit_environment_design', 'manage_environment_categories', 'manage_environment_roles', 'manage_environment_validators'])	70	admin_role = Role.find_by_name('admin_role') \|\| Role.create!(:name => 'admin_role', :permissions => ['view_environment_admin_panel','edit_environment_features', 'edit_environment_design', 'manage_environment_categories', 'manage_environment_roles', 'manage_environment_validators'])
71	RoleAssignment.create!(:accessor => admin_user.person, :role => admin_role, :resource => env) unless admin_user.person.role_assignments.map{\|ra\|[ra.role, ra.accessor, ra.resource]}.include?([admin_role, admin_user, env])	71	RoleAssignment.create!(:accessor => admin_user.person, :role => admin_role, :resource => env) unless admin_user.person.role_assignments.map{\|ra\|[ra.role, ra.accessor, ra.resource]}.include?([admin_role, admin_user, env])
72	admin_user.login	72	admin_user.login
	@@ -134,10 +134,27 @@ class PersonTest < Test::Unit::TestCase		@@ -134,10 +134,27 @@ class PersonTest < Test::Unit::TestCase
134	env = Environment.create!(:name => 'blah')	134	env = Environment.create!(:name => 'blah')
135	person = create_user('just_another_person').person	135	person = create_user('just_another_person').person
136	env.affiliate(person, role)	136	env.affiliate(person, role)
137	- assert ! person.is_admin?	137	+ assert ! person.is_admin?(env)
138	role.update_attributes(:permissions => ['view_environment_admin_panel'])	138	role.update_attributes(:permissions => ['view_environment_admin_panel'])
139	person = Person.find(person.id)	139	person = Person.find(person.id)
140	- assert person.is_admin?	140	+ assert person.is_admin?(env)
		141	+ end
		142	+
		143	+ should 'separate admins of different environments' do
		144	+ env1 = Environment.create!(:name => 'blah1')
		145	+ env2 = Environment.create!(:name => 'blah2')
		146	+
		147	+ # role is an admin role
		148	+ role = Role.create!(:name => 'just_another_admin_role')
		149	+ role.update_attributes(:permissions => ['view_environment_admin_panel'])
		150	+
		151	+ # user is admin of env1, but not of env2
		152	+ person = create_user('just_another_person').person
		153	+ env1.affiliate(person, role)
		154	+
		155	+ person = Person.find(person.id)
		156	+ assert person.is_admin?(env1)
		157	+ assert !person.is_admin?(env2)
141	end	158	end
142		159
143	should 'get a default home page and a RSS feed' do	160	should 'get a default home page and a RSS feed' do