[Mezuro] Fixed models and helper unit tests and fixed repository model

João M. M. da Silva
1 parent 078f4eec
Showing 6 changed files with 24 additions and 16 deletions Show diff stats
plugins/mezuro/lib/kalibro/model.rb
plugins/mezuro/lib/kalibro/repository.rb
plugins/mezuro/test/unit/kalibro/configuration_test.rb
plugins/mezuro/test/unit/kalibro/project_test.rb
plugins/mezuro/test/unit/kalibro/repository_test.rb
plugins/mezuro/test/unit/mezuro_plugin/helpers/content_viewer_helper_test.rb
@@ -52,7 +52,7 @@ class Kalibro::Model
     if(exists?(id))
       new request(find_action, id_params(id))["#{class_name.underscore}".to_sym]
     else
-      raise Errors::RecordNotFound
+      raise Kalibro::Errors::RecordNotFound
     end
   end
@@ -22,8 +22,14 @@ class Kalibro::Repository &lt; Kalibro::Model
     self.class.request(:cancel_processing_of_repository, {:repository_id => self.id})
   end
-  def save_params
-    {:repository => self.to_hash, :project_id => Kalibro::Project.project_of(id).id}
+  def save(project_id)
+    begin
+      self.id = self.class.request(:save_repository, {:repository => self.to_hash, :project_id => project_id})[:repository_id]
+      true
+	  rescue Exception => exception
+	    add_error exception
+	    false
+    end
   end
 end
@@ -29,9 +29,9 @@ class ConfigurationTest &lt; ActiveSupport::TestCase
     assert_equal @hash[:name], Kalibro::Configuration.find(@configuration.id).name
   end
-  should 'return nil when configuration doesnt exist' do
+  should 'return exception when configuration doesnt exist' do
     Kalibro::Configuration.expects(:request).with(:configuration_exists, {:configuration_id => @configuration.id}).returns({:exists => false})
-    assert_nil Kalibro::Configuration.find(@configuration.id)
+    assert_raise(Kalibro::Errors::RecordNotFound){Kalibro::Configuration.find(@configuration.id)}
   end
   should 'get configuration of a repository' do
@@ -31,9 +31,9 @@ class ProjectTest &lt; ActiveSupport::TestCase
     assert_equal @hash[:name], Kalibro::Project.find(@project.id).name
   end
-  should 'verify when project doesnt exist' do
+  should 'raise RecordNotFound exception when project doesnt exist' do
     Kalibro::Project.expects(:request).with(:project_exists, {:project_id => @project.id}).returns({:exists => false})
-    assert_nil Kalibro::Project.find(@project.id)
+    assert_raise(Kalibro::Errors::RecordNotFound){Kalibro::Project.find(@project.id)}
   end
   should 'get project of a repository' do
@@ -38,14 +38,16 @@ class RepositoryTest &lt; ActiveSupport::TestCase
   should 'return true when repository is saved successfully' do
     id_from_kalibro = 1
-    Kalibro::Repository.expects(:request).with(:save_repository, {:repository => @created_repository.to_hash}).returns(:repository_id => id_from_kalibro)
-    assert @created_repository.save
+    project_id = 56
+    Kalibro::Repository.expects(:request).with(:save_repository, {:repository => @created_repository.to_hash, :project_id => project_id}).returns(:repository_id => id_from_kalibro)
+    assert @created_repository.save(project_id)
     assert_equal id_from_kalibro, @created_repository.id
   end
   should 'return false when repository is not saved successfully' do
-    Kalibro::Repository.expects(:request).with(:save_repository, {:repository => @created_repository.to_hash}).raises(Exception.new)
-    assert !(@created_repository.save)
+    project_id = 56
+    Kalibro::Repository.expects(:request).with(:save_repository, {:repository => @created_repository.to_hash, :project_id => project_id}).raises(Exception.new)
+    assert !(@created_repository.save(project_id))
     assert_nil @created_repository.id
   end
@@ -58,7 +60,7 @@ class RepositoryTest &lt; ActiveSupport::TestCase
     Kalibro::Repository.expects(:request).with(:process_repository, {:repository_id => @repository.id});
     @repository.process_repository
   end
-  
+
   should 'cancel processing of a repository' do
     Kalibro::Repository.expects(:request).with(:cancel_processing_of_repository, {:repository_id => @repository.id});
     @repository.cancel_processing_of_repository
 require "test_helper"
-require "#{RAILS_ROOT}/plugins/mezuro/test/fixtures/metric_result_fixtures"
+require "#{RAILS_ROOT}/plugins/mezuro/test/fixtures/metric_configuration_snapshot_fixtures"
 class ContentViewerHelperTest < ActiveSupport::TestCase
@@ -13,9 +13,9 @@ class ContentViewerHelperTest &lt; ActiveSupport::TestCase
     assert_equal [["Not Periodically", 0], ["1 day", 1], ["2 days", 2], ["Weekly", 7], ["Biweeky", 15], ["Monthly", 30]], MezuroPlugin::Helpers::ContentViewerHelper.create_periodicity_options
   end
-  should 'format metric name for module result' do
-    metric_result = MetricResultFixtures.native_metric_result
-    assert_equal 'AverageMethodLOC', MezuroPlugin::Helpers::ContentViewerHelper.format_name(metric_result)
+  should 'format metric name for metric configuration snapshot' do
+    metric_configuration_snapshot = MetricConfigurationSnapshotFixtures.metric_configuration_snapshot
+    assert_equal 'AverageMethodLOC', MezuroPlugin::Helpers::ContentViewerHelper.format_name(metric_configuration_snapshot)
   end
 end
	@@ -52,7 +52,7 @@ class Kalibro::Model		@@ -52,7 +52,7 @@ class Kalibro::Model
52	if(exists?(id))	52	if(exists?(id))
53	new request(find_action, id_params(id))["#{class_name.underscore}".to_sym]	53	new request(find_action, id_params(id))["#{class_name.underscore}".to_sym]
54	else	54	else
55	- raise Errors::RecordNotFound	55	+ raise Kalibro::Errors::RecordNotFound
56	end	56	end
57	end	57	end
58		58
	@@ -29,9 +29,9 @@ class ConfigurationTest < ActiveSupport::TestCase		@@ -29,9 +29,9 @@ class ConfigurationTest < ActiveSupport::TestCase
29	assert_equal @hash[:name], Kalibro::Configuration.find(@configuration.id).name	29	assert_equal @hash[:name], Kalibro::Configuration.find(@configuration.id).name
30	end	30	end
31		31
32	- should 'return nil when configuration doesnt exist' do	32	+ should 'return exception when configuration doesnt exist' do
33	Kalibro::Configuration.expects(:request).with(:configuration_exists, {:configuration_id => @configuration.id}).returns({:exists => false})	33	Kalibro::Configuration.expects(:request).with(:configuration_exists, {:configuration_id => @configuration.id}).returns({:exists => false})
34	- assert_nil Kalibro::Configuration.find(@configuration.id)	34	+ assert_raise(Kalibro::Errors::RecordNotFound){Kalibro::Configuration.find(@configuration.id)}
35	end	35	end
36		36
37	should 'get configuration of a repository' do	37	should 'get configuration of a repository' do
	@@ -31,9 +31,9 @@ class ProjectTest < ActiveSupport::TestCase		@@ -31,9 +31,9 @@ class ProjectTest < ActiveSupport::TestCase
31	assert_equal @hash[:name], Kalibro::Project.find(@project.id).name	31	assert_equal @hash[:name], Kalibro::Project.find(@project.id).name
32	end	32	end
33		33
34	- should 'verify when project doesnt exist' do	34	+ should 'raise RecordNotFound exception when project doesnt exist' do
35	Kalibro::Project.expects(:request).with(:project_exists, {:project_id => @project.id}).returns({:exists => false})	35	Kalibro::Project.expects(:request).with(:project_exists, {:project_id => @project.id}).returns({:exists => false})
36	- assert_nil Kalibro::Project.find(@project.id)	36	+ assert_raise(Kalibro::Errors::RecordNotFound){Kalibro::Project.find(@project.id)}
37	end	37	end
38		38
39	should 'get project of a repository' do	39	should 'get project of a repository' do