ActionItem615: enhancing sidebox manipulation

* Added more options to move blocks: a button for "move this block to the oposite side". * Added help button for each block. + Wrote help for all blocks, plus enhancing the existing help in some blocks. * Adapted tests to the new bahaviour and added some tests. git-svn-id: https://svn.colivre.coop.br/svn/noosfero/trunk@2463 3f533792-8f58-4932-b0fe-aaf55b0a4547

ActionItem615: enhancing sidebox manipulation
* Added more options to move blocks: a button for "move this block to the oposite side". * Added help button for each block. + Wrote help for all blocks, plus enhancing the existing help in some blocks. * Adapted tests to the new bahaviour and added some tests. git-svn-id: https://svn.colivre.coop.br/svn/noosfero/trunk@2463 3f533792-8f58-4932-b0fe-aaf55b0a4547
AntonioTerceiro
1 parent 7cf76645
Showing 20 changed files with 94 additions and 15 deletions Show diff stats
app/controllers/box_organizer_controller.rb
app/helpers/boxes_helper.rb
app/helpers/thickbox_helper.rb
app/models/article_block.rb
app/models/communities_block.rb
app/models/enterprises_block.rb
app/models/environment_statistics_block.rb
app/models/favorite_enterprises_block.rb
app/models/friends_block.rb
app/models/link_list_block.rb
app/models/login_block.rb
app/models/main_block.rb
app/models/members_block.rb
app/models/my_network_block.rb
app/models/people_block.rb
app/models/products_block.rb
app/models/recent_documents_block.rb
app/models/sellers_search_block.rb
app/models/tags_block.rb
test/functional/profile_design_controller_test.rb
@@ -38,18 +38,22 @@ class BoxOrganizerController &lt; ApplicationController
     @block.save!
     @target_box.reload
+
+    unless request.xhr?
+      redirect_to :action => 'index'
+    end
   end
   def move_block_down
     @block = boxes_holder.blocks.find(params[:id])
     @block.move_lower
-    redirect_to :back
+    redirect_to :action => 'index'
   end
   def move_block_up
     @block = boxes_holder.blocks.find(params[:id])
     @block.move_higher
-    redirect_to :back
+    redirect_to :action => 'index'
   end
   def add_block
@@ -131,15 +131,30 @@ module BoxesHelper
   def block_edit_buttons(block)
     buttons = []
+    nowhere = 'javascript: return false;'
-    if !block.first?
-      buttons << icon_button(:up, _('Move block up'), { :action => 'move_block_up', :id => block.id }, { :method => 'post' })
+    if block.first?
+      buttons << icon_button('up-disabled', _("Can't move up anymore."), nowhere)
+    else
+      buttons << icon_button('up', _('Move block up'), { :action => 'move_block_up', :id => block.id }, { :method => 'post' })
     end
-    if !block.last?
+    if block.last?
+      buttons << icon_button('down-disabled', _("Can't move down anymore."), nowhere)
+    else
       buttons << icon_button(:down, _('Move block down'), { :action => 'move_block_down' ,:id => block.id }, { :method => 'post'})
     end
+    # move to opposite side
+    # FIXME too much hardcoded stuff
+    if profile.layout_template == 'default'
+      if block.box.position == 2 # area 2, left side => move to right side
+        buttons << icon_button('right', _('Move to the opposite side'), { :action => 'move_block', :target => 'end-of-box-' + profile.boxes[2].id.to_s, :id => block.id }, :method => 'post' )
+      elsif block.box.position == 3 # area 3, right side => move to left side
+        buttons << icon_button('left', _('Move to the opposite side'), { :action => 'move_block', :target => 'end-of-box-' + profile.boxes[1].id.to_s, :id => block.id }, :method => 'post' )
+      end
+    end
+
     if block.editable?
       buttons << lightbox_icon_button(:edit, _('Edit'), { :action => 'edit', :id => block.id })
     end
@@ -148,6 +163,10 @@ module BoxesHelper
       buttons << icon_button(:delete, _('Remove block'), { :action => 'remove', :id => block.id }, { :method => 'post'})
     end
+    if block.respond_to?(:help)
+      buttons << thickbox_inline_popup_icon(:help, _('Help on this block'), "help-on-box-#{block.id}") << content_tag('div', content_tag('h2', _('Help')) + content_tag('div', block.help, :style => 'margin-bottom: 1em;') + thickbox_close_button(_('Close')), :style => 'display: none;', :id => "help-on-box-#{block.id}")
+    end
+
     content_tag('div', buttons.join("\n") + tag('br', :style => 'clear: left'), :class => 'button-bar')
   end
@@ -2,6 +2,9 @@ module ThickboxHelper
   def thickbox_inline_popup_link(title, id, options = {})
     link_to(title, "#TB_inline?height=300&width=500&inlineId=#{id}&modal=true", {:class => 'thickbox'}.merge(options))
   end
+  def thickbox_inline_popup_icon(type, title, id, options = {})
+    icon_button(type, title, "#TB_inline?height=300&width=500&inlineId=#{id}&modal=true", {:class => "thickbox"}.merge(options))
+  end
   def thickbox_close_button(title)
     button_to_function(:close, title, 'tb_remove();')
   end
@@ -4,6 +4,10 @@ class ArticleBlock &lt; Block
     _('Display one of your contents.')
   end
+  def help
+    _('This block displays one of your articles. You can edit the block to select which one of your articles is going to be displayed in the block.')
+  end
+
   def content
     article ? article.to_html : _('Article not selected yet.')
   end
@@ -9,7 +9,7 @@ class CommunitiesBlock &lt; ProfileListBlock
   end
   def help
-    __('The communities in which the user is a member')
+    __('This block displays the communities in which the user is a member.')
   end
   def footer
@@ -5,7 +5,7 @@ class EnterprisesBlock &lt; ProfileListBlock
   end
   def help
-    __('The enterprises where this user works.')
+    __('This block displays the enterprises where this user works.')
   end
   def self.description
@@ -8,6 +8,10 @@ class EnvironmentStatisticsBlock &lt; Block
     _('Statistics for %s') % owner.name
   end
+  def help
+    _('This block presents some statistics about your environment.')
+  end
+
   def content
     users = owner.people.count(:conditions => { :public_profile => true })
     enterprises = owner.enterprises.count(:conditions => { :public_profile => true })
@@ -5,7 +5,7 @@ class FavoriteEnterprisesBlock &lt; ProfileListBlock
   end
   def help
-    __('This user\'s favorite enterprises.')
+    __('This block lists the favorite enterprises of the user.')
   end
   def self.description
@@ -8,6 +8,10 @@ class FriendsBlock &lt; ProfileListBlock
     __('Friends')
   end
+  def help
+    _('This block displays your friends.')
+  end
+
   def footer
     owner_id = owner.identifier
     lambda do
@@ -9,6 +9,10 @@ class LinkListBlock &lt; Block
   def self.description
     _('Display a list of links.')
   end
+
+  def help
+    _('This block can be used to create a menu of links. You can add, remove and update the links as you wish.')
+  end
   def content
     block_title(title) +
@@ -4,6 +4,10 @@ class LoginBlock &lt; Block
     _('A login box for your users.')
   end
+  def help
+    _('This block presents a login/logout block.')
+  end
+
   def content
     lambda do
       if logged_in?
@@ -4,6 +4,10 @@ class MainBlock &lt; Block
     _('Block for main content (i.e. your articles, photos, etc)')
   end
+  def help
+    _('This block presents the main content of your pages.')
+  end
+
   def content
     nil
   end
@@ -8,6 +8,10 @@ class MembersBlock &lt; ProfileListBlock
     _('Members')
   end
+  def help
+    _('This block presents the members of a collective.')
+  end
+
   def footer
     profile = self.owner
     lambda do
@@ -10,6 +10,10 @@ class MyNetworkBlock &lt; Block
     _('My network')
   end
+  def help
+    _('This block displays some info about your networking.')
+  end
+
   def content
     block_title(title) +
     content_tag(
@@ -12,6 +12,10 @@ class PeopleBlock &lt; ProfileListBlock
     _('A block displays random people')
   end
+  def help
+    _('This block presents a list of people.')
+  end
+
   def profile_finder
     @profile_finder ||= PeopleBlock::Finder.new(self)
   end
@@ -12,6 +12,10 @@ class ProductsBlock &lt; Block
     _('Products')
   end
+  def help
+    _('This block presents a list of your products.')
+  end
+
   def content
     block_title(title) +
     content_tag(
@@ -8,6 +8,10 @@ class RecentDocumentsBlock &lt; Block
     _('Recent content')
   end
+  def help
+    _('This block lists your recent content.')
+  end
+
   settings_items :limit
   include ActionController::UrlWriter
@@ -12,6 +12,10 @@ class SellersSearchBlock &lt; Block
     _('Search for sellers')
   end
+  def help
+    _('This block presents a search engine for products.')
+  end
+
   def content
     title = self.title
     lambda do
@@ -13,8 +13,8 @@ class TagsBlock &lt; Block
   end
   def help
-    _('The tag is created when you add some one to your article. <p/>
-       Try to add some tags to some articles and see your tag cloud to grow.')
+    _("Tags are created when you add some of them one to your contents. <p/>
+       Try to add some tags to some articles and you'l see your tag cloud growing.")
   end
   def content
@@ -78,8 +78,6 @@ class ProfileDesignControllerTest &lt; Test::Unit::TestCase
   def test_should_move_block_to_the_end_of_another_block
     get :move_block, :profile => 'designtestuser', :id => "block-#{@b1.id}", :target => "end-of-box-#{@box2.id}"
-    assert_response :success
-
     @b1.reload
     @box2.reload
@@ -92,8 +90,6 @@ class ProfileDesignControllerTest &lt; Test::Unit::TestCase
     # block 4 is in box 2
     get :move_block, :profile => 'designtestuser', :id => "block-#{@b1.id}", :target => "before-block-#{@b4.id}"
-    assert_response :success
-
     @b1.reload
     @b4.reload
@@ -105,7 +101,6 @@ class ProfileDesignControllerTest &lt; Test::Unit::TestCase
   def test_block_can_be_moved_up
     get :move_block, :profile => 'designtestuser', :id => "block-#{@b4.id}", :target => "before-block-#{@b3.id}"
-    assert_response :success
     @b4.reload
     @b3.reload
@@ -125,6 +120,16 @@ class ProfileDesignControllerTest &lt; Test::Unit::TestCase
     assert_equal [1,2,3],  [@b4, @b3, @b5].map {|item| item.position}
   end
+  def test_move_block_should_redirect_when_not_called_via_ajax
+    get :move_block, :profile => 'designtestuser', :id => "block-#{@b3.id}", :target => "before-block-#{@b5.id}"
+    assert_redirected_to :action => 'index'
+  end
+
+  def test_move_block_should_render_when_called_via_ajax
+    xml_http_request :get, :move_block, :profile => 'designtestuser', :id => "block-#{@b3.id}", :target => "before-block-#{@b5.id}"
+    assert_template 'move_block'
+  end
+
   def test_should_be_able_to_move_block_directly_down
     post :move_block_down, :profile => 'designtestuser', :id => @b1.id
     assert_response :redirect
	@@ -131,15 +131,30 @@ module BoxesHelper		@@ -131,15 +131,30 @@ module BoxesHelper
131		131
132	def block_edit_buttons(block)	132	def block_edit_buttons(block)
133	buttons = []	133	buttons = []
		134	+ nowhere = 'javascript: return false;'
134		135
135	- if !block.first?
136	- buttons << icon_button(:up, _('Move block up'), { :action => 'move_block_up', :id => block.id }, { :method => 'post' })	136	+ if block.first?
		137	+ buttons << icon_button('up-disabled', _("Can't move up anymore."), nowhere)
		138	+ else
		139	+ buttons << icon_button('up', _('Move block up'), { :action => 'move_block_up', :id => block.id }, { :method => 'post' })
137	end	140	end
138		141
139	- if !block.last?	142	+ if block.last?
		143	+ buttons << icon_button('down-disabled', _("Can't move down anymore."), nowhere)
		144	+ else
140	buttons << icon_button(:down, _('Move block down'), { :action => 'move_block_down' ,:id => block.id }, { :method => 'post'})	145	buttons << icon_button(:down, _('Move block down'), { :action => 'move_block_down' ,:id => block.id }, { :method => 'post'})
141	end	146	end
142		147
		148	+ # move to opposite side
		149	+ # FIXME too much hardcoded stuff
		150	+ if profile.layout_template == 'default'
		151	+ if block.box.position == 2 # area 2, left side => move to right side
		152	+ buttons << icon_button('right', _('Move to the opposite side'), { :action => 'move_block', :target => 'end-of-box-' + profile.boxes[2].id.to_s, :id => block.id }, :method => 'post' )
		153	+ elsif block.box.position == 3 # area 3, right side => move to left side
		154	+ buttons << icon_button('left', _('Move to the opposite side'), { :action => 'move_block', :target => 'end-of-box-' + profile.boxes[1].id.to_s, :id => block.id }, :method => 'post' )
		155	+ end
		156	+ end
		157	+
143	if block.editable?	158	if block.editable?
144	buttons << lightbox_icon_button(:edit, _('Edit'), { :action => 'edit', :id => block.id })	159	buttons << lightbox_icon_button(:edit, _('Edit'), { :action => 'edit', :id => block.id })
145	end	160	end
	@@ -148,6 +163,10 @@ module BoxesHelper		@@ -148,6 +163,10 @@ module BoxesHelper
148	buttons << icon_button(:delete, _('Remove block'), { :action => 'remove', :id => block.id }, { :method => 'post'})	163	buttons << icon_button(:delete, _('Remove block'), { :action => 'remove', :id => block.id }, { :method => 'post'})
149	end	164	end
150		165
		166	+ if block.respond_to?(:help)
		167	+ buttons << thickbox_inline_popup_icon(:help, _('Help on this block'), "help-on-box-#{block.id}") << content_tag('div', content_tag('h2', _('Help')) + content_tag('div', block.help, :style => 'margin-bottom: 1em;') + thickbox_close_button(_('Close')), :style => 'display: none;', :id => "help-on-box-#{block.id}")
		168	+ end
		169	+
151	content_tag('div', buttons.join("\n") + tag('br', :style => 'clear: left'), :class => 'button-bar')	170	content_tag('div', buttons.join("\n") + tag('br', :style => 'clear: left'), :class => 'button-bar')
152	end	171	end
153		172
	@@ -9,7 +9,7 @@ class CommunitiesBlock < ProfileListBlock		@@ -9,7 +9,7 @@ class CommunitiesBlock < ProfileListBlock
9	end	9	end
10		10
11	def help	11	def help
12	- __('The communities in which the user is a member')	12	+ __('This block displays the communities in which the user is a member.')
13	end	13	end
14		14
15	def footer	15	def footer
	@@ -5,7 +5,7 @@ class EnterprisesBlock < ProfileListBlock		@@ -5,7 +5,7 @@ class EnterprisesBlock < ProfileListBlock
5	end	5	end
6		6
7	def help	7	def help
8	- __('The enterprises where this user works.')	8	+ __('This block displays the enterprises where this user works.')
9	end	9	end
10		10
11	def self.description	11	def self.description
	@@ -5,7 +5,7 @@ class FavoriteEnterprisesBlock < ProfileListBlock		@@ -5,7 +5,7 @@ class FavoriteEnterprisesBlock < ProfileListBlock
5	end	5	end
6		6
7	def help	7	def help
8	- __('This user\'s favorite enterprises.')	8	+ __('This block lists the favorite enterprises of the user.')
9	end	9	end
10		10
11	def self.description	11	def self.description