Download as
Browse Code »

Commit 5efe2b44ab6e087c43ccad2cc3d6a79c9e095503

Authored by Antonio Terceiro
1 parent 26c87582
Exists in master and in 29 other branches add_member_task_reject_details, admin_visible_profile, article-list-template, community_notifications, contact_admin_translation, event_fixes, fix_comments_pagination, fix_rails4_organization_ratings, fix_sign_up_form, follow_step_fix, forum_topic_creation, mirror_block_improvements, multi_env_on_remote_user, new_security, noosfero_spb_ci, organization_ratings_improvements, organization_ratings_link_to_profile_stable-spb-1.3, organization_ratings_translations_fix, profile_api_improvements, ratings_minor_fixes, remote_user_fix, send_email_to_admins, stable-spb-1.3, stable-spb-1.3-fixes, stable-spb-1.4, stable-spb-1.5, suggest_rejected_value, web_steps_improvements, xss_terminate_custom_options

ActionItem1178: fixing profile image tests 

Probably Rails 2.1 changed the way the validation on associated objects
works. But eberything is fine now.
Showing 1 changed file with 3 additions and 3 deletions   Show diff stats
test/unit/profile_test.rb
  Diff comments   View file @5efe2b4
@@ -1341,13 +1341,13 @@ class ProfileTest < Test::Unit::TestCase @@ -1341,13 +1341,13 @@ class ProfileTest < Test::Unit::TestCase
1341 1341
1342 should 'validates profile image when save' do 1342 should 'validates profile image when save' do
1343 profile = Profile.create!(:name => 'Profile for testing ', :identifier => 'profilefortesting', :image_builder => {:uploaded_data => fixture_file_upload('/files/rails.png', 'image/png')}) 1343 profile = Profile.create!(:name => 'Profile for testing ', :identifier => 'profilefortesting', :image_builder => {:uploaded_data => fixture_file_upload('/files/rails.png', 'image/png')})
1344 - profile.image.expects(:valid?)  
1345 - assert profile.valid? 1344 + profile.image.expects(:valid?).returns(false).at_least_once
  1345 + assert !profile.valid?
1346 end 1346 end
1347 1347
1348 should 'profile is invalid when image not valid' do 1348 should 'profile is invalid when image not valid' do
1349 profile = Profile.create!(:name => 'Profile for testing ', :identifier => 'profilefortesting', :image_builder => {:uploaded_data => fixture_file_upload('/files/rails.png', 'image/png')}) 1349 profile = Profile.create!(:name => 'Profile for testing ', :identifier => 'profilefortesting', :image_builder => {:uploaded_data => fixture_file_upload('/files/rails.png', 'image/png')})
1350 - profile.image.expects(:valid?) 1350 + profile.image.expects(:valid?).returns(false).at_least_once
1351 profile.image.errors.add(:size, "fake error") 1351 profile.image.errors.add(:size, "fake error")
1352 assert !profile.valid? 1352 assert !profile.valid?
1353 end 1353 end