[Mezuro] Refactored duplicated code in views.

João M. M. da Silva + Diego Araújo · Paulo Meireles
1 parent 38d8bf14
Showing 28 changed files with 172 additions and 315 deletions Show diff stats
plugins/mezuro/controllers/myprofile/mezuro_plugin_metric_configuration_controller.rb
plugins/mezuro/controllers/myprofile/mezuro_plugin_range_controller.rb
plugins/mezuro/controllers/profile/mezuro_plugin_repository_controller.rb
plugins/mezuro/lib/mezuro_plugin/helpers/content_viewer_helper.rb
plugins/mezuro/test/functional/myprofile/mezuro_plugin_metric_configuration_controller_test.rb
plugins/mezuro/test/functional/profile/mezuro_plugin_repository_controller_test.rb
plugins/mezuro/views/cms/mezuro_plugin/_configuration_content.html.erb
plugins/mezuro/views/cms/mezuro_plugin/_mezuro_content_form.html.erb
plugins/mezuro/views/cms/mezuro_plugin/_project_content.html.erb
plugins/mezuro/views/cms/mezuro_plugin/_reading_group_content.html.erb
plugins/mezuro/views/content_viewer/show_configuration.rhtml
plugins/mezuro/views/content_viewer/show_project.rhtml
plugins/mezuro/views/content_viewer/show_reading_group.rhtml
plugins/mezuro/views/mezuro_plugin_metric_configuration/_compound_metric_configuration_form.html.erb
plugins/mezuro/views/mezuro_plugin_metric_configuration/_metric_configuration_view.rhtml
plugins/mezuro/views/mezuro_plugin_metric_configuration/_native_metric_configuration_form.rhtml
plugins/mezuro/views/mezuro_plugin_metric_configuration/_native_metric_configuration_view.rhtml
plugins/mezuro/views/mezuro_plugin_metric_configuration/edit_compound.html.erb
plugins/mezuro/views/mezuro_plugin_metric_configuration/edit_native.html.erb
plugins/mezuro/views/mezuro_plugin_metric_configuration/new_compound.html.erb
@@ -9,9 +9,9 @@ class MezuroPluginMetricConfigurationController &lt; MezuroPluginMyprofileControlle
  
   def new_native
     @configuration_content = profile.articles.find(params[:id])
-    @base_tool_name = params[:base_tool_name]
-    @metric = Kalibro::BaseTool.find_by_name(@base_tool_name).metric params[:metric_name]
     @reading_group_names_and_ids = reading_group_names_and_ids
+    @metric = Kalibro::BaseTool.find_by_name(params[:base_tool_name]).metric params[:metric_name]
+    @metric_configuration = Kalibro::MetricConfiguration.new :base_tool_name => params[:base_tool_name], :metric => @metric
   end
  
   def edit_native
@@ -22,6 +22,8 @@ class MezuroPluginMetricConfigurationController &lt; MezuroPluginMyprofileControlle
     @configuration_content = profile.articles.find(params[:id])
     @metric_configurations = @configuration_content.metric_configurations
     @reading_group_names_and_ids = reading_group_names_and_ids
+    metric = Kalibro::Metric.new :compound => true
+    @metric_configuration = Kalibro::MetricConfiguration.new :metric => metric
     if configuration_content_has_errors?
       redirect_to_error_page @configuration_content.errors[:base]
     end
@@ -34,11 +36,11 @@ class MezuroPluginMetricConfigurationController &lt; MezuroPluginMyprofileControlle
   def create
     configuration_content = profile.articles.find(params[:id])
     metric_configuration = Kalibro::MetricConfiguration.create(params[:metric_configuration])
-
+    
     if metric_configuration_has_errors? metric_configuration
       redirect_to_error_page metric_configuration.errors[0].message
     else
-      redirect_to(metric_configuration_url(configuration_content))
+      redirect_to(metric_configuration_url(configuration_content, metric_configuration.id))
     end
   end
  
@@ -85,12 +87,12 @@ class MezuroPluginMetricConfigurationController &lt; MezuroPluginMyprofileControlle
     not @configuration_content.errors[:base].nil?
   end
  
-  def metric_configuration_url configuration_content
+  def metric_configuration_url(configuration_content, metric_configuration_id)
     url = configuration_content.view_url
     url[:controller] = controller_name
     url[:id] = configuration_content.id
-    url[:metric_configuration_id] = params[:metric_configuration][:id].to_i
-    url[:action] = (params[:metric_configuration][:metric][:compound] ? "edit_compound" : "edit_native")
+    url[:metric_configuration_id] = metric_configuration_id
+    url[:action] = (params[:metric_configuration][:metric][:compound] == "true" ? "edit_compound" : "edit_native")
     url
   end
  
@@ -104,3 +106,4 @@ class MezuroPluginMetricConfigurationController &lt; MezuroPluginMyprofileControlle
   end
  
 end
+
@@ -40,8 +40,7 @@ class MezuroPluginRangeController &lt; MezuroPluginMyprofileController
   end
  
   def reading_labels_and_ids
-    array = Kalibro::Reading.readings_of(params[:reading_group_id].to_i).map { |reading| [reading.label, reading.id] }
-    array.sort { |x,y| x.first.downcase <=> y.first.downcase }
+    Kalibro::Reading.readings_of(params[:reading_group_id].to_i).map { |reading| [reading.label, reading.id] }
   end
  
   def save_range
@@ -19,7 +19,7 @@ class MezuroPluginRepositoryController &lt; MezuroPluginProfileController
  
     if( repository.errors.empty? )
       repository.process
-      redirect_to(repository_url(project_content))
+      redirect_to(repository_url(project_content, repository.id))
     else
       redirect_to_error_page repository.errors[0].message
     end
@@ -27,13 +27,13 @@ class MezuroPluginRepositoryController &lt; MezuroPluginProfileController
  
   def show 
     @project_content = profile.articles.find(params[:id])
-    @repository = @project_content.repositories.select{ |repository| repository.id.to_s == params[:repository_id] }.first
+    @repository = @project_content.repositories.select{ |repository| repository.id == params[:repository_id].to_i }.first
     @configuration_name = Kalibro::Configuration.configuration_of(@repository.id).name
   end
  
   def destroy
     project_content = profile.articles.find(params[:id])
-    repository = project_content.repositories.select{ |repository| repository.id.to_s == params[:repository_id] }.first
+    repository = Kalibro::Repository.new :id => params[:repository_id] 
     repository.destroy
     if( repository.errors.empty? )
       redirect_to project_content.view_url
@@ -44,11 +44,11 @@ class MezuroPluginRepositoryController &lt; MezuroPluginProfileController
  
   private
  
-  def repository_url project_content
+  def repository_url(project_content, repository_id)
     url = project_content.view_url
     url[:controller] = controller_name
     url[:id] = project_content.id
-    url[:repository_id] = params[:repository_id].to_i
+    url[:repository_id] = repository_id
     url[:action] = "show"
     url
   end
@@ -17,9 +17,7 @@ class MezuroPlugin::Helpers::ContentViewerHelper
   def self.license_options
    options = YAML.load_file("#{RAILS_ROOT}/plugins/mezuro/licenses.yml")
    options = options.split(";")
-   formated_options = []
-   options.each { |option| formated_options << [option, option] }
-   formated_options
+   options
   end
  
   def self.generate_chart(score_history)
@@ -56,7 +56,7 @@ class MezuroPluginMetricConfigurationControllerTest &lt; ActionController::TestCase
     get :new_native, :profile => @profile.identifier, :id => @configuration_content.id, :base_tool_name => @base_tool.name, :metric_name => @metric.name
     assert_equal @configuration_content, assigns(:configuration_content)
     assert_equal @metric.name, assigns(:metric).name
-    assert_equal @base_tool.name, assigns(:base_tool_name)
+    assert_equal @base_tool.name, assigns(:metric_configuration).base_tool_name
     assert_equal [[@reading_group.name,@reading_group.id]], assigns(:reading_group_names_and_ids)
     assert_response :success
   end
@@ -84,9 +84,8 @@ class MezuroPluginRepositoryControllerTest &lt; ActionController::TestCase
   end
  
   should 'destroy a repository' do
+    Kalibro::Repository.expects(:new).with(:id => @repository.id.to_s).returns(@repository)
     @repository.expects(:destroy)    
-    Kalibro::Repository.expects(:repositories_of).with(@content.project_id).returns([@repository])
-
     get :destroy, :profile => @profile.identifier, :id => @content.id, :repository_id => @repository.id
  
     assert @repository.errors.empty?
@@ -95,12 +94,11 @@ class MezuroPluginRepositoryControllerTest &lt; ActionController::TestCase
  
   should 'not destroy a repository' do
     @repository.errors = [Exception.new]
+    Kalibro::Repository.expects(:new).with(:id => @repository.id.to_s).returns(@repository)
     @repository.expects(:destroy)    
-    Kalibro::Repository.expects(:repositories_of).with(@content.project_id).returns([@repository])
-
     get :destroy, :profile => @profile.identifier, :id => @content.id, :repository_id => @repository.id
  
-    assert !@repository.errors.empty?
+    #TODO verify if it is redirected to the right page
     assert_response :redirect
   end
 end
@@ -9,18 +9,11 @@
  
  
 <%= hidden_field_tag 'configuration_content[profile_id]', profile.id %>
-<%= hidden_field_tag 'id', @article.id %>
 <%= hidden_field_tag 'configuration_id', @article.configuration_id %>
+<%= render :partial => "cms/mezuro_plugin/mezuro_content_form", :locals => {:f => f} %>
  
-<%= required_fields_message %>
-
-<%= required f.text_field(:name) %>
-
-<%= f.text_field :description %><br/>
-
+<br/>
 <%= if kalibro_configuration.nil?
   required labelled_form_field _('Clone Configuration'),
   f.select(:configuration_to_clone_id, configuration_names_and_ids)
 end %>
-<br/>
-
@@ -0,0 +1,4 @@
+<%= hidden_field_tag 'id', @article.id %>
+<%= required_fields_message %>
+<%= required f.text_field(:name) %>
+<%= f.text_field :description %><br/>
@@ -7,14 +7,5 @@
 <%= error_messages_for 'project_content' %>
  
 <%= hidden_field_tag 'project_content[profile_id]', profile.id %>
-<%= hidden_field_tag 'id', @article.id %>
 <%= hidden_field_tag 'project_id', @article.project_id %>
-
-<%= required_fields_message %>
-
-<%= required f.text_field(:name) %>
-
-<%= f.text_field :description %><br/>
-
-<!-- partial rendered in app/views/cms/edit.rhtml -->
-<!-- After submit, the action cms/new is called -->
+<%= render :partial => "cms/mezuro_plugin/mezuro_content_form", :locals => {:f => f} %>
@@ -7,14 +7,5 @@
 <%= error_messages_for 'reading_group_content' %>
  
 <%= hidden_field_tag 'reading_group_content[profile_id]', profile.id %>
-<%= hidden_field_tag 'id', @article.id %>
 <%= hidden_field_tag 'reading_group_id', (reading_group.id unless reading_group.nil?) %>
-
-<%= required_fields_message %>
-
-<%= required f.text_field(:name) %>
-
-<%= f.text_field :description %><br/>
-
-<!-- partial rendered in app/views/cms/edit.rhtml -->
-<!-- After submit, the action cms/new is called -->
+<%= render :partial => "cms/mezuro_plugin/mezuro_content_form", :locals => {:f => f} %>
 <% @configuration_content = @page
 @kalibro_configuration = @page.kalibro_configuration %>
+<!-- #TODO check owner verification to remove or edit metric configuration -->
 <% owner = (not user.nil?) && user.id == @profile.id %>
 <% unless @page.errors[:base].nil? %>
   <% if @page.errors[:base] =~ /Kalibro::Errors::RecordNotFound/ %>
 <% @project = @page.project %>
 <% unless @page.errors[:base].nil? %>
+<!-- #TODO add owner verification to remove or edit repository -->
   <% if @page.errors[:base] == "Kalibro::Errors::RecordNotFound" %>
     <h3>Warning:</h3>
     <p>This project doesn't exist on the Web Service. Do you want to <%= link_to 'delete', :action => 'destroy', :controller => 'cms', :profile => @page.profile.identifier, :id => @page.id %> or <%= link_to 'save it again', :action => 'edit', :controller => 'cms', :profile => @page.profile.identifier, :id => @page.id %>?</p>
 <% @reading_group = @page.reading_group %>
+<!-- #TODO add owner verification to remove or edit reading group -->
 <% unless @page.errors[:base].nil? %>
   <% if @page.errors[:base] == "Kalibro::Errors::RecordNotFound" %>
     <h3>Warning:</h3>
@@ -0,0 +1,19 @@
+<%= hidden_field_tag :id, @configuration_content.id %>
+<%= f.hidden_field :configuration_id, :value => @configuration_content.configuration_id %>
+
+<% f.fields_for :metric do |m| %>
+  <%= m.hidden_field :compound, :value => "true" %>
+  <%= required labelled_form_field _('Metric Name:'), m.text_field(:name, :value => @metric_configuration.metric.name) %>
+  <%= labelled_form_field _('Description:'), m.text_field(:description, :value => @metric_configuration.metric.description) %>
+  <%= required labelled_form_field _('Script:'), m.text_area(:script, :rows => 5, :value => @metric_configuration.metric.script) %>
+  <%= required labelled_form_field _('Scope:'), 
+        m.select(:scope, MezuroPlugin::Helpers::ContentViewerHelper.scope_options, :selected => @metric_configuration.metric.scope) %>
+<% end %>
+
+<%= required labelled_form_field _('Code:'), f.text_field(:code) %>
+<%= required labelled_form_field _('Aggregation Form:'),
+    f.select(:aggregation_form, MezuroPlugin::Helpers::ContentViewerHelper.aggregation_options) %>
+<%= required labelled_form_field _('Weight:'), f.text_field(:weight) %>
+<%= required labelled_form_field _('Reading Group:'), f.select(:reading_group_id, @reading_group_names_and_ids) %>
+
+<p><%= f.submit "Save" %></p>
@@ -1,15 +0,0 @@
-<p> 
-  <b>Collector Name:</b> <%= @metric_configuration.base_tool_name %>
-</p>
-<p> 
-  <b>Metric Name:</b> <%= @metric.name %>
-</p>
-<p>
-  <b>Code:</b> <%= @metric_configuration.code %>
-</p>
-<p>
-  <b>Aggregation Form:</b> <%= @metric_configuration.aggregation_form %>
-</p>
-<p>
- <b>Weight:</b> <%= @metric_configuration.weight %>
-</p>
-<% form_for :metric_configuration, :url => {:action =>"update", :controller => "mezuro_plugin_metric_configuration"}, :method => :get do |f| %>
-  <%= hidden_field_tag :id, @configuration_content.id %>
-  <%= f.hidden_field :configuration_id, :value => @configuration_content.configuration_id %>
-  <%= f.hidden_field :id %>
+<%= hidden_field_tag :id, @configuration_content.id %>
+<%= f.hidden_field :configuration_id, :value => @configuration_content.configuration_id %>
  
-  <%= labelled_form_field _('Collector Name:'), f.text_field(:base_tool_name, :readonly => true) %>
+<%= labelled_form_field _('Collector Name:'), f.text_field(:base_tool_name, :readonly => true) %>
  
-  <% f.fields_for :metric do |m| %>
-    <%= m.hidden_field :compound, :value => "false" %>
-    <% @metric.language.each do |language| %>
-      <%= m.hidden_field :language, :multiple => true, :value => language %>
-    <% end %>
-    <%= m.hidden_field "scope", :value => @metric.scope %>
-    <%= labelled_form_field _('Metric Name:'), m.text_field(:name, :value => @metric.name, :readonly => true) %>
-    <%= labelled_form_field _('Description:'), m.text_field(:description, :value => @metric.description, :readonly => true) %>
+<% f.fields_for :metric do |m| %>
+  <%= m.hidden_field :compound, :value => "false" %>
+  <% @metric_configuration.metric.language.each do |language| %>
+    <%= m.hidden_field :language, :multiple => true, :value => language %>
   <% end %>
-  
-  <%= required labelled_form_field _('Code:'), f.text_field(:code) %>
+  <%= m.hidden_field "scope", :value => @metric.scope %>
+  <%= required labelled_form_field _('Metric Name:'), m.text_field(:name, :readonly => true, :value => @metric.name) %>
+  <%= labelled_form_field _('Description:'), m.text_field(:description, :readonly => true, :value => @metric.description) %>
+<% end %>
  
-  <%= required labelled_form_field _('Aggregation Form:'),
-  f.select(:aggregation_form, MezuroPlugin::Helpers::ContentViewerHelper.aggregation_options) %>
+<%= required labelled_form_field _('Code:'), f.text_field(:code) %>
  
-  <%= required labelled_form_field _('Weight:'), f.text_field(:weight) %>
-  
-  <%= required labelled_form_field _('Reading Group:'),
-  f.select(:reading_group_id, @reading_group_names_and_ids) %>
-  
-  <p>
-    <%= f.submit "Save" %>
-  </p>
-<% end %>
+<%= required labelled_form_field _('Aggregation Form:'),
+f.select(:aggregation_form, MezuroPlugin::Helpers::ContentViewerHelper.aggregation_options) %>
+
+<%= required labelled_form_field _('Weight:'), f.text_field(:weight) %>
+
+<%= required labelled_form_field _('Reading Group:'),
+f.select(:reading_group_id, @reading_group_names_and_ids) %>
+
+<p><%= f.submit "Save" %></p>
@@ -0,0 +1,15 @@
+<p> 
+  <b>Collector Name:</b> <%= @metric_configuration.base_tool_name %>
+</p>
+<p> 
+  <b>Metric Name:</b> <%= @metric.name %>
+</p>
+<p>
+  <b>Code:</b> <%= @metric_configuration.code %>
+</p>
+<p>
+  <b>Aggregation Form:</b> <%= @metric_configuration.aggregation_form %>
+</p>
+<p>
+ <b>Weight:</b> <%= @metric_configuration.weight %>
+</p>
@@ -7,57 +7,8 @@
 <% owner = (not user.nil?) && user.id == @profile.id %>
  
 <% form_for :metric_configuration, :url => {:action =>"update", :controller => "mezuro_plugin_metric_configuration"}, :method => :get do |f| %>
-  <%= hidden_field_tag :id, @configuration_content.id %>
-  <%= f.hidden_field :configuration_id, :value => @configuration_content.configuration_id %>
   <%= f.hidden_field :id %>
-  
-  <% f.fields_for :metric do |m| %>
-    <%= m.hidden_field :compound, :value => "true" %>
-    <%= required labelled_form_field _('Metric Name:'), m.text_field(:name, :value => @metric.name) %>
-    <%= labelled_form_field _('Description:'), m.text_field(:description, :value => @metric.description) %>
-    <%= required labelled_form_field _('Script:'), m.text_area(:script, :rows => 5, :value => @metric.script) %>
-    <%= required labelled_form_field _('Scope:'), 
-          m.select(:scope, MezuroPlugin::Helpers::ContentViewerHelper.scope_options, :selected => @metric.scope) %>
-  <% end %>
-  
-  <%= required labelled_form_field _('Code:'), f.text_field(:code) %>
-  <%= required labelled_form_field _('Aggregation Form:'),
-      f.select(:aggregation_form, MezuroPlugin::Helpers::ContentViewerHelper.aggregation_options) %>
-  <%= required labelled_form_field _('Weight:'), f.text_field(:weight) %>
-  <%= required labelled_form_field _('Reading Group:'), f.select(:reading_group_id, @reading_group_names_and_ids) %>
-  
-  <p><%= f.submit "Save" %></p>
-  
+  <%= render :partial => "compound_metric_configuration_form", :locals => {:f => f} %>
 <% end %>
  
-<h5> Ranges </h5><br/>
-
-<table id="ranges">
-  <tr>
-    <td>
-      Label
-    </td>
-    <td>
-      Beginning
-    </td>
-    <td>
-      End
-    </td>
-    <td>
-      Grade
-    </td>
-    <td>
-      Color
-    </td>       
-  </tr>
-  <% @ranges.each do |range| %>
-      <%= render :partial => "mezuro_plugin_range/range", :locals => {:range => range, :id => @configuration_content.id, 
-          :metric_configuration_id => @metric_configuration.id, :reading_group_id => @metric_configuration.reading_group_id, :compound => @metric_configuration.metric.compound} %>
-  <% end %>
-</table>
-
-<br/>
-<% if owner %>
-  <%= link_to_remote "New Range", :url => {:action =>"new", :controller => "mezuro_plugin_range", :id => @configuration_content.id, :metric_configuration_id => @metric_configuration.id, :reading_group_id => @metric_configuration.reading_group_id} %>
-<% end %>
-<div id="form" style="display:none"></div>
+<%= render :partial => "mezuro_plugin_range/ranges", :locals => {:owner => owner} %>
@@ -7,42 +7,12 @@
 <% owner = (not user.nil?) && user.id == @profile.id %>
  
 <% if owner %>
-  <%=  render :partial => "native_metric_configuration_form" %>
-<% else %>
-  <%=  render :partial => "metric_configuration_view" %>
-<% end %>
-
-<h5> Ranges </h5><br/>
-
-<table id="ranges">
-  <tr>
-    <td>
-      Label
-    </td>
-    <td>
-      Beginning
-    </td>
-    <td>
-      End
-    </td>
-    <td>
-      Grade
-    </td>
-    <td>
-      Color
-    </td>   
-    <td></td>    
-    <td></td>
-  </tr>
-  <% @ranges.each do |range| %>
-      <%= render :partial => "mezuro_plugin_range/range", :locals => {:range => range, :id => @configuration_content.id, 
-          :metric_configuration_id => @metric_configuration.id, :reading_group_id => @metric_configuration.reading_group_id, :compound => @metric_configuration.metric.compound} %>
+  <% form_for :metric_configuration, :url => {:action =>"update", :controller => "mezuro_plugin_metric_configuration"}, :method => :get do |f| %>
+    <%= f.hidden_field :id %>
+    <%= render :partial => "native_metric_configuration_form", :locals => {:f => f} %>
   <% end %>
-</table>
-
-<br/>
-<% if owner %>
-  <%= link_to_remote "New Range", :url => {:action =>"new", :controller => "mezuro_plugin_range", :id => @configuration_content.id, :metric_configuration_id => @metric_configuration.id, :reading_group_id => @metric_configuration.reading_group_id, :compound => @metric_configuration.metric.compound} %>
+<% else %>
+  <%=  render :partial => "native_metric_configuration_view" %>
 <% end %>
-<div id="form" style="display:none"></div>
  
+<%= render :partial => "mezuro_plugin_range/ranges", :locals => {:owner => owner} %>
 <h2><%= link_to("#{@configuration_content.name} Configuration", @configuration_content.view_url) %></h2>
  
 <% form_for :metric_configuration, :url => {:action =>"create", :controller => "mezuro_plugin_metric_configuration"}, :method => :get do |f| %>
-  <%= hidden_field_tag :id, @configuration_content.id %>
-  <%= f.hidden_field :configuration_id, :value => @configuration_content.configuration_id %>
-
-  <% f.fields_for :metric do |m| %>
-    <%= m.hidden_field :compound, :value => "true" %>
-    <%= required labelled_form_field _('Metric Name:'), m.text_field(:name) %>
-    <%= labelled_form_field _('Description:'), m.text_field(:description) %>
-    <%= required labelled_form_field _('Script:'), m.text_area(:script, :rows => 5) %>
-    <%= required labelled_form_field _('Scope:'), m.select(:scope, MezuroPlugin::Helpers::ContentViewerHelper.scope_options) %>
-  <% end %>
-
-  <%= required labelled_form_field _('Code:'), f.text_field(:code) %>
-  <%= required labelled_form_field _('Aggregation Form:'), f.select(:aggregation_form, MezuroPlugin::Helpers::ContentViewerHelper.aggregation_options) %>
-  <%= required labelled_form_field _('Weight:'), f.text_field(:weight) %>
-  <%= required labelled_form_field _('Reading Group:'),
-  f.select(:reading_group_id, @reading_group_names_and_ids) %>
-  
-  <p> <%= f.submit "Add" %> </p>
+  <%= render :partial => "compound_metric_configuration_form", :locals => {:f => f} %>
 <% end %>
  
 <%= render :partial => "metric_codes", :locals => {:metric_configurations => @metric_configurations} %>
-
-
 <script src="/plugins/mezuro/javascripts/validations.js" type="text/javascript"></script>
  
 <h2><%= link_to("#{@configuration_content.name} Configuration", @configuration_content.view_url) %></h2>
-<!-- TODO This form should be a partial similar to _native_metric_configuration_form.rhtml -->
-<% form_for :metric_configuration, :url => {:action =>"create", :controller => "mezuro_plugin_metric_configuration"},  :method => :get do |f| %>
-
-  <%= hidden_field_tag :id, @configuration_content.id %>
-  <%= f.hidden_field :configuration_id, :value => @configuration_content.configuration_id %>
-
-  <%= labelled_form_field _('Collector Name:'), f.text_field(:base_tool_name, :value => @base_tool_name, :readonly => true) %>
-
-  <% f.fields_for :metric do |m| %>
-    <%= m.hidden_field :compound, :value => "false" %>
-    <% @metric.language.each do |language| %>
-      <%= m.hidden_field :language, :multiple => true, :value => language %>
-    <% end %>
-    <%= m.hidden_field "scope", :value => @metric.scope %>
-    <%= labelled_form_field _('Metric Name:'), m.text_field(:name, :value => @metric.name, :readonly => true) %>
-    <%= labelled_form_field _('Description:'), m.text_field(:description, :value => @metric.description, :readonly => true) %>
-  <% end %>
-
-  <%= required labelled_form_field _('Code:'), f.text_field(:code) %>
-
-  <%= required labelled_form_field _('Aggregation Form:'),
-  f.select(:aggregation_form, MezuroPlugin::Helpers::ContentViewerHelper.aggregation_options) %>
-
-  <%= required labelled_form_field _('Weight:'), f.text_field(:weight) %>
-
-  <%= required labelled_form_field _('Reading Group:'),
-  f.select(:reading_group_id, @reading_group_names_and_ids) %>
-
-  <p>
-    <%= f.submit "Save" %>
-  </p>
  
+<% form_for :metric_configuration, :url => {:action =>"create", :controller => "mezuro_plugin_metric_configuration"},  :method => :get do |f| %>
+  <%= render :partial => "native_metric_configuration_form", :locals => {:f => f} %>
 <% end %>
-
@@ -0,0 +1,31 @@
+<h5> Ranges </h5><br/>
+
+<table id="ranges">
+  <tr>
+    <td>
+      Label
+    </td>
+    <td>
+      Beginning
+    </td>
+    <td>
+      End
+    </td>
+    <td>
+      Grade
+    </td>
+    <td>
+      Color
+    </td>       
+  </tr>
+  <% @ranges.each do |range| %>
+      <%= render :partial => "mezuro_plugin_range/range", :locals => {:range => range, :id => @configuration_content.id, 
+          :metric_configuration_id => @metric_configuration.id, :reading_group_id => @metric_configuration.reading_group_id, :compound => @metric_configuration.metric.compound} %>
+  <% end %>
+</table>
+
+<br/>
+<% if owner %>
+  <%= link_to_remote "New Range", :url => {:action =>"new", :controller => "mezuro_plugin_range", :id => @configuration_content.id, :metric_configuration_id => @metric_configuration.id, :reading_group_id => @metric_configuration.reading_group_id, :compound => @metric_configuration.metric.compound} %>
+<% end %>
+<div id="form" style="display:none"></div>
@@ -0,0 +1,11 @@
+<%= hidden_field_tag :id, @reading_group_content.id %>
+
+<%= required labelled_form_field _('label:'), f.text_field(:label) %> 
+
+<%= required labelled_form_field _('grade:'),
+f.text_field(:grade) %>
+
+<%= required labelled_form_field _('color:'),
+colorpicker_field(:reading, :color) %>Click in the field to change Color
+
+<p><%= f.submit "Save" %></p>
@@ -3,19 +3,6 @@
 <h2><%= link_to("#{@reading_group_content.name} Reading Group", @reading_group_content.view_url) %></h2>
  
 <% form_for :reading, :url => {:action =>"save", :controller => "mezuro_plugin_reading"},  :method => :get do |f| %>
-  <%= hidden_field_tag :id, @reading_group_content.id %>
-  
   <%= f.hidden_field :id %>
-  <%= required labelled_form_field _('label:'), f.text_field(:label) %> 
-
-  <%= required labelled_form_field _('grade:'),
-  f.text_field(:grade) %>
-  
-  <%= required labelled_form_field _('color:'),
-  colorpicker_field(:reading, :color) %>Click in the field to change Color
-  
-  <p>
-    <%= f.submit "Add" %>
-  </p>
-
+  <%= render :partial => "form", :locals => {:f => f} %>
 <% end %>
@@ -3,18 +3,5 @@
 <h2><%= link_to("#{@reading_group_content.name} Reading Group", @reading_group_content.view_url) %></h2>
  
 <% form_for :reading, :url => {:action =>"save", :controller => "mezuro_plugin_reading"},  :method => :get do |f| %>
-  <%= hidden_field_tag :id, @reading_group_content.id %>
-  
-  <%= required labelled_form_field _('label:'), f.text_field(:label) %> 
-
-  <%= required labelled_form_field _('grade:'),
-  f.text_field(:grade) %>
-  
-  <%= required labelled_form_field _('color:'),
-  colorpicker_field(:reading, :color) %>Click in the field to change Color
-  
-  <p>
-    <%= f.submit "Add" %>
-  </p>
-
+  <%= render :partial => "form", :locals => {:f => f} %>
 <% end %>
@@ -0,0 +1,28 @@
+<h2><%= link_to("#{@project_content.name} Project", @project_content.view_url) %></h2>
+
+<% form_for :repository, :url => {:action =>"save", :controller => "mezuro_plugin_repository"},  :method => :get do |f| %>
+  <%= f.hidden_field :id %>
+  <%= hidden_field_tag :id, @project_content.id %>
+
+  <%= required labelled_form_field _('Name'), f.text_field(:name) %> 
+
+  <%= labelled_form_field _("Description"), f.text_field(:description) %>
+
+  <%= required labelled_form_field _('License'),
+  f.select(:license, MezuroPlugin::Helpers::ContentViewerHelper.license_options) %>
+
+  <%= required labelled_form_field _('Process Period'),
+  f.select(:process_period, MezuroPlugin::Helpers::ContentViewerHelper.periodicity_options) %>
+
+  <%= required labelled_form_field _('Type'),
+  f.select(:type, @repository_types) %>
+
+  <%= required labelled_form_field _('Address'),
+  f.text_field(:address) %>
+
+  <%= required labelled_form_field _('Configuration'),
+  f.select(:configuration_id, @configuration_select) %>
+
+  <p> <%= f.submit "Add" %> </p>
+
+<% end %>
-<h2><%= link_to("#{@project_content.name} Project", @project_content.view_url) %></h2>
-
-<% form_for :repository, :url => {:action =>"save", :controller => "mezuro_plugin_repository"},  :method => :get do |f| %>
-  <%= hidden_field_tag :id, @project_content.id %>
-
-  <%= f.hidden_field :id%>
-  <%= required labelled_form_field _('Name:'), f.text_field(:name) %> 
-
-  <%= labelled_form_field _("Description:"), f.text_field(:description) %>
-
-  <%= required labelled_form_field _('License'),
-  f.select(:license, MezuroPlugin::Helpers::ContentViewerHelper.license_options, :selected => @repository.license) %>
-
-  <%= required labelled_form_field _('Process Period'),
-  f.select(:process_period, MezuroPlugin::Helpers::ContentViewerHelper.periodicity_options, :selected => @repository.process_period.to_i) %>
-
-  <%= required labelled_form_field _('Type'),
-  f.select(:type, @repository_types, :selected => @repository.type) %>
-
-  <%= required labelled_form_field _('Address'),
-  f.text_field(:address) %>
-
-  <%= required labelled_form_field _('Configuration'),
-  f.select(:configuration_id, @configuration_select, :selected => @repository.configuration_id.to_i) %>
-
-  <p> <%= f.submit "Add" %> </p>
-
-<% end %>
+<%= render :partial => "form" %>
-<h2><%= link_to("#{@project_content.name} Project", @project_content.view_url) %></h2>
-
-<% form_for :repository, :url => {:action =>"save", :controller => "mezuro_plugin_repository"},  :method => :get do |f| %>
-  <%= hidden_field_tag :id, @project_content.id %>
-  
-  <%= required labelled_form_field _('Name:'), f.text_field(:name) %> 
-
-  <%= labelled_form_field _('Description'), f.text_field(:description) %>
-  
-  <%= required labelled_form_field _('License'),
-  f.select(:license, MezuroPlugin::Helpers::ContentViewerHelper.license_options) %>
-
-  <%= required labelled_form_field _('Process Period'),
-  f.select(:process_period, MezuroPlugin::Helpers::ContentViewerHelper.periodicity_options ) %>
-  
-  <%= required labelled_form_field _('Type'),
-  f.select(:type, @repository_types) %>
-  
-  <%= required labelled_form_field _('Address'),
-  f.text_field(:address) %>
-
-  <%= required labelled_form_field _('Configuration'),
-  f.select(:configuration_id, @configuration_select) %>
-
-  <p> <%= f.submit "Add" %> </p>
-
-<% end %>
+<%= render :partial => "form" %>
...	...	@@ -9,9 +9,9 @@ class MezuroPluginMetricConfigurationController < MezuroPluginMyprofileControlle
9	9
10	10	def new_native
11	11	@configuration_content = profile.articles.find(params[:id])
12		- @base_tool_name = params[:base_tool_name]
13		- @metric = Kalibro::BaseTool.find_by_name(@base_tool_name).metric params[:metric_name]
14	12	@reading_group_names_and_ids = reading_group_names_and_ids
	13	+ @metric = Kalibro::BaseTool.find_by_name(params[:base_tool_name]).metric params[:metric_name]
	14	+ @metric_configuration = Kalibro::MetricConfiguration.new :base_tool_name => params[:base_tool_name], :metric => @metric
15	15	end
16	16
17	17	def edit_native
...	...	@@ -22,6 +22,8 @@ class MezuroPluginMetricConfigurationController < MezuroPluginMyprofileControlle
22	22	@configuration_content = profile.articles.find(params[:id])
23	23	@metric_configurations = @configuration_content.metric_configurations
24	24	@reading_group_names_and_ids = reading_group_names_and_ids
	25	+ metric = Kalibro::Metric.new :compound => true
	26	+ @metric_configuration = Kalibro::MetricConfiguration.new :metric => metric
25	27	if configuration_content_has_errors?
26	28	redirect_to_error_page @configuration_content.errors[:base]
27	29	end
...	...	@@ -34,11 +36,11 @@ class MezuroPluginMetricConfigurationController < MezuroPluginMyprofileControlle
34	36	def create
35	37	configuration_content = profile.articles.find(params[:id])
36	38	metric_configuration = Kalibro::MetricConfiguration.create(params[:metric_configuration])
37		-
	39	+
38	40	if metric_configuration_has_errors? metric_configuration
39	41	redirect_to_error_page metric_configuration.errors[0].message
40	42	else
41		- redirect_to(metric_configuration_url(configuration_content))
	43	+ redirect_to(metric_configuration_url(configuration_content, metric_configuration.id))
42	44	end
43	45	end
44	46
...	...	@@ -85,12 +87,12 @@ class MezuroPluginMetricConfigurationController < MezuroPluginMyprofileControlle
85	87	not @configuration_content.errors[:base].nil?
86	88	end
87	89
88		- def metric_configuration_url configuration_content
	90	+ def metric_configuration_url(configuration_content, metric_configuration_id)
89	91	url = configuration_content.view_url
90	92	url[:controller] = controller_name
91	93	url[:id] = configuration_content.id
92		- url[:metric_configuration_id] = params[:metric_configuration][:id].to_i
93		- url[:action] = (params[:metric_configuration][:metric][:compound] ? "edit_compound" : "edit_native")
	94	+ url[:metric_configuration_id] = metric_configuration_id
	95	+ url[:action] = (params[:metric_configuration][:metric][:compound] == "true" ? "edit_compound" : "edit_native")
94	96	url
95	97	end
96	98
...	...	@@ -104,3 +106,4 @@ class MezuroPluginMetricConfigurationController < MezuroPluginMyprofileControlle
104	106	end
105	107
106	108	end
	109	+
...	...
...	...	@@ -40,8 +40,7 @@ class MezuroPluginRangeController < MezuroPluginMyprofileController
40	40	end
41	41
42	42	def reading_labels_and_ids
43		- array = Kalibro::Reading.readings_of(params[:reading_group_id].to_i).map { \|reading\| [reading.label, reading.id] }
44		- array.sort { \|x,y\| x.first.downcase <=> y.first.downcase }
	43	+ Kalibro::Reading.readings_of(params[:reading_group_id].to_i).map { \|reading\| [reading.label, reading.id] }
45	44	end
46	45
47	46	def save_range
...	...
...	...	@@ -19,7 +19,7 @@ class MezuroPluginRepositoryController < MezuroPluginProfileController
19	19
20	20	if( repository.errors.empty? )
21	21	repository.process
22		- redirect_to(repository_url(project_content))
	22	+ redirect_to(repository_url(project_content, repository.id))
23	23	else
24	24	redirect_to_error_page repository.errors[0].message
25	25	end
...	...	@@ -27,13 +27,13 @@ class MezuroPluginRepositoryController < MezuroPluginProfileController
27	27
28	28	def show
29	29	@project_content = profile.articles.find(params[:id])
30		- @repository = @project_content.repositories.select{ \|repository\| repository.id.to_s == params[:repository_id] }.first
	30	+ @repository = @project_content.repositories.select{ \|repository\| repository.id == params[:repository_id].to_i }.first
31	31	@configuration_name = Kalibro::Configuration.configuration_of(@repository.id).name
32	32	end
33	33
34	34	def destroy
35	35	project_content = profile.articles.find(params[:id])
36		- repository = project_content.repositories.select{ \|repository\| repository.id.to_s == params[:repository_id] }.first
	36	+ repository = Kalibro::Repository.new :id => params[:repository_id]
37	37	repository.destroy
38	38	if( repository.errors.empty? )
39	39	redirect_to project_content.view_url
...	...	@@ -44,11 +44,11 @@ class MezuroPluginRepositoryController < MezuroPluginProfileController
44	44
45	45	private
46	46
47		- def repository_url project_content
	47	+ def repository_url(project_content, repository_id)
48	48	url = project_content.view_url
49	49	url[:controller] = controller_name
50	50	url[:id] = project_content.id
51		- url[:repository_id] = params[:repository_id].to_i
	51	+ url[:repository_id] = repository_id
52	52	url[:action] = "show"
53	53	url
54	54	end
...	...
...	...	@@ -17,9 +17,7 @@ class MezuroPlugin::Helpers::ContentViewerHelper
17	17	def self.license_options
18	18	options = YAML.load_file("#{RAILS_ROOT}/plugins/mezuro/licenses.yml")
19	19	options = options.split(";")
20		- formated_options = []
21		- options.each { \|option\| formated_options << [option, option] }
22		- formated_options
	20	+ options
23	21	end
24	22
25	23	def self.generate_chart(score_history)
...	...
...	...	@@ -56,7 +56,7 @@ class MezuroPluginMetricConfigurationControllerTest < ActionController::TestCase
56	56	get :new_native, :profile => @profile.identifier, :id => @configuration_content.id, :base_tool_name => @base_tool.name, :metric_name => @metric.name
57	57	assert_equal @configuration_content, assigns(:configuration_content)
58	58	assert_equal @metric.name, assigns(:metric).name
59		- assert_equal @base_tool.name, assigns(:base_tool_name)
	59	+ assert_equal @base_tool.name, assigns(:metric_configuration).base_tool_name
60	60	assert_equal [[@reading_group.name,@reading_group.id]], assigns(:reading_group_names_and_ids)
61	61	assert_response :success
62	62	end
...	...
...	...	@@ -84,9 +84,8 @@ class MezuroPluginRepositoryControllerTest < ActionController::TestCase
84	84	end
85	85
86	86	should 'destroy a repository' do
	87	+ Kalibro::Repository.expects(:new).with(:id => @repository.id.to_s).returns(@repository)
87	88	@repository.expects(:destroy)
88		- Kalibro::Repository.expects(:repositories_of).with(@content.project_id).returns([@repository])
89		-
90	89	get :destroy, :profile => @profile.identifier, :id => @content.id, :repository_id => @repository.id
91	90
92	91	assert @repository.errors.empty?
...	...	@@ -95,12 +94,11 @@ class MezuroPluginRepositoryControllerTest < ActionController::TestCase
95	94
96	95	should 'not destroy a repository' do
97	96	@repository.errors = [Exception.new]
	97	+ Kalibro::Repository.expects(:new).with(:id => @repository.id.to_s).returns(@repository)
98	98	@repository.expects(:destroy)
99		- Kalibro::Repository.expects(:repositories_of).with(@content.project_id).returns([@repository])
100		-
101	99	get :destroy, :profile => @profile.identifier, :id => @content.id, :repository_id => @repository.id
102	100
103		- assert !@repository.errors.empty?
	101	+ #TODO verify if it is redirected to the right page
104	102	assert_response :redirect
105	103	end
106	104	end
...	...
...	...	@@ -9,18 +9,11 @@
9	9
10	10
11	11	<%= hidden_field_tag 'configuration_content[profile_id]', profile.id %>
12		-<%= hidden_field_tag 'id', @article.id %>
13	12	<%= hidden_field_tag 'configuration_id', @article.configuration_id %>
	13	+<%= render :partial => "cms/mezuro_plugin/mezuro_content_form", :locals => {:f => f} %>
14	14
15		-<%= required_fields_message %>
16		-
17		-<%= required f.text_field(:name) %>
18		-
19		-<%= f.text_field :description %><br/>
20		-
	15	+<br/>
21	16	<%= if kalibro_configuration.nil?
22	17	required labelled_form_field _('Clone Configuration'),
23	18	f.select(:configuration_to_clone_id, configuration_names_and_ids)
24	19	end %>
25		-<br/>
26		-
...	...
...	...	@@ -0,0 +1,4 @@
	1	+<%= hidden_field_tag 'id', @article.id %>
	2	+<%= required_fields_message %>
	3	+<%= required f.text_field(:name) %>
	4	+<%= f.text_field :description %><br/>
...	...
...	...	@@ -7,14 +7,5 @@
7	7	<%= error_messages_for 'project_content' %>
8	8
9	9	<%= hidden_field_tag 'project_content[profile_id]', profile.id %>
10		-<%= hidden_field_tag 'id', @article.id %>
11	10	<%= hidden_field_tag 'project_id', @article.project_id %>
12		-
13		-<%= required_fields_message %>
14		-
15		-<%= required f.text_field(:name) %>
16		-
17		-<%= f.text_field :description %><br/>
18		-
19		-<!-- partial rendered in app/views/cms/edit.rhtml -->
20		-<!-- After submit, the action cms/new is called -->
	11	+<%= render :partial => "cms/mezuro_plugin/mezuro_content_form", :locals => {:f => f} %>
...	...
...	...	@@ -7,14 +7,5 @@
7	7	<%= error_messages_for 'reading_group_content' %>
8	8
9	9	<%= hidden_field_tag 'reading_group_content[profile_id]', profile.id %>
10		-<%= hidden_field_tag 'id', @article.id %>
11	10	<%= hidden_field_tag 'reading_group_id', (reading_group.id unless reading_group.nil?) %>
12		-
13		-<%= required_fields_message %>
14		-
15		-<%= required f.text_field(:name) %>
16		-
17		-<%= f.text_field :description %><br/>
18		-
19		-<!-- partial rendered in app/views/cms/edit.rhtml -->
20		-<!-- After submit, the action cms/new is called -->
	11	+<%= render :partial => "cms/mezuro_plugin/mezuro_content_form", :locals => {:f => f} %>
...	...