Download as
Browse Code »

Commit 7225f597649f6079c85e9a4567092f533862d5ee

Authored by Antonio Terceiro
1 parent 1668fe7d
Exists in master and in 29 other branches add_member_task_reject_details, admin_visible_profile, article-list-template, community_notifications, contact_admin_translation, event_fixes, fix_comments_pagination, fix_rails4_organization_ratings, fix_sign_up_form, follow_step_fix, forum_topic_creation, mirror_block_improvements, multi_env_on_remote_user, new_security, noosfero_spb_ci, organization_ratings_improvements, organization_ratings_link_to_profile_stable-spb-1.3, organization_ratings_translations_fix, profile_api_improvements, ratings_minor_fixes, remote_user_fix, send_email_to_admins, stable-spb-1.3, stable-spb-1.3-fixes, stable-spb-1.4, stable-spb-1.5, suggest_rejected_value, web_steps_improvements, xss_terminate_custom_options

Now really avoid division by zero 

(ActionItem1682)
Showing 2 changed files with 10 additions and 3 deletions   Show diff stats
app/models/profile_list_block.rb
  Diff comments   View file @7225f59
@@ -21,7 +21,7 @@ class ProfileListBlock < Block @@ -21,7 +21,7 @@ class ProfileListBlock < Block
21 end 21 end
22 22
23 def randomizer 23 def randomizer
24 - @randomizer ||= "(profiles.id % #{rand(profile_count + 1)})" 24 + @randomizer ||= "(profiles.id % #{rand(profile_count) + 1})"
25 end 25 end
26 26
27 # the title of the block. Probably will be overriden in subclasses. 27 # the title of the block. Probably will be overriden in subclasses.
test/unit/profile_list_block_test.rb
  Diff comments   View file @7225f59
@@ -153,8 +153,15 @@ class ProfileListBlockTest < Test::Unit::TestCase @@ -153,8 +153,15 @@ class ProfileListBlockTest < Test::Unit::TestCase
153 should 'randomize using modulo operator and random number' do 153 should 'randomize using modulo operator and random number' do
154 block = ProfileListBlock.new 154 block = ProfileListBlock.new
155 block.expects(:profile_count).returns(10) 155 block.expects(:profile_count).returns(10)
156 - block.expects(:rand).with(11).returns(5)  
157 - assert_match /profiles.id % 5/, block.randomizer 156 + block.expects(:rand).with(10).returns(5)
  157 + assert_match /profiles.id % 6/, block.randomizer
  158 + end
  159 +
  160 + should 'not divide by zero' do
  161 + block = ProfileListBlock.new
  162 + block.stubs(:profile_count).returns(0)
  163 + block.expects(:rand).returns(0)
  164 + assert_no_match /profiles.id % 0/, block.randomizer
158 end 165 end
159 166
160 end 167 end