Download as
Browse Code »

Commit 73479a2c7c52e323c027dc83ad06f157d221ca17

Authored by Rodrigo Souto
1 parent cd32f252
Exists in master and in 29 other branches add_member_task_reject_details, admin_visible_profile, article-list-template, community_notifications, contact_admin_translation, event_fixes, fix_comments_pagination, fix_rails4_organization_ratings, fix_sign_up_form, follow_step_fix, forum_topic_creation, mirror_block_improvements, multi_env_on_remote_user, new_security, noosfero_spb_ci, organization_ratings_improvements, organization_ratings_link_to_profile_stable-spb-1.3, organization_ratings_translations_fix, profile_api_improvements, ratings_minor_fixes, remote_user_fix, send_email_to_admins, stable-spb-1.3, stable-spb-1.3-fixes, stable-spb-1.4, stable-spb-1.5, suggest_rejected_value, web_steps_improvements, xss_terminate_custom_options

application_helper/rolename: improve performance retrieval and readability

Showing 1 changed file with 4 additions and 1 deletions   Show diff stats
app/helpers/application_helper.rb
  Diff comments   View file @73479a2
... ... @@ -727,7 +727,10 @@ module ApplicationHelper
727 727 end
728 728  
729 729 def rolename_for(profile, resource)
730   - roles = profile.role_assignments.select{ |a| a.resource_id == resource.id }.sort_by{ |s| s.role_id }.map(&:role)
  730 + roles = profile.role_assignments.
  731 + where(:resource_id => resource.id).
  732 + sort_by{ |role_assignment| role_assignment.role_id }.
  733 + map(&:role)
731 734 names = []
732 735 roles.each do |role|
733 736 names << content_tag('span', role.name, :style => "color: #{role_color(role, resource.environment.id)}")
... ...