Merge branch 'update-client' into merging_configuration

Alessandro Palmeira
2 parents 07e19481 f909e2e2
Showing 14 changed files with 239 additions and 18 deletions Show diff stats
plugins/mezuro/lib/kalibro/client/metric_configuration_client.rb
plugins/mezuro/lib/kalibro/client/port.rb
plugins/mezuro/lib/kalibro/entities/entity.rb
plugins/mezuro/lib/kalibro/entities/metric_configuration.rb
plugins/mezuro/lib/kalibro/entities/native_metric.rb
plugins/mezuro/lib/kalibro/entities/range.rb
plugins/mezuro/test/fixtures/compound_metric_with_error_fixtures.rb
plugins/mezuro/test/fixtures/metric_configuration_fixtures.rb
plugins/mezuro/test/fixtures/metric_result_fixtures.rb
plugins/mezuro/test/fixtures/native_metric_fixtures.rb
plugins/mezuro/test/functional/base_tool_client_test.rb
plugins/mezuro/test/functional/fake_port.rb
plugins/mezuro/test/functional/metric_configuration_client_test.rb
plugins/mezuro/test/unit/kalibro/client/metric_configuration_client_test.rb
@@ -0,0 +1,28 @@
+class Kalibro::Client::MetricConfigurationClient
+
+  def initialize
+    @port = Kalibro::Client::Port.new('MetricConfiguration')
+  end
+
+  def save(metric_configuration, configuration_name)
+    @port.request(:save_metric_configuration, {
+        :metric_configuration => metric_configuration.to_hash,
+        :configuration_name => configuration_name})
+  end
+
+  def metric_configuration(configuration_name, metric_name)
+    hash = @port.request(:get_metric_configuration, {
+        :configuration_name => configuration_name,
+        :metric_name => metric_name
+      })[:metric_configuration]
+    Kalibro::Entities::MetricConfiguration.from_hash(hash)
+  end
+
+  def remove (configuration_name, metric_name)
+    @port.request(:remove_metric_configuration, {
+        :configuration_name => configuration_name,
+        :metric_name=> metric_name
+      })
+  end
+
+end
 \ No newline at end of file
@@ -7,7 +7,8 @@ end
 class Kalibro::Client::Port
   def initialize(endpoint)
-    @client = Savon::Client.new("#{service_address}#{endpoint}Endpoint/?wsdl")
+    @endpoint = endpoint
+    initialize_client
   end
   def service_address
@@ -18,9 +19,20 @@ class Kalibro::Client::Port
     @service_address
   end
+  def service_address=(address)
+    @service_address = address
+    initialize_client
+  end
+
   def request(action, request_body = nil)
     response = @client.request(:kalibro, action) { soap.body = request_body }
     response.to_hash["#{action}_response".to_sym]
   end
+  private
+
+  def initialize_client
+    @client = Savon::Client.new("#{service_address}#{@endpoint}Endpoint/?wsdl")
+  end
+
 end
@@ -2,7 +2,7 @@ class Kalibro::Entities::Entity
   def self.from_hash(hash)
     entity = self.new
-    hash.each { |field, value| entity.set(field, value) }
+    hash.each { |field, value| entity.set(field, value) if field != :attributes!}
     entity
   end
@@ -24,16 +24,16 @@ class Kalibro::Entities::Entity
     fields.each do |field|
       field_value = self.get(field)
       hash[field] = convert_to_hash(field_value) if ! field_value.nil?
+      if need_xml_type?(field_value)
+        hash = {:attributes! => {}}.merge(hash)
+        hash[:attributes!][field.to_sym] = {
+          'xmlns:xsi'=> 'http://www.w3.org/2001/XMLSchema-instance',
+          'xsi:type' => 'kalibro:' + xml_class_name(field_value)  }
+      end
     end
     hash
   end
-  def convert_to_hash(value)
-    return value.collect { |element| convert_to_hash(element) } if value.kind_of?(Array)
-    return value.to_hash if value.kind_of?(Kalibro::Entities::Entity)
-    value
-  end
-
   def ==(other)
     begin
       fields.each.inject(true) { |equal, field| equal && (self.get(field) == other.get(field)) }
@@ -42,6 +42,8 @@ class Kalibro::Entities::Entity
     end
   end
+  protected
+
   def fields
     instance_variable_names.each.collect { |variable| variable.to_s.sub(/@/, '').to_sym }
   end
@@ -50,4 +52,23 @@ class Kalibro::Entities::Entity
     send("#{field}")
   end
+  def convert_to_hash(value)
+    return value.collect { |element| convert_to_hash(element) } if value.is_a?(Array)
+    return value.to_hash if value.is_a?(Kalibro::Entities::Entity)
+    return 'INF' if value.is_a?(Float) and value.infinite? == 1
+    return '-INF' if value.is_a?(Float) and value.infinite? == -1
+    value
+  end
+
+  def need_xml_type?(value)
+    value.is_a?(Kalibro::Entities::Entity) and value.class.superclass != Kalibro::Entities::Entity
+  end
+
+  def xml_class_name(entity)
+    xml_name = entity.class.name
+    xml_name["Kalibro::Entities::"] = ""
+    xml_name[0..0] = xml_name[0..0].downcase
+    xml_name + "Xml"
+  end
+  
 end
@@ -11,6 +11,10 @@ class Kalibro::Entities::MetricConfiguration &lt; Kalibro::Entities::Entity
     end
   end
+  def weight=(value)
+    @weight = value.to_f
+  end
+
   def range=(value)
     @range = to_entity_array(value, Kalibro::Entities::Range)
   end
@@ -2,4 +2,12 @@ class Kalibro::Entities::NativeMetric &lt; Kalibro::Entities::Metric
   attr_accessor :origin, :language
+  def languages
+    @language
+  end
+
+  def languages=(languages)
+    @language = languages
+  end
+
 end
@@ -2,4 +2,14 @@ class Kalibro::Entities::Range &lt; Kalibro::Entities::Entity
   attr_accessor :beginning, :end, :label, :grade, :color, :comments
+  def beginning=(value)
+    @beginning = value.to_f
+    @beginning = -1.0/0.0 if value == "-INF"
+  end
+
+  def end=(value)
+    @end = value.to_f
+    @end = 1.0/0.0 if value == "INF"
+  end
+
 end
 \ No newline at end of file
@@ -10,7 +10,10 @@ class CompoundMetricWithErrorFixtures
   end
   def self.create_hash
-    {:metric => CompoundMetricFixtures.sc_hash, :error => ErrorFixtures.create_hash}
+    {:metric => CompoundMetricFixtures.sc_hash, :error => ErrorFixtures.create_hash,
+      :attributes! => {:metric => {
+          'xmlns:xsi'=> 'http://www.w3.org/2001/XMLSchema-instance',
+          'xsi:type' => 'kalibro:compoundMetricXml'  }}}
   end
 end
@@ -25,12 +25,18 @@ class MetricConfigurationFixtures
   def self.amloc_configuration_hash
     {:metric => NativeMetricFixtures.amloc_hash, :code => 'amloc', :weight => 1.0,
-      :aggregation_form => 'AVERAGE', :range =>
-        [RangeFixtures.amloc_excellent_hash, RangeFixtures.amloc_bad_hash]}
+      :aggregation_form => 'AVERAGE',
+      :range => [RangeFixtures.amloc_excellent_hash, RangeFixtures.amloc_bad_hash],
+      :attributes! => {:metric => {
+          'xmlns:xsi'=> 'http://www.w3.org/2001/XMLSchema-instance',
+          'xsi:type' => 'kalibro:nativeMetricXml'  }}}
   end
   def self.sc_configuration_hash
-    {:metric => CompoundMetricFixtures.sc_hash, :code => 'sc', :weight => 1.0, :aggregation_form => 'AVERAGE'}
+    {:metric => CompoundMetricFixtures.sc_hash, :code => 'sc', :weight => 1.0, :aggregation_form => 'AVERAGE',
+      :attributes! => {:metric => {
+          'xmlns:xsi'=> 'http://www.w3.org/2001/XMLSchema-instance',
+          'xsi:type' => 'kalibro:compoundMetricXml'  }}}
   end
 end
@@ -23,11 +23,17 @@ class MetricResultFixtures
   def self.amloc_result_hash
     {:metric => NativeMetricFixtures.amloc_hash, :value => 0.0, :descendent_result => [40.0, 42.0],
-      :range => RangeFixtures.amloc_excellent_hash}
+      :range => RangeFixtures.amloc_excellent_hash,
+      :attributes! => {:metric => {
+          'xmlns:xsi'=> 'http://www.w3.org/2001/XMLSchema-instance',
+          'xsi:type' => 'kalibro:nativeMetricXml'  }}}
   end
   def self.sc_result_hash
-    {:metric => CompoundMetricFixtures.sc_hash, :value => 1.0, :descendent_result => [2.0, 42.0]}
+    {:metric => CompoundMetricFixtures.sc_hash, :value => 1.0, :descendent_result => [2.0, 42.0],
+      :attributes! => {:metric => {
+          'xmlns:xsi'=> 'http://www.w3.org/2001/XMLSchema-instance',
+          'xsi:type' => 'kalibro:compoundMetricXml'  }}}
   end
 end
@@ -5,12 +5,12 @@ class NativeMetricFixtures
     total_cof.name = 'Total Coupling Factor'
     total_cof.scope = 'APPLICATION'
     total_cof.origin = 'Analizo'
-    total_cof.language = 'JAVA'
+    total_cof.languages = ['JAVA']
     total_cof
   end
   def self.total_cof_hash
-    {:name => 'Total Coupling Factor', :scope => 'APPLICATION', :origin => 'Analizo', :language => 'JAVA'}
+    {:name => 'Total Coupling Factor', :scope => 'APPLICATION', :origin => 'Analizo', :language => ['JAVA']}
   end
   def self.amloc
@@ -18,12 +18,12 @@ class NativeMetricFixtures
     total_cof.name = 'Average Method LOC'
     total_cof.scope = 'CLASS'
     total_cof.origin = 'Analizo'
-    total_cof.language = 'JAVA'
+    total_cof.languages = ['JAVA']
     total_cof
   end
   def self.amloc_hash
-    {:name => 'Average Method LOC', :scope => 'CLASS', :origin => 'Analizo', :language => 'JAVA'}
+    {:name => 'Average Method LOC', :scope => 'CLASS', :origin => 'Analizo', :language => ['JAVA']}
   end
 end
 \ No newline at end of file
@@ -0,0 +1,29 @@
+require "test_helper"
+require File.dirname(__FILE__) + '/fake_port'
+
+class BaseToolClientTest < ActiveSupport::TestCase
+
+  def setup
+    fake_port = FakePort.new('BaseTool')
+    Kalibro::Client::Port.expects(:new).with('BaseTool').returns(fake_port)
+    @client = Kalibro::Client::BaseToolClient.new
+  end
+
+  should 'get base tool names' do
+    assert_equal ['Analizo', 'Checkstyle'], @client.base_tool_names
+  end
+
+  should 'get base tool by name' do
+    analizo = @client.base_tool('Analizo')
+    assert_equal 'Analizo', analizo.name
+    assert_equal 'Analizo description', analizo.description
+    assert_equal 1, analizo.supported_metrics.size
+    metric = analizo.supported_metrics[0]
+    assert_equal 'Analizo', metric.origin
+    assert_equal 'Analizo metric', metric.name
+    assert_equal 'Analizo metric description', metric.description
+    assert_equal 'METHOD', metric.scope
+    assert_equal ['CPP', 'JAVA'], metric.languages
+  end
+
+end
 \ No newline at end of file
@@ -0,0 +1,7 @@
+class FakePort < Kalibro::Client::Port
+
+  def initialize(endpoint)
+    super(endpoint)
+    self.service_address = 'http://localhost:8080/KalibroFake/'
+  end
+end
@@ -0,0 +1,43 @@
+require "test_helper"
+require File.dirname(__FILE__) + '/fake_port'
+
+require "#{RAILS_ROOT}/plugins/mezuro/test/fixtures/metric_configuration_fixtures"
+
+class MetricConfigurationClientTest < ActiveSupport::TestCase
+
+  def setup
+    fake_port = FakePort.new('MetricConfiguration')
+    Kalibro::Client::Port.expects(:new).with('MetricConfiguration').returns(fake_port)
+    @client = Kalibro::Client::MetricConfigurationClient.new
+  end
+
+  should 'save metric configuration' do
+    configuration = MetricConfigurationFixtures.amloc_configuration
+    @client.save(configuration, 'Configuration X')
+  end
+
+  should 'get metric configuration by name' do
+    configuration = @client.metric_configuration('C', 'native')
+    assert_equal 'metricOfC', configuration.code
+    assert_equal 1.0, configuration.weight
+    assert_equal 'AVERAGE', configuration.aggregation_form
+    assert_equal 1, configuration.ranges.size
+
+    range = configuration.ranges[0]
+    assert_equal -1.0/0.0, range.beginning
+    assert_equal 1.0/0.0, range.end
+
+    metric = configuration.metric
+    puts metric
+    assert metric.is_a?(Kalibro::Entities::NativeMetric)
+    assert_equal 'Metric of C', metric.name
+    assert_equal 'METHOD', metric.scope
+    assert_equal ['JAVA'], metric.languages
+    assert_equal 'Metric of C description', metric.description
+  end
+
+  should 'remove metric configuration by name' do
+    @client.remove('Configuration X', 'Metric X')
+  end
+
+end
 \ No newline at end of file
@@ -0,0 +1,44 @@
+require "test_helper"
+
+require "#{RAILS_ROOT}/plugins/mezuro/test/fixtures/metric_configuration_fixtures"
+
+class MetricConfigurationClientTest < ActiveSupport::TestCase
+
+  def setup
+    @port = mock
+    Kalibro::Client::Port.expects(:new).with('MetricConfiguration').returns(@port)
+    @client = Kalibro::Client::MetricConfigurationClient.new
+  end
+
+  should 'save metric configuration' do
+    configuration = MetricConfigurationFixtures.amloc_configuration
+    @port.expects(:request).with(:save_metric_configuration, {
+        :metric_configuration => configuration.to_hash,
+        :configuration_name => 'x'
+      })
+    @client.save(configuration, 'x')
+  end
+
+  should 'get metric configuration by name' do
+    configuration = MetricConfigurationFixtures.amloc_configuration
+    request_body = {
+      :configuration_name => 'configuration.name',
+      :metric_name => configuration.metric.name
+    }
+    response_hash = {:metric_configuration => configuration.to_hash}
+    @port.expects(:request).with(:get_metric_configuration, request_body).returns(response_hash)
+    assert_equal configuration, @client.metric_configuration('configuration.name', configuration.metric.name)
+  end
+
+  should 'remove metric configuration by name' do
+    metric_name = 'MetricConfigurationClientTest'
+    configuration_name = 'xxxx'
+    request_body = {
+      :configuration_name => configuration_name,
+      :metric_name => metric_name
+    }
+    @port.expects(:request).with(:remove_metric_configuration, request_body)
+    @client.remove(configuration_name, metric_name)
+  end
+
+end
 \ No newline at end of file
	@@ -0,0 +1,28 @@		@@ -0,0 +1,28 @@
		1	+class Kalibro::Client::MetricConfigurationClient
		2	+
		3	+ def initialize
		4	+ @port = Kalibro::Client::Port.new('MetricConfiguration')
		5	+ end
		6	+
		7	+ def save(metric_configuration, configuration_name)
		8	+ @port.request(:save_metric_configuration, {
		9	+ :metric_configuration => metric_configuration.to_hash,
		10	+ :configuration_name => configuration_name})
		11	+ end
		12	+
		13	+ def metric_configuration(configuration_name, metric_name)
		14	+ hash = @port.request(:get_metric_configuration, {
		15	+ :configuration_name => configuration_name,
		16	+ :metric_name => metric_name
		17	+ })[:metric_configuration]
		18	+ Kalibro::Entities::MetricConfiguration.from_hash(hash)
		19	+ end
		20	+
		21	+ def remove (configuration_name, metric_name)
		22	+ @port.request(:remove_metric_configuration, {
		23	+ :configuration_name => configuration_name,
		24	+ :metric_name=> metric_name
		25	+ })
		26	+ end
		27	+
		28	+end
0	\ No newline at end of file	29	\ No newline at end of file
	@@ -7,7 +7,8 @@ end		@@ -7,7 +7,8 @@ end
7	class Kalibro::Client::Port	7	class Kalibro::Client::Port
8		8
9	def initialize(endpoint)	9	def initialize(endpoint)
10	- @client = Savon::Client.new("#{service_address}#{endpoint}Endpoint/?wsdl")	10	+ @endpoint = endpoint
		11	+ initialize_client
11	end	12	end
12		13
13	def service_address	14	def service_address
	@@ -18,9 +19,20 @@ class Kalibro::Client::Port		@@ -18,9 +19,20 @@ class Kalibro::Client::Port
18	@service_address	19	@service_address
19	end	20	end
20		21
		22	+ def service_address=(address)
		23	+ @service_address = address
		24	+ initialize_client
		25	+ end
		26	+
21	def request(action, request_body = nil)	27	def request(action, request_body = nil)
22	response = @client.request(:kalibro, action) { soap.body = request_body }	28	response = @client.request(:kalibro, action) { soap.body = request_body }
23	response.to_hash["#{action}_response".to_sym]	29	response.to_hash["#{action}_response".to_sym]
24	end	30	end
25		31
		32	+ private
		33	+
		34	+ def initialize_client
		35	+ @client = Savon::Client.new("#{service_address}#{@endpoint}Endpoint/?wsdl")
		36	+ end
		37	+
26	end	38	end
	@@ -2,4 +2,12 @@ class Kalibro::Entities::NativeMetric < Kalibro::Entities::Metric		@@ -2,4 +2,12 @@ class Kalibro::Entities::NativeMetric < Kalibro::Entities::Metric
2		2
3	attr_accessor :origin, :language	3	attr_accessor :origin, :language
4		4
		5	+ def languages
		6	+ @language
		7	+ end
		8	+
		9	+ def languages=(languages)
		10	+ @language = languages
		11	+ end
		12	+
5	end	13	end
	@@ -2,4 +2,14 @@ class Kalibro::Entities::Range < Kalibro::Entities::Entity		@@ -2,4 +2,14 @@ class Kalibro::Entities::Range < Kalibro::Entities::Entity
2		2
3	attr_accessor :beginning, :end, :label, :grade, :color, :comments	3	attr_accessor :beginning, :end, :label, :grade, :color, :comments
4		4
		5	+ def beginning=(value)
		6	+ @beginning = value.to_f
		7	+ @beginning = -1.0/0.0 if value == "-INF"
		8	+ end
		9	+
		10	+ def end=(value)
		11	+ @end = value.to_f
		12	+ @end = 1.0/0.0 if value == "INF"
		13	+ end
		14	+
5	end	15	end
6	\ No newline at end of file	16	\ No newline at end of file
	@@ -5,12 +5,12 @@ class NativeMetricFixtures		@@ -5,12 +5,12 @@ class NativeMetricFixtures
5	total_cof.name = 'Total Coupling Factor'	5	total_cof.name = 'Total Coupling Factor'
6	total_cof.scope = 'APPLICATION'	6	total_cof.scope = 'APPLICATION'
7	total_cof.origin = 'Analizo'	7	total_cof.origin = 'Analizo'
8	- total_cof.language = 'JAVA'	8	+ total_cof.languages = ['JAVA']
9	total_cof	9	total_cof
10	end	10	end
11		11
12	def self.total_cof_hash	12	def self.total_cof_hash
13	- {:name => 'Total Coupling Factor', :scope => 'APPLICATION', :origin => 'Analizo', :language => 'JAVA'}	13	+ {:name => 'Total Coupling Factor', :scope => 'APPLICATION', :origin => 'Analizo', :language => ['JAVA']}
14	end	14	end
15		15
16	def self.amloc	16	def self.amloc
	@@ -18,12 +18,12 @@ class NativeMetricFixtures		@@ -18,12 +18,12 @@ class NativeMetricFixtures
18	total_cof.name = 'Average Method LOC'	18	total_cof.name = 'Average Method LOC'
19	total_cof.scope = 'CLASS'	19	total_cof.scope = 'CLASS'
20	total_cof.origin = 'Analizo'	20	total_cof.origin = 'Analizo'
21	- total_cof.language = 'JAVA'	21	+ total_cof.languages = ['JAVA']
22	total_cof	22	total_cof
23	end	23	end
24		24
25	def self.amloc_hash	25	def self.amloc_hash
26	- {:name => 'Average Method LOC', :scope => 'CLASS', :origin => 'Analizo', :language => 'JAVA'}	26	+ {:name => 'Average Method LOC', :scope => 'CLASS', :origin => 'Analizo', :language => ['JAVA']}
27	end	27	end
28		28
29	end	29	end
30	\ No newline at end of file	30	\ No newline at end of file
	@@ -0,0 +1,29 @@		@@ -0,0 +1,29 @@
		1	+require "test_helper"
		2	+require File.dirname(__FILE__) + '/fake_port'
		3	+
		4	+class BaseToolClientTest < ActiveSupport::TestCase
		5	+
		6	+ def setup
		7	+ fake_port = FakePort.new('BaseTool')
		8	+ Kalibro::Client::Port.expects(:new).with('BaseTool').returns(fake_port)
		9	+ @client = Kalibro::Client::BaseToolClient.new
		10	+ end
		11	+
		12	+ should 'get base tool names' do
		13	+ assert_equal ['Analizo', 'Checkstyle'], @client.base_tool_names
		14	+ end
		15	+
		16	+ should 'get base tool by name' do
		17	+ analizo = @client.base_tool('Analizo')
		18	+ assert_equal 'Analizo', analizo.name
		19	+ assert_equal 'Analizo description', analizo.description
		20	+ assert_equal 1, analizo.supported_metrics.size
		21	+ metric = analizo.supported_metrics[0]
		22	+ assert_equal 'Analizo', metric.origin
		23	+ assert_equal 'Analizo metric', metric.name
		24	+ assert_equal 'Analizo metric description', metric.description
		25	+ assert_equal 'METHOD', metric.scope
		26	+ assert_equal ['CPP', 'JAVA'], metric.languages
		27	+ end
		28	+
		29	+end
0	\ No newline at end of file	30	\ No newline at end of file
@@ -0,0 +1,7 @@		@@ -0,0 +1,7 @@
	1	+class FakePort < Kalibro::Client::Port
	2	+
	3	+ def initialize(endpoint)
	4	+ super(endpoint)
	5	+ self.service_address = 'http://localhost:8080/KalibroFake/'
	6	+ end
	7	+end
	@@ -0,0 +1,43 @@		@@ -0,0 +1,43 @@
		1	+require "test_helper"
		2	+require File.dirname(__FILE__) + '/fake_port'
		3	+
		4	+require "#{RAILS_ROOT}/plugins/mezuro/test/fixtures/metric_configuration_fixtures"
		5	+
		6	+class MetricConfigurationClientTest < ActiveSupport::TestCase
		7	+
		8	+ def setup
		9	+ fake_port = FakePort.new('MetricConfiguration')
		10	+ Kalibro::Client::Port.expects(:new).with('MetricConfiguration').returns(fake_port)
		11	+ @client = Kalibro::Client::MetricConfigurationClient.new
		12	+ end
		13	+
		14	+ should 'save metric configuration' do
		15	+ configuration = MetricConfigurationFixtures.amloc_configuration
		16	+ @client.save(configuration, 'Configuration X')
		17	+ end
		18	+
		19	+ should 'get metric configuration by name' do
		20	+ configuration = @client.metric_configuration('C', 'native')
		21	+ assert_equal 'metricOfC', configuration.code
		22	+ assert_equal 1.0, configuration.weight
		23	+ assert_equal 'AVERAGE', configuration.aggregation_form
		24	+ assert_equal 1, configuration.ranges.size
		25	+
		26	+ range = configuration.ranges[0]
		27	+ assert_equal -1.0/0.0, range.beginning
		28	+ assert_equal 1.0/0.0, range.end
		29	+
		30	+ metric = configuration.metric
		31	+ puts metric
		32	+ assert metric.is_a?(Kalibro::Entities::NativeMetric)
		33	+ assert_equal 'Metric of C', metric.name
		34	+ assert_equal 'METHOD', metric.scope
		35	+ assert_equal ['JAVA'], metric.languages
		36	+ assert_equal 'Metric of C description', metric.description
		37	+ end
		38	+
		39	+ should 'remove metric configuration by name' do
		40	+ @client.remove('Configuration X', 'Metric X')
		41	+ end
		42	+
		43	+end
0	\ No newline at end of file	44	\ No newline at end of file
	@@ -0,0 +1,44 @@		@@ -0,0 +1,44 @@
		1	+require "test_helper"
		2	+
		3	+require "#{RAILS_ROOT}/plugins/mezuro/test/fixtures/metric_configuration_fixtures"
		4	+
		5	+class MetricConfigurationClientTest < ActiveSupport::TestCase
		6	+
		7	+ def setup
		8	+ @port = mock
		9	+ Kalibro::Client::Port.expects(:new).with('MetricConfiguration').returns(@port)
		10	+ @client = Kalibro::Client::MetricConfigurationClient.new
		11	+ end
		12	+
		13	+ should 'save metric configuration' do
		14	+ configuration = MetricConfigurationFixtures.amloc_configuration
		15	+ @port.expects(:request).with(:save_metric_configuration, {
		16	+ :metric_configuration => configuration.to_hash,
		17	+ :configuration_name => 'x'
		18	+ })
		19	+ @client.save(configuration, 'x')
		20	+ end
		21	+
		22	+ should 'get metric configuration by name' do
		23	+ configuration = MetricConfigurationFixtures.amloc_configuration
		24	+ request_body = {
		25	+ :configuration_name => 'configuration.name',
		26	+ :metric_name => configuration.metric.name
		27	+ }
		28	+ response_hash = {:metric_configuration => configuration.to_hash}
		29	+ @port.expects(:request).with(:get_metric_configuration, request_body).returns(response_hash)
		30	+ assert_equal configuration, @client.metric_configuration('configuration.name', configuration.metric.name)
		31	+ end
		32	+
		33	+ should 'remove metric configuration by name' do
		34	+ metric_name = 'MetricConfigurationClientTest'
		35	+ configuration_name = 'xxxx'
		36	+ request_body = {
		37	+ :configuration_name => configuration_name,
		38	+ :metric_name => metric_name
		39	+ }
		40	+ @port.expects(:request).with(:remove_metric_configuration, request_body)
		41	+ @client.remove(configuration_name, metric_name)
		42	+ end
		43	+
		44	+end
0	\ No newline at end of file	45	\ No newline at end of file