Download as
Browse Code »

Commit 81478cba44472bcffd459ba21e866fdd4a1b315d

Authored by Braulio Bhavamitra
1 parent 81b33ca3
Exists in master and in 29 other branches add_member_task_reject_details, admin_visible_profile, article-list-template, community_notifications, contact_admin_translation, event_fixes, fix_comments_pagination, fix_rails4_organization_ratings, fix_sign_up_form, follow_step_fix, forum_topic_creation, mirror_block_improvements, multi_env_on_remote_user, new_security, noosfero_spb_ci, organization_ratings_improvements, organization_ratings_link_to_profile_stable-spb-1.3, organization_ratings_translations_fix, profile_api_improvements, ratings_minor_fixes, remote_user_fix, send_email_to_admins, stable-spb-1.3, stable-spb-1.3-fixes, stable-spb-1.4, stable-spb-1.5, suggest_rejected_value, web_steps_improvements, xss_terminate_custom_options

Revert "plugins: don't crash on method_missing methods" 

This reverts commit 51d3ac08b10f2f063a6915b83e95329dd14613dd.
Showing 2 changed files with 0 additions and 11 deletions   Show diff stats
lib/noosfero/plugin/manager.rb
  Diff comments   View file @81478cb
@@ -38,8 +38,6 @@ class Noosfero::Plugin::Manager @@ -38,8 +38,6 @@ class Noosfero::Plugin::Manager
38 end 38 end
39 39
40 def result_for plugin, event, *args 40 def result_for plugin, event, *args
41 - # check if defined to avoid crash, as there is hotspots using method_missing  
42 - return unless plugin.respond_to? event  
43 method = plugin.method event 41 method = plugin.method event
44 method.call *args if method.owner != Noosfero::Plugin 42 method.call *args if method.owner != Noosfero::Plugin
45 end 43 end
test/unit/plugin_manager_test.rb
  Diff comments   View file @81478cb
@@ -178,15 +178,6 @@ class PluginManagerTest < ActiveSupport::TestCase @@ -178,15 +178,6 @@ class PluginManagerTest < ActiveSupport::TestCase
178 assert_equal Plugin2, manager.fetch_first_plugin(:random_event) 178 assert_equal Plugin2, manager.fetch_first_plugin(:random_event)
179 end 179 end
180 180
181 - should 'return nil if missing method is called' do  
182 - class Plugin1 < Noosfero::Plugin  
183 - end  
184 - Noosfero::Plugin.stubs(:all).returns(['PluginManagerTest::Plugin1'])  
185 - environment.enable_plugin(Plugin1)  
186 -  
187 - assert_equal nil, @manager.result_for(Plugin1.new, :content_remove_new)  
188 - end  
189 -  
190 should 'parse macro' do 181 should 'parse macro' do
191 class Plugin1 < Noosfero::Plugin 182 class Plugin1 < Noosfero::Plugin
192 def macros 183 def macros