Add checkbox to open highlights block in a new window

Closes !511

Add checkbox to open highlights block in a new window
Closes !511
Eduardo Passos · Rodrigo Souto
1 parent 320f1f19
Showing 5 changed files with 19 additions and 4 deletions Show diff stats
app/helpers/block_helper.rb
app/models/highlights_block.rb
app/views/blocks/highlights.html.erb
app/views/box_organizer/_highlights_block.html.erb
test/unit/highlights_block_test.rb
@@ -14,6 +14,7 @@ module BlockHelper
       </td>
       <td>#{text_field_tag 'block[images][][address]', image[:address], :class => 'highlight-address', :size => 20}</td>
       <td>#{text_field_tag 'block[images][][position]', image[:position], :class => 'highlight-position', :size => 1}</td>
+      <td>#{check_box_tag 'block[images][][new_window]', '1', image[:new_window], :class => 'highlight-new_window', :size => 1}</td>
     </tr><tr class=\"image-title\" data-row-number='#{row_number}'>
       <td colspan=\"3\"><label>#{
         content_tag('span', _('Title')) +
@@ -15,6 +15,8 @@ class HighlightsBlock &lt; Block
       if !Noosfero.root.nil? and !i[:address].start_with?(Noosfero.root + '/')
         i[:address] = Noosfero.root + i[:address]
       end
+      i[:new_window] = i[:new_window] == '1' ? true : false
+
       begin
         file = UploadedFile.find(i[:image_id])
         i[:image_src] = file.public_filename
@@ -3,7 +3,7 @@
   <div class='highlights-border'>
     <div class='highlights-container'>
       <% block.featured_images.each do |img| %>
-        <a href="<%= img[:address] %>" title="<%= img[:title] %>" class="highlights-image-link">
+        <a href="<%= img[:address] %>" <%= 'target="_blank"' if img[:new_window] %> title="<%= img[:title] %>" class="highlights-image-link">
           <%= image_tag [Noosfero.root, img[:image_src]].join, alt: img[:title] %>
           <p class="highlights-label"><%= img[:title] %></p>
         </a>
@@ -3,7 +3,7 @@
 <strong><%= _('Highlights') %></strong>
 <table class="noborder"><tbody id="highlights-data-table">
-  <tr><th><%= _('Image') %></th><th><%= _('Address') %></th><th><%= _('Position') %></th></tr>
+  <tr><th><%= _('Image') %></th><th><%= _('Address') %></th><th><%= _('Position') %></th><th><%= _('New Window') %></th></tr>
   <% @block.images.each_with_index do |image, index| %>
     <%= highlights_block_config_image_fields @block, image, index %>
   <% end %>
@@ -54,7 +54,19 @@ class HighlightsBlockTest &lt; ActiveSupport::TestCase
   should 'remove images with blank fields' do
     h = HighlightsBlock.new(:images => [{:image_id => 1, :address => '/address', :position => 1, :title => 'address'}, {:image_id => '', :address => '', :position => '', :title => ''}])
     h.save!
-    assert_equal [{:image_id => 1, :address => '/address', :position => 1, :title => 'address', :image_src => nil}], h.images
+    assert_equal [{:image_id => 1, :address => '/address', :position => 1, :title => 'address', :new_window => false, :image_src => nil}], h.images
+  end
+
+  should 'replace 1 and 0 by true and false in new_window attribute' do
+    image1 = {:image_id => 1, :address => '/address-1', :position => 1, :title => 'address-1', :new_window => '0'}
+    image2 = {:image_id => 2, :address => '/address-2', :position => 2, :title => 'address-2', :new_window => '1'}
+    h = HighlightsBlock.new(:images => [image1, image2])
+    h.save!
+    image1[:new_window] = false
+    image1[:image_src] = nil
+    image2[:new_window] = true
+    image2[:image_src] = nil
+    assert_equivalent [image1, image2], h.images
   end
   should 'be able to update display setting' do
@@ -84,7 +96,7 @@ class HighlightsBlockTest &lt; ActiveSupport::TestCase
     block.save!
     block.reload
     assert_equal 2, block.images.count
-    assert_equal [{:image_id => 1, :address => '/address', :position => 1, :title => 'address', :image_src => 'address'}], block.featured_images
+    assert_equal [{:image_id => 1, :address => '/address', :position => 1, :title => 'address', :new_window => false, :image_src => 'address'}], block.featured_images
   end
   should 'list images in order' do
	@@ -3,7 +3,7 @@		@@ -3,7 +3,7 @@
3	<div class='highlights-border'>	3	<div class='highlights-border'>
4	<div class='highlights-container'>	4	<div class='highlights-container'>
5	<% block.featured_images.each do \|img\| %>	5	<% block.featured_images.each do \|img\| %>
6	- <a href="<%= img[:address] %>" title="<%= img[:title] %>" class="highlights-image-link">	6	+ <a href="<%= img[:address] %>" <%= 'target="_blank"' if img[:new_window] %> title="<%= img[:title] %>" class="highlights-image-link">
7	<%= image_tag [Noosfero.root, img[:image_src]].join, alt: img[:title] %>	7	<%= image_tag [Noosfero.root, img[:image_src]].join, alt: img[:title] %>
8	<p class="highlights-label"><%= img[:title] %></p>	8	<p class="highlights-label"><%= img[:title] %></p>
9	</a>	9	</a>
	@@ -3,7 +3,7 @@		@@ -3,7 +3,7 @@
3	<strong><%= _('Highlights') %></strong>	3	<strong><%= _('Highlights') %></strong>
4		4
5	<table class="noborder"><tbody id="highlights-data-table">	5	<table class="noborder"><tbody id="highlights-data-table">
6	- <tr><th><%= _('Image') %></th><th><%= _('Address') %></th><th><%= _('Position') %></th></tr>	6	+ <tr><th><%= _('Image') %></th><th><%= _('Address') %></th><th><%= _('Position') %></th><th><%= _('New Window') %></th></tr>
7	<% @block.images.each_with_index do \|image, index\| %>	7	<% @block.images.each_with_index do \|image, index\| %>
8	<%= highlights_block_config_image_fields @block, image, index %>	8	<%= highlights_block_config_image_fields @block, image, index %>
9	<% end %>	9	<% end %>