Download as
Browse Code »

Commit 8665815d314724ee92934c6a5c121ad73f3e3b4a

Authored by Antonio Terceiro
1 parent 873bdbb5
Exists in master and in 29 other branches add_member_task_reject_details, admin_visible_profile, article-list-template, community_notifications, contact_admin_translation, event_fixes, fix_comments_pagination, fix_rails4_organization_ratings, fix_sign_up_form, follow_step_fix, forum_topic_creation, mirror_block_improvements, multi_env_on_remote_user, new_security, noosfero_spb_ci, organization_ratings_improvements, organization_ratings_link_to_profile_stable-spb-1.3, organization_ratings_translations_fix, profile_api_improvements, ratings_minor_fixes, remote_user_fix, send_email_to_admins, stable-spb-1.3, stable-spb-1.3-fixes, stable-spb-1.4, stable-spb-1.5, suggest_rejected_value, web_steps_improvements, xss_terminate_custom_options

Move improper cache expiring to a sweeper

Showing 3 changed files with 11 additions and 3 deletions   Show diff stats
app/controllers/box_organizer_controller.rb
  Diff comments   View file @8665815
@@ -82,7 +82,6 @@ class BoxOrganizerController < ApplicationController @@ -82,7 +82,6 @@ class BoxOrganizerController < ApplicationController
82 def save 82 def save
83 @block = boxes_holder.blocks.find(params[:id]) 83 @block = boxes_holder.blocks.find(params[:id])
84 @block.update_attributes(params[:block]) 84 @block.update_attributes(params[:block])
85 - expire_timeout_fragment(@block.cache_key)  
86 redirect_to :action => 'index' 85 redirect_to :action => 'index'
87 end 86 end
88 87
@@ -93,7 +92,6 @@ class BoxOrganizerController < ApplicationController @@ -93,7 +92,6 @@ class BoxOrganizerController < ApplicationController
93 def remove 92 def remove
94 @block = Block.find(params[:id]) 93 @block = Block.find(params[:id])
95 if @block.destroy 94 if @block.destroy
96 - expire_timeout_fragment(@block.cache_key)  
97 redirect_to :action => 'index' 95 redirect_to :action => 'index'
98 else 96 else
99 session[:notice] = _('Failed to remove block') 97 session[:notice] = _('Failed to remove block')
app/sweepers/block_sweeper.rb 0 → 100644
  Diff comments   View file @8665815
@@ -0,0 +1,10 @@ @@ -0,0 +1,10 @@
  1 +class BlockSweeper < ActiveRecord::Observer
  2 +
  3 + include SweeperHelper
  4 + observe :block
  5 +
  6 + def after_save(block)
  7 + expire_fragment(block.cache_key)
  8 + end
  9 +
  10 +end
config/environment.rb
  Diff comments   View file @8665815
@@ -64,7 +64,7 @@ Rails::Initializer.run do |config| @@ -64,7 +64,7 @@ Rails::Initializer.run do |config|
64 makemo 64 makemo
65 ] 65 ]
66 unless $PROGRAM_NAME =~ /rake$/ && (ignore_rake_commands.include?(ARGV.first)) 66 unless $PROGRAM_NAME =~ /rake$/ && (ignore_rake_commands.include?(ARGV.first))
67 - config.active_record.observers = :article_sweeper, :role_assignment_sweeper, :friendship_sweeper, :category_sweeper 67 + config.active_record.observers = :article_sweeper, :role_assignment_sweeper, :friendship_sweeper, :category_sweeper, :block_sweeper
68 end 68 end
69 # Make Active Record use UTC-base instead of local time 69 # Make Active Record use UTC-base instead of local time
70 # config.active_record.default_timezone = :utc 70 # config.active_record.default_timezone = :utc