Download as
Browse Code »

Commit 88adb34ee3f2c3b3a5d34b5d34fdcfca10c900fd

Authored by Joenio Costa
Committed by Daniela Feitosa
1 parent f15a7f20
Exists in master and in 29 other branches add_member_task_reject_details, admin_visible_profile, article-list-template, community_notifications, contact_admin_translation, event_fixes, fix_comments_pagination, fix_rails4_organization_ratings, fix_sign_up_form, follow_step_fix, forum_topic_creation, mirror_block_improvements, multi_env_on_remote_user, new_security, noosfero_spb_ci, organization_ratings_improvements, organization_ratings_link_to_profile_stable-spb-1.3, organization_ratings_translations_fix, profile_api_improvements, ratings_minor_fixes, remote_user_fix, send_email_to_admins, stable-spb-1.3, stable-spb-1.3-fixes, stable-spb-1.4, stable-spb-1.5, suggest_rejected_value, web_steps_improvements, xss_terminate_custom_options

Check if mime_type isn't nil before try to use it 

(ActionItem1891)
Showing 2 changed files with 7 additions and 1 deletions   Show diff stats
app/models/uploaded_file.rb
  Diff comments   View file @88adb34
... ... @@ -54,7 +54,7 @@ class UploadedFile < Article
54 54  
55 55 def self.icon_name(article = nil)
56 56 if article
57   - article.image? ? article.public_filename(:icon) : article.mime_type.gsub(/[\/+.]/, '-')
  57 + article.image? ? article.public_filename(:icon) : (article.mime_type ? article.mime_type.gsub(/[\/+.]/, '-') : 'upload-file')
58 58 else
59 59 'upload-file'
60 60 end
... ...
test/unit/uploaded_file_test.rb
  Diff comments   View file @88adb34
... ... @@ -287,4 +287,10 @@ class UploadedFileTest < Test::Unit::TestCase
287 287 assert_equal '', f.lead
288 288 end
289 289  
  290 + should 'survive when try to get icon_name from a file with mime_type nil' do
  291 + f = UploadedFile.new
  292 + f.expects(:mime_type).returns(nil)
  293 + assert_equal 'upload-file', UploadedFile.icon_name(f)
  294 + end
  295 +
290 296 end
... ...