Download as
Browse Code »

Commit 88e96a208a5f0f813dc8467552a8709b6d1258ce

Authored by JoenioCosta
1 parent 807a3009
Exists in master and in 29 other branches add_member_task_reject_details, admin_visible_profile, article-list-template, community_notifications, contact_admin_translation, event_fixes, fix_comments_pagination, fix_rails4_organization_ratings, fix_sign_up_form, follow_step_fix, forum_topic_creation, mirror_block_improvements, multi_env_on_remote_user, new_security, noosfero_spb_ci, organization_ratings_improvements, organization_ratings_link_to_profile_stable-spb-1.3, organization_ratings_translations_fix, profile_api_improvements, ratings_minor_fixes, remote_user_fix, send_email_to_admins, stable-spb-1.3, stable-spb-1.3-fixes, stable-spb-1.4, stable-spb-1.5, suggest_rejected_value, web_steps_improvements, xss_terminate_custom_options

ActionItem192: sanitizing article tags 

git-svn-id: https://svn.colivre.coop.br/svn/noosfero/trunk@1732 3f533792-8f58-4932-b0fe-aaf55b0a4547
Showing 2 changed files with 15 additions and 0 deletions   Show diff stats
app/models/article.rb
  Diff comments   View file @88e96a2
1 class Article < ActiveRecord::Base 1 class Article < ActiveRecord::Base
2 2
  3 + # xss_terminate plugin can't sanitize array fields
  4 + before_save :sanitize_tag_list
  5 +
3 belongs_to :profile 6 belongs_to :profile
4 validates_presence_of :profile_id, :name, :slug, :path 7 validates_presence_of :profile_id, :name, :slug, :path
5 8
@@ -109,4 +112,11 @@ class Article &lt; ActiveRecord::Base @@ -109,4 +112,11 @@ class Article &lt; ActiveRecord::Base
109 true 112 true
110 end 113 end
111 114
  115 + private
  116 +
  117 + def sanitize_tag_list
  118 + sanitizer = HTML::FullSanitizer.new
  119 + self.tag_list.names.map!{|i| sanitizer.sanitize(i) }
  120 + end
  121 +
112 end 122 end
test/functional/cms_controller_test.rb
  Diff comments   View file @88e96a2
@@ -303,4 +303,9 @@ class CmsControllerTest &lt; Test::Unit::TestCase @@ -303,4 +303,9 @@ class CmsControllerTest &lt; Test::Unit::TestCase
303 assert_equal "<b>the</b> <strong>of</strong> article ...", assigns(:article).body 303 assert_equal "<b>the</b> <strong>of</strong> article ...", assigns(:article).body
304 end 304 end
305 305
  306 + should 'sanitize tags' do
  307 + post :new, :type => 'TextileArticle', :profile => profile.identifier, :article => { :name => 'a test article', :body => 'the text of the article ...', :tag_list => 'tag1, <strong>tag2</strong>' }
  308 + assert_sanitized assigns(:article).tag_list.names.join(', ')
  309 + end
  310 +
306 end 311 end