metadata: Support key attr specification (fix tests)

Braulio Bhavamitra
1 parent ee532d16
Showing 15 changed files with 233 additions and 163 deletions Show diff stats
app/helpers/layout_helper.rb
app/views/layouts/application-ng.html.erb
plugins/metadata/lib/ext/article.rb
plugins/metadata/lib/ext/community.rb
plugins/metadata/lib/ext/enterprise.rb
plugins/metadata/lib/ext/environment.rb
plugins/metadata/lib/ext/person.rb
plugins/metadata/lib/ext/product.rb
plugins/metadata/lib/ext/profile.rb
plugins/metadata/lib/ext/uploaded_file.rb
plugins/metadata/lib/metadata_plugin.rb
plugins/metadata/lib/metadata_plugin/spec.rb
plugins/metadata/lib/metadata_plugin/specs.rb
plugins/metadata/test/functional/content_viewer_controller_test.rb
test/functional/content_viewer_controller_test.rb
@@ -116,8 +116,5 @@ module LayoutHelper
     end
   end
-  def meta_description_tag(article=nil)
-    article ? CGI.escapeHTML(truncate(strip_tags(article.body.to_s), :length => 200)) : environment.name
-  end
 end
@@ -7,11 +7,6 @@
     <meta http-equiv="Content-Type" content="text/html; charset=utf-8"/>
     <meta name="description" content="<%= @environment.name %>" />
-    <!-- Twitter Card -->
-    <meta name="twitter:card" value="summary">
-    <meta name="twitter:title" content="<%= h page_title %>">
-    <meta name="twitter:description" content="<%= meta_description_tag(@page) %>">
-
     <!-- site root -->
     <meta property="noosfero:root" content="<%= Noosfero.root %>"/>
@@ -2,31 +2,42 @@ require_dependency &#39;article&#39;
 class Article
-  Metadata = {
-    'og:type' => MetadataPlugin.og_types[:article],
-    'og:url' => proc{ |a, c| c.og_url_for a.url },
-    'og:title' => proc{ |a, c| a.title },
-    'og:image' => proc do |a, c|
-        result = a.body_images_paths
-        result = "#{a.profile.environment.top_url}#{a.profile.image.public_filename}" if a.profile.image if result.blank?
-        result = MetadataPlugin.config[:open_graph][:environment_logo] if result.blank?
-        result
-      end,
-    'og:see_also' => [],
-    'og:site_name' => proc{ |a, c| a.profile.name },
-    'og:updated_time' => proc{ |a, c| a.updated_at.iso8601 },
-    'og:locale:locale' => proc{ |a, c| a.environment.default_language },
-    'og:locale:alternate' => proc{ |a, c| a.environment.languages - [a.environment.default_language] },
-    'twitter:image' => proc{ |a, c| a.body_images_paths },
-		'article:expiration_time' => "", # In the future we might want to populate this
-		'article:modified_time' => proc{ |a, c| a.updated_at.iso8601 },
-		'article:published_time' => proc{ |a, c| a.published_at.iso8601 },
-		'article:section' => "", # In the future we might want to populate this
-		'article:tag' => proc{ |a, c| a.tags.map &:name },
-		'og:description' => proc{ |a, c| ActionView::Base.full_sanitizer.sanitize a.body },
-		'og:rich_attachment' => "",
+  metadata_spec namespace: :og, key_attr: :property, tags: {
+    type: MetadataPlugin.og_types[:article] || :article,
+    url: proc{ |a, plugin| plugin.og_url_for a.url },
+    title: proc{ |a, plugin| "#{a.title} - #{a.profile.name}" },
+    image: proc do |a, plugin|
+      result = a.body_images_paths
+      result = "#{a.profile.environment.top_url}#{a.profile.image.public_filename}" if a.profile.image if result.blank?
+      result ||= MetadataPlugin.config[:open_graph][:environment_logo] rescue nil if result.blank?
+      result
+    end,
+    see_also: [],
+    site_name: proc{ |a, c| a.profile.name },
+    updated_time: proc{ |a, c| a.updated_at.iso8601 },
+    'locale:locale' => proc{ |a, c| a.environment.default_language },
+    'locale:alternate' => proc{ |a, c| a.environment.languages - [a.environment.default_language] },
+
+    description: proc{ |a, plugin| ActionView::Base.full_sanitizer.sanitize a.body },
+    rich_attachment: "",
   }
+  metadata_spec namespace: :twitter, key_attr: :name, tags: {
+    card: 'summary',
+    description: proc do |a, plugin|
+      description = a.body.to_s || a.environment.name
+      CGI.escapeHTML(plugin.helpers.truncate(plugin.helpers.strip_tags(description), length: 200))
+    end,
+    title: proc{ |a, plugin| "#{a.title} - #{a.profile.name}" },
+    image: proc{ |a, plugin| a.body_images_paths },
+  }
+  metadata_spec namespace: :article, key_attr: :property, tags: {
+    expiration_time: "", # In the future we might want to populate this
+    modified_time: proc{ |a, plugin| a.updated_at.iso8601 },
+    published_time: proc{ |a, plugin| a.published_at.iso8601 },
+    section: "", # In the future we might want to populate this
+    tag: proc{ |a, plugin| a.tags.map &:name },
+  }
 end
@@ -3,8 +3,8 @@ require_dependency &quot;#{File.dirname __FILE__}/profile&quot;
 class Community
-  Metadata = Metadata.merge({
-    'og:type' => MetadataPlugin.og_types[:community],
-  })
+  metadata_spec namespace: :og, tags: {
+    type: MetadataPlugin.og_types[:community] || :community,
+  }
 end
@@ -3,16 +3,18 @@ require_dependency &quot;#{File.dirname __FILE__}/profile&quot;
 class Enterprise
-  Metadata = Metadata.merge({
-    'og:type' => MetadataPlugin.og_types[:enterprise],
-	  'business:contact_data:email' => proc{ |e, c| e.contact_email },
-	  'business:contact_data:phone_number' => proc{ |e, c| e.contact_phone },
-	  'business:contact_data:street_address' => proc{ |e, c| e.address },
-	  'business:contact_data:locality' => proc{ |e, c| e.city },
-	  'business:contact_data:region' => proc{ |e, c| e.state },
-	  'business:contact_data:postal_code' => proc{ |e, c| e.zip_code },
-	  'business:contact_data:country_name' => proc{ |e| e.country },
-	  'place:location:latitude' => proc{ |e, c| p.lat },
-	  'place:location:longitude' => proc{ |e, c| p.lng },
-  })
+  metadata_spec namespace: :og, tags: {
+    type: MetadataPlugin.og_types[:enterprise] || :enterprise,
+  }
+
+  metadata_spec namespace: 'business:contact_data', tags: {
+    email: proc{ |e, plugin| e.contact_email },
+	  phone_number: proc{ |e, plugin| e.contact_phone },
+	  street_address: proc{ |e, plugin| e.address },
+	  locality: proc{ |e, plugin| e.city },
+	  region: proc{ |e, plugin| e.state },
+	  postal_code: proc{ |e, plugin| e.zip_code },
+	  country_name: proc{ |e, plugin| e.country },
+  }
+
 end
@@ -2,12 +2,12 @@ require_dependency &#39;environment&#39;
 class Environment
-  Metadata = {
-    'og:site_name' => proc{ |e, c| e.name },
-    'og:description' => proc{ |e, c| e.name },
-    'og:url' => proc{ |e, c| e.top_url },
-    'og:locale:locale' => proc{ |e, c| e.default_language },
-    'og:locale:alternate' => proc{ |e, c| e.languages - [e.default_language] }
+  metadata_spec namespace: :og, tags: {
+    site_name: proc{ |e, plugin| e.name },
+    description: proc{ |e, plugin| e.name },
+    url: proc{ |e, plugin| e.top_url },
+    'locale:locale' => proc{ |e, plugin| e.default_language },
+    'locale:alternate' => proc{ |e, plugin| e.languages - [e.default_language] },
   }
 end
@@ -3,8 +3,8 @@ require_dependency &quot;#{File.dirname __FILE__}/profile&quot;
 class Person
-  Metadata = Metadata.merge({
-    'og:type' => MetadataPlugin.og_types[:person],
-  })
+  metadata_spec namespace: :og, tags: {
+    type: MetadataPlugin.og_types[:person] || :person,
+  }
 end
@@ -2,24 +2,25 @@ require_dependency &#39;product&#39;
 class Product
-  Metadata = {
-    'og:type' => MetadataPlugin.og_types[:product],
-    'og:url' => proc{ |p, c| c.og_url_for p.url },
-    'og:gr_hascurrencyvalue' => proc{ |p, c| p.price.to_f },
-    'og:gr_hascurrency' => proc{ |p, c| p.environment.currency_unit },
-    'og:title' => proc{ |p, c| p.name },
-    'og:description' => proc{ |p, c| ActionView::Base.full_sanitizer.sanitize p.description },
-    'og:image' => proc{ |p, c| "#{p.environment.top_url}#{p.image.public_filename}" if p.image },
-    'og:image:type' => proc{ |p, c| p.image.content_type if p.image },
-    'og:image:height' => proc{ |p, c| p.image.height if p.image },
-    'og:image:width' => proc{ |p, c| p.image.width if p.image },
-    'og:see_also' => [],
-    'og:site_name' => proc{ |p, c| c.og_url_for p.profile.url },
-    'og:updated_time' => proc{ |p, c| p.updated_at.iso8601 },
-    'og:locale:locale' => proc{ |p, c| p.environment.default_language },
-    'og:locale:alternate' => proc{ |p, c| p.environment.languages - [p.environment.default_language] },
-  }
+  metadata_spec namespace: :og, tags: {
+    type: MetadataPlugin.og_types[:product] || :product,
+    url: proc{ |p, plugin| plugin.og_url_for p.url },
+    gr_hascurrencyvalue: proc{ |p, plugin| p.price.to_f },
+    gr_hascurrency: proc{ |p, plugin| p.environment.currency_unit },
+    title: proc{ |a, plugin| "#{p.name} - #{p.profile.name}" },
+    description: proc{ |p, plugin| ActionView::Base.full_sanitizer.sanitize p.description },
+
+    image: proc{ |p, plugin| "#{p.environment.top_url}#{p.image.public_filename}" if p.image },
+    'image:type' => proc{ |p, plugin| p.image.content_type if p.image },
+    'image:height' => proc{ |p, plugin| p.image.height if p.image },
+    'image:width' => proc{ |p, plugin| p.image.width if p.image },
-  protected
+    see_also: [],
+    site_name: proc{ |p, plugin| plugin.og_url_for p.profile.url },
+    updated_time: proc{ |p, plugin| p.updated_at.iso8601 },
+
+    'locale:locale' => proc{ |p, plugin| p.environment.default_language },
+    'locale:alternate' => proc{ |p, plugin| p.environment.languages - [p.environment.default_language] if p.environment.languages },
+  }
 end
@@ -2,23 +2,26 @@ require_dependency &#39;profile&#39;
 class Profile
-  Metadata = {
-    'og:type' => MetadataPlugin.og_types[:profile],
-    'og:image' => proc{ |p, c| "#{p.environment.top_url}#{p.image.public_filename}" if p.image },
-	  'og:title' => proc{ |p, c| p.short_name nil },
-    'og:url' => proc do |p, c|
+  metadata_spec namespace: :og, tags: {
+    type: MetadataPlugin.og_types[:profile] || :profile,
+    image: proc{ |p, plugin| "#{p.environment.top_url}#{p.image.public_filename}" if p.image },
+    title: proc{ |p, plugin| p.nickname || p.name },
+    url: proc do |p, plugin|
       #force profile identifier for custom domains and fixed host. see og_url_for
-      c.og_url_for p.url.merge(profile: p.identifier)
+      plugin.og_url_for p.url.merge(profile: p.identifier)
     end,
-    'og:description' => proc{ |p, c| p.description },
-	  'og:updated_time' => proc{ |p, c| p.updated_at.iso8601 },
-	  'place:location:latitude' => proc{ |p, c| p.lat },
-	  'place:location:longitude' => proc{ |p, c| p.lng },
-    'og:locale:locale' => proc{ |p, c| p.environment.default_language },
-    'og:locale:alternate' => proc{ |p, c| p.environment.languages - [p.environment.default_language] },
-	  'og:site_name' => "",
-	  'og:see_also' => "",
-	  'og:rich_attachment' => "",
+    description: proc{ |p, plugin| p.description },
+	  updated_time: proc{ |p, plugin| p.updated_at.iso8601 },
+    'locale:locale' => proc{ |p, plugin| p.environment.default_language },
+    'locale:alternate' => proc{ |p, plugin| p.environment.languages - [p.environment.default_language] if p.environment.languages },
+	  site_name: "",
+	  see_also: "",
+	  rich_attachment: "",
+  }
+
+  metadata_spec namespace: 'place:location', tags: {
+	  latitude: proc{ |p, plugin| p.lat },
+	  longitude: proc{ |p, plugin| p.lng },
   }
 end
@@ -3,15 +3,15 @@ require_dependency &quot;#{File.dirname __FILE__}/article&quot;
 class UploadedFile
-  Metadata = {
-    'og:type' => proc do |u, c|
+  metadata_spec namespace: :og, tags: {
+    type: proc do |u, plugin|
       type = if u.image? then :image else :uploaded_file end
-      MetadataPlugin.og_types[type]
+      MetadataPlugin.og_types[type] || type
     end,
-    'og:url' => proc{ |u, c| c.og_url_for u.url.merge(view: true) },
-    'og:title' => proc{ |u, c| u.title },
-    'og:image' => proc{ |u, c| "#{u.environment.top_url}#{u.public_filename}" if u.image? },
-    'og:description' => proc{ |u, c| u.abstract || u.title },
+    url: proc{ |u, plugin| plugin.og_url_for u.url.merge(view: true) },
+    title: proc{ |u, plugin| u.title },
+    image: proc{ |u, plugin| "#{u.environment.top_url}#{u.public_filename}" if u.image? },
+    description: proc{ |u, plugin| u.abstract || u.title },
   }
 end
@@ -17,30 +17,64 @@ class MetadataPlugin &lt; Noosfero::Plugin
     @og_types ||= self.config[:open_graph][:types] rescue {}
   end
+  Controllers = {
+    manage_products: {
+      variable: :@product,
+    },
+    content_viewer: {
+      variable: proc do
+        if profile and profile.home_page_id == @page.id
+          @profile
+        elsif @page.respond_to? :encapsulated_file
+          @page.encapsulated_file
+        else
+          @page
+        end
+      end,
+    },
+    profile: {
+      variable: :@profile,
+    },
+    # fallback
+    environment: {
+      variable: :@environment,
+    },
+  }
+
   def head_ending
     plugin = self
     lambda do
-      options = MetadataPlugin::Spec::Controllers[controller.controller_path.to_sym]
-      options ||= MetadataPlugin::Spec::Controllers[:profile] if controller.is_a? ProfileController
-      options ||= MetadataPlugin::Spec::Controllers[:environment]
+      options = MetadataPlugin::Controllers[controller.controller_path.to_sym]
+      options ||= MetadataPlugin::Controllers[:profile] if controller.is_a? ProfileController
+      options ||= MetadataPlugin::Controllers[:environment]
       return unless options
       return unless object = case variable = options[:variable]
         when Proc then instance_exec(&variable) rescue nil
         else instance_variable_get variable
         end
-      return unless metadata = (object.class.const_get(:Metadata) rescue nil)
-
-      metadata.map do |property, contents|
-        contents = contents.call(object, plugin) rescue nil if contents.is_a? Proc
-        next if contents.blank?
-
-        Array(contents).map do |content|
-          content = content.call(object, plugin) rescue nil if content.is_a? Proc
-          next if content.blank?
-          tag 'meta', property: property, content: content
-        end.join
-      end.join
+      return unless specs = (object.class.metadata_specs rescue nil)
+
+      r = []
+      specs.each do |namespace, spec|
+        namespace = "#{namespace}:" if namespace.present?
+        key_attr = spec[:key_attr] || :property
+        value_attr = spec[:value_attr] || :content
+        tags = spec[:tags]
+
+        tags.each do |key, values|
+          key = "#{namespace}#{key}"
+          values = values.call(object, plugin) rescue nil if values.is_a? Proc
+          next if values.blank?
+
+          Array(values).each do |value|
+            value = value.call(object, plugin) rescue nil if value.is_a? Proc
+            next if value.blank?
+            r << tag(:meta, key_attr => key, value_attr => value)
+          end
+        end
+      end
+      r.join
     end
   end
@@ -51,9 +85,16 @@ class MetadataPlugin &lt; Noosfero::Plugin
     Noosfero::Application.routes.url_helpers.url_for options
   end
+  def helpers
+    self.context.class.helpers
+  end
+
   protected
 end
 ActiveSupport.run_load_hooks :metadata_plugin, MetadataPlugin
+ActiveSupport.on_load :active_record do
+  ActiveRecord::Base.extend MetadataPlugin::Specs::ClassMethods
+end
@@ -1,29 +0,0 @@
-
-class MetadataPlugin::Spec
-
-  Controllers = {
-    manage_products: {
-      variable: :@product,
-    },
-    content_viewer: {
-      variable: proc do
-        if profile and profile.home_page_id == @page.id
-          @profile
-        elsif @page.respond_to? :encapsulated_file
-          @page.encapsulated_file
-        else
-          @page
-        end
-      end,
-    },
-    # fallback
-    profile: {
-      variable: :@profile,
-    },
-    # last fallback
-    environment: {
-      variable: :@environment,
-    },
-  }
-
-end
@@ -0,0 +1,22 @@
+module MetadataPlugin::Specs
+
+  module ClassMethods
+
+    def self.extended base
+      base.class_attribute :metadata_specs
+      base.metadata_specs ||= {}
+    end
+
+    def metadata_spec spec = {}
+      namespace = spec[:namespace]
+      # setters are used to avoid propagation to super classes, see http://apidock.com/rails/Class/class_attribute
+      if _spec = self.metadata_specs[namespace]
+        self.metadata_specs = self.metadata_specs.deep_merge(namespace => _spec.deep_merge(spec))
+      else
+        self.metadata_specs = self.metadata_specs.deep_merge(namespace => spec)
+      end
+    end
+
+  end
+
+end
@@ -0,0 +1,51 @@
+require 'test_helper'
+require 'content_viewer_controller'
+
+# Re-raise errors caught by the controller.
+class ContentViewerController; def rescue_action(e) raise e end; end
+
+class ContentViewerControllerTest < ActionController::TestCase
+
+  def setup
+    @controller = ContentViewerController.new
+    @request    = ActionController::TestRequest.new
+    @response   = ActionController::TestResponse.new
+
+    @profile = create_user('testinguser').person
+    @environment = @profile.environment
+    @environment.enabled_plugins += ['MetadataPlugin']
+    @environment.save!
+  end
+
+  attr_reader :profile, :environment
+
+  should 'produce meta tags for profile if on homepage' do
+    get :view_page, profile: profile.identifier, page: []
+    assert_tag tag: 'meta', attributes: {property: 'og:title', content: profile.name}
+  end
+
+  should 'add meta tags with article info' do
+    a = TinyMceArticle.create(name: 'Article to be shared', body: 'This article should be shared with all social networks', profile: profile)
+
+    get :view_page, profile: profile.identifier, page: [ a.name.to_slug ]
+
+    assert_tag tag: 'meta', attributes: { name: 'twitter:title', content: /#{a.name} - #{a.profile.name}/ }
+    assert_tag tag: 'meta', attributes: { name: 'twitter:description', content: a.body }
+    assert_no_tag tag: 'meta', attributes: { name: 'twitter:image' }
+    assert_tag tag: 'meta', attributes: { property: 'og:type', content: 'article' }
+    assert_tag tag: 'meta', attributes: { property: 'og:url', content: /\/#{profile.identifier}\/#{a.name.to_slug}/ }
+    assert_tag tag: 'meta', attributes: { property: 'og:title', content: /#{a.name} - #{a.profile.name}/ }
+    assert_tag tag: 'meta', attributes: { property: 'og:site_name', content: a.profile.name }
+    assert_tag tag: 'meta', attributes: { property: 'og:description', content: a.body }
+    assert_no_tag tag: 'meta', attributes: { property: 'og:image' }
+  end
+
+  should 'add meta tags with article images' do
+    a = TinyMceArticle.create(name: 'Article to be shared with images', body: 'This article should be shared with all social networks <img src="/images/x.png" />', profile: profile)
+
+    get :view_page, profile: profile.identifier, page: [ a.name.to_slug ]
+    assert_tag tag: 'meta', attributes: { name: 'twitter:image', content: /\/images\/x.png/ }
+    assert_tag tag: 'meta', attributes: { property: 'og:image', content: /\/images\/x.png/  }
+  end
+
+end
@@ -1405,30 +1405,6 @@ class ContentViewerControllerTest &lt; ActionController::TestCase
     end
   end
-  should 'add meta tags with article info' do
-    a = TinyMceArticle.create(:name => 'Article to be shared', :body => 'This article should be shared with all social networks', :profile => profile)
-
-    get :view_page, :profile => profile.identifier, :page => [ a.name.to_slug ]
-
-    assert_tag :tag => 'meta', :attributes => { :name => 'twitter:title', :content => /#{a.name} - #{a.profile.name}/ }
-    assert_tag :tag => 'meta', :attributes => { :name => 'twitter:description', :content => a.body }
-    assert_no_tag :tag => 'meta', :attributes => { :name => 'twitter:image' }
-    assert_tag :tag => 'meta', :attributes => { :property => 'og:type', :content => 'article' }
-    assert_tag :tag => 'meta', :attributes => { :property => 'og:url', :content => /\/#{profile.identifier}\/#{a.name.to_slug}/ }
-    assert_tag :tag => 'meta', :attributes => { :property => 'og:title', :content => /#{a.name} - #{a.profile.name}/ }
-    assert_tag :tag => 'meta', :attributes => { :property => 'og:site_name', :content => a.profile.name }
-    assert_tag :tag => 'meta', :attributes => { :property => 'og:description', :content => a.body }
-    assert_no_tag :tag => 'meta', :attributes => { :property => 'og:image' }
-  end
-
-  should 'add meta tags with article images' do
-    a = TinyMceArticle.create(:name => 'Article to be shared with images', :body => 'This article should be shared with all social networks <img src="/images/x.png" />', :profile => profile)
-
-    get :view_page, :profile => profile.identifier, :page => [ a.name.to_slug ]
-    assert_tag :tag => 'meta', :attributes => { :name => 'twitter:image', :content => /\/images\/x.png/ }
-    assert_tag :tag => 'meta', :attributes => { :property => 'og:image', :content => /\/images\/x.png/  }
-  end
-
   should 'manage  private article visualization' do
     community = Community.create(:name => 'test-community')
     community.add_member(@profile)
	@@ -116,8 +116,5 @@ module LayoutHelper		@@ -116,8 +116,5 @@ module LayoutHelper
116	end	116	end
117	end	117	end
118		118
119	- def meta_description_tag(article=nil)
120	- article ? CGI.escapeHTML(truncate(strip_tags(article.body.to_s), :length => 200)) : environment.name
121	- end
122	end	119	end
123		120
	@@ -2,31 +2,42 @@ require_dependency 'article'		@@ -2,31 +2,42 @@ require_dependency 'article'
2		2
3	class Article	3	class Article
4		4
5	- Metadata = {
6	- 'og:type' => MetadataPlugin.og_types[:article],
7	- 'og:url' => proc{ \|a, c\| c.og_url_for a.url },
8	- 'og:title' => proc{ \|a, c\| a.title },
9	- 'og:image' => proc do \|a, c\|
10	- result = a.body_images_paths
11	- result = "#{a.profile.environment.top_url}#{a.profile.image.public_filename}" if a.profile.image if result.blank?
12	- result = MetadataPlugin.config[:open_graph][:environment_logo] if result.blank?
13	- result
14	- end,
15	- 'og:see_also' => [],
16	- 'og:site_name' => proc{ \|a, c\| a.profile.name },
17	- 'og:updated_time' => proc{ \|a, c\| a.updated_at.iso8601 },
18	- 'og:locale:locale' => proc{ \|a, c\| a.environment.default_language },
19	- 'og:locale:alternate' => proc{ \|a, c\| a.environment.languages - [a.environment.default_language] },
20	- 'twitter:image' => proc{ \|a, c\| a.body_images_paths },
21	- 'article:expiration_time' => "", # In the future we might want to populate this
22	- 'article:modified_time' => proc{ \|a, c\| a.updated_at.iso8601 },
23	- 'article:published_time' => proc{ \|a, c\| a.published_at.iso8601 },
24	- 'article:section' => "", # In the future we might want to populate this
25	- 'article:tag' => proc{ \|a, c\| a.tags.map &:name },
26	- 'og:description' => proc{ \|a, c\| ActionView::Base.full_sanitizer.sanitize a.body },
27	- 'og:rich_attachment' => "",	5	+ metadata_spec namespace: :og, key_attr: :property, tags: {
		6	+ type: MetadataPlugin.og_types[:article] \|\| :article,
		7	+ url: proc{ \|a, plugin\| plugin.og_url_for a.url },
		8	+ title: proc{ \|a, plugin\| "#{a.title} - #{a.profile.name}" },
		9	+ image: proc do \|a, plugin\|
		10	+ result = a.body_images_paths
		11	+ result = "#{a.profile.environment.top_url}#{a.profile.image.public_filename}" if a.profile.image if result.blank?
		12	+ result \|\|= MetadataPlugin.config[:open_graph][:environment_logo] rescue nil if result.blank?
		13	+ result
		14	+ end,
		15	+ see_also: [],
		16	+ site_name: proc{ \|a, c\| a.profile.name },
		17	+ updated_time: proc{ \|a, c\| a.updated_at.iso8601 },
		18	+ 'locale:locale' => proc{ \|a, c\| a.environment.default_language },
		19	+ 'locale:alternate' => proc{ \|a, c\| a.environment.languages - [a.environment.default_language] },
		20	+
		21	+ description: proc{ \|a, plugin\| ActionView::Base.full_sanitizer.sanitize a.body },
		22	+ rich_attachment: "",
28	}	23	}
29		24
		25	+ metadata_spec namespace: :twitter, key_attr: :name, tags: {
		26	+ card: 'summary',
		27	+ description: proc do \|a, plugin\|
		28	+ description = a.body.to_s \|\| a.environment.name
		29	+ CGI.escapeHTML(plugin.helpers.truncate(plugin.helpers.strip_tags(description), length: 200))
		30	+ end,
		31	+ title: proc{ \|a, plugin\| "#{a.title} - #{a.profile.name}" },
		32	+ image: proc{ \|a, plugin\| a.body_images_paths },
		33	+ }
30		34
		35	+ metadata_spec namespace: :article, key_attr: :property, tags: {
		36	+ expiration_time: "", # In the future we might want to populate this
		37	+ modified_time: proc{ \|a, plugin\| a.updated_at.iso8601 },
		38	+ published_time: proc{ \|a, plugin\| a.published_at.iso8601 },
		39	+ section: "", # In the future we might want to populate this
		40	+ tag: proc{ \|a, plugin\| a.tags.map &:name },
		41	+ }
31		42
32	end	43	end
	@@ -17,30 +17,64 @@ class MetadataPlugin < Noosfero::Plugin		@@ -17,30 +17,64 @@ class MetadataPlugin < Noosfero::Plugin
17	@og_types \|\|= self.config[:open_graph][:types] rescue {}	17	@og_types \|\|= self.config[:open_graph][:types] rescue {}
18	end	18	end
19		19
		20	+ Controllers = {
		21	+ manage_products: {
		22	+ variable: :@product,
		23	+ },
		24	+ content_viewer: {
		25	+ variable: proc do
		26	+ if profile and profile.home_page_id == @page.id
		27	+ @profile
		28	+ elsif @page.respond_to? :encapsulated_file
		29	+ @page.encapsulated_file
		30	+ else
		31	+ @page
		32	+ end
		33	+ end,
		34	+ },
		35	+ profile: {
		36	+ variable: :@profile,
		37	+ },
		38	+ # fallback
		39	+ environment: {
		40	+ variable: :@environment,
		41	+ },
		42	+ }
		43	+
20	def head_ending	44	def head_ending
21	plugin = self	45	plugin = self
22	lambda do	46	lambda do
23	- options = MetadataPlugin::Spec::Controllers[controller.controller_path.to_sym]
24	- options \|\|= MetadataPlugin::Spec::Controllers[:profile] if controller.is_a? ProfileController
25	- options \|\|= MetadataPlugin::Spec::Controllers[:environment]	47	+ options = MetadataPlugin::Controllers[controller.controller_path.to_sym]
		48	+ options \|\|= MetadataPlugin::Controllers[:profile] if controller.is_a? ProfileController
		49	+ options \|\|= MetadataPlugin::Controllers[:environment]
26	return unless options	50	return unless options
27		51
28	return unless object = case variable = options[:variable]	52	return unless object = case variable = options[:variable]
29	when Proc then instance_exec(&variable) rescue nil	53	when Proc then instance_exec(&variable) rescue nil
30	else instance_variable_get variable	54	else instance_variable_get variable
31	end	55	end
32	- return unless metadata = (object.class.const_get(:Metadata) rescue nil)
33	-
34	- metadata.map do \|property, contents\|
35	- contents = contents.call(object, plugin) rescue nil if contents.is_a? Proc
36	- next if contents.blank?
37	-
38	- Array(contents).map do \|content\|
39	- content = content.call(object, plugin) rescue nil if content.is_a? Proc
40	- next if content.blank?
41	- tag 'meta', property: property, content: content
42	- end.join
43	- end.join	56	+ return unless specs = (object.class.metadata_specs rescue nil)
		57	+
		58	+ r = []
		59	+ specs.each do \|namespace, spec\|
		60	+ namespace = "#{namespace}:" if namespace.present?
		61	+ key_attr = spec[:key_attr] \|\| :property
		62	+ value_attr = spec[:value_attr] \|\| :content
		63	+ tags = spec[:tags]
		64	+
		65	+ tags.each do \|key, values\|
		66	+ key = "#{namespace}#{key}"
		67	+ values = values.call(object, plugin) rescue nil if values.is_a? Proc
		68	+ next if values.blank?
		69	+
		70	+ Array(values).each do \|value\|
		71	+ value = value.call(object, plugin) rescue nil if value.is_a? Proc
		72	+ next if value.blank?
		73	+ r << tag(:meta, key_attr => key, value_attr => value)
		74	+ end
		75	+ end
		76	+ end
		77	+ r.join
44	end	78	end
45	end	79	end
46		80
	@@ -51,9 +85,16 @@ class MetadataPlugin < Noosfero::Plugin		@@ -51,9 +85,16 @@ class MetadataPlugin < Noosfero::Plugin
51	Noosfero::Application.routes.url_helpers.url_for options	85	Noosfero::Application.routes.url_helpers.url_for options
52	end	86	end
53		87
		88	+ def helpers
		89	+ self.context.class.helpers
		90	+ end
		91	+
54	protected	92	protected
55		93
56	end	94	end
57		95
58	ActiveSupport.run_load_hooks :metadata_plugin, MetadataPlugin	96	ActiveSupport.run_load_hooks :metadata_plugin, MetadataPlugin
		97	+ActiveSupport.on_load :active_record do
		98	+ ActiveRecord::Base.extend MetadataPlugin::Specs::ClassMethods
		99	+end
59		100
	@@ -1,29 +0,0 @@	@@ -1,29 +0,0 @@
1	-
2	-class MetadataPlugin::Spec
3	-
4	- Controllers = {
5	- manage_products: {
6	- variable: :@product,
7	- },
8	- content_viewer: {
9	- variable: proc do
10	- if profile and profile.home_page_id == @page.id
11	- @profile
12	- elsif @page.respond_to? :encapsulated_file
13	- @page.encapsulated_file
14	- else
15	- @page
16	- end
17	- end,
18	- },
19	- # fallback
20	- profile: {
21	- variable: :@profile,
22	- },
23	- # last fallback
24	- environment: {
25	- variable: :@environment,
26	- },
27	- }
28	-
29	-end
@@ -0,0 +1,22 @@		@@ -0,0 +1,22 @@
	1	+module MetadataPlugin::Specs
	2	+
	3	+ module ClassMethods
	4	+
	5	+ def self.extended base
	6	+ base.class_attribute :metadata_specs
	7	+ base.metadata_specs \|\|= {}
	8	+ end
	9	+
	10	+ def metadata_spec spec = {}
	11	+ namespace = spec[:namespace]
	12	+ # setters are used to avoid propagation to super classes, see http://apidock.com/rails/Class/class_attribute
	13	+ if _spec = self.metadata_specs[namespace]
	14	+ self.metadata_specs = self.metadata_specs.deep_merge(namespace => _spec.deep_merge(spec))
	15	+ else
	16	+ self.metadata_specs = self.metadata_specs.deep_merge(namespace => spec)
	17	+ end
	18	+ end
	19	+
	20	+ end
	21	+
	22	+end
@@ -0,0 +1,51 @@		@@ -0,0 +1,51 @@
	1	+require 'test_helper'
	2	+require 'content_viewer_controller'
	3	+
	4	+# Re-raise errors caught by the controller.
	5	+class ContentViewerController; def rescue_action(e) raise e end; end
	6	+
	7	+class ContentViewerControllerTest < ActionController::TestCase
	8	+
	9	+ def setup
	10	+ @controller = ContentViewerController.new
	11	+ @request = ActionController::TestRequest.new
	12	+ @response = ActionController::TestResponse.new
	13	+
	14	+ @profile = create_user('testinguser').person
	15	+ @environment = @profile.environment
	16	+ @environment.enabled_plugins += ['MetadataPlugin']
	17	+ @environment.save!
	18	+ end
	19	+
	20	+ attr_reader :profile, :environment
	21	+
	22	+ should 'produce meta tags for profile if on homepage' do
	23	+ get :view_page, profile: profile.identifier, page: []
	24	+ assert_tag tag: 'meta', attributes: {property: 'og:title', content: profile.name}
	25	+ end
	26	+
	27	+ should 'add meta tags with article info' do
	28	+ a = TinyMceArticle.create(name: 'Article to be shared', body: 'This article should be shared with all social networks', profile: profile)
	29	+
	30	+ get :view_page, profile: profile.identifier, page: [ a.name.to_slug ]
	31	+
	32	+ assert_tag tag: 'meta', attributes: { name: 'twitter:title', content: /#{a.name} - #{a.profile.name}/ }
	33	+ assert_tag tag: 'meta', attributes: { name: 'twitter:description', content: a.body }
	34	+ assert_no_tag tag: 'meta', attributes: { name: 'twitter:image' }
	35	+ assert_tag tag: 'meta', attributes: { property: 'og:type', content: 'article' }
	36	+ assert_tag tag: 'meta', attributes: { property: 'og:url', content: /\/#{profile.identifier}\/#{a.name.to_slug}/ }
	37	+ assert_tag tag: 'meta', attributes: { property: 'og:title', content: /#{a.name} - #{a.profile.name}/ }
	38	+ assert_tag tag: 'meta', attributes: { property: 'og:site_name', content: a.profile.name }
	39	+ assert_tag tag: 'meta', attributes: { property: 'og:description', content: a.body }
	40	+ assert_no_tag tag: 'meta', attributes: { property: 'og:image' }
	41	+ end
	42	+
	43	+ should 'add meta tags with article images' do
	44	+ a = TinyMceArticle.create(name: 'Article to be shared with images', body: 'This article should be shared with all social networks <img src="/images/x.png" />', profile: profile)
	45	+
	46	+ get :view_page, profile: profile.identifier, page: [ a.name.to_slug ]
	47	+ assert_tag tag: 'meta', attributes: { name: 'twitter:image', content: /\/images\/x.png/ }
	48	+ assert_tag tag: 'meta', attributes: { property: 'og:image', content: /\/images\/x.png/ }
	49	+ end
	50	+
	51	+end
	@@ -1405,30 +1405,6 @@ class ContentViewerControllerTest < ActionController::TestCase		@@ -1405,30 +1405,6 @@ class ContentViewerControllerTest < ActionController::TestCase
1405	end	1405	end
1406	end	1406	end
1407		1407
1408	- should 'add meta tags with article info' do
1409	- a = TinyMceArticle.create(:name => 'Article to be shared', :body => 'This article should be shared with all social networks', :profile => profile)
1410	-
1411	- get :view_page, :profile => profile.identifier, :page => [ a.name.to_slug ]
1412	-
1413	- assert_tag :tag => 'meta', :attributes => { :name => 'twitter:title', :content => /#{a.name} - #{a.profile.name}/ }
1414	- assert_tag :tag => 'meta', :attributes => { :name => 'twitter:description', :content => a.body }
1415	- assert_no_tag :tag => 'meta', :attributes => { :name => 'twitter:image' }
1416	- assert_tag :tag => 'meta', :attributes => { :property => 'og:type', :content => 'article' }
1417	- assert_tag :tag => 'meta', :attributes => { :property => 'og:url', :content => /\/#{profile.identifier}\/#{a.name.to_slug}/ }
1418	- assert_tag :tag => 'meta', :attributes => { :property => 'og:title', :content => /#{a.name} - #{a.profile.name}/ }
1419	- assert_tag :tag => 'meta', :attributes => { :property => 'og:site_name', :content => a.profile.name }
1420	- assert_tag :tag => 'meta', :attributes => { :property => 'og:description', :content => a.body }
1421	- assert_no_tag :tag => 'meta', :attributes => { :property => 'og:image' }
1422	- end
1423	-
1424	- should 'add meta tags with article images' do
1425	- a = TinyMceArticle.create(:name => 'Article to be shared with images', :body => 'This article should be shared with all social networks <img src="/images/x.png" />', :profile => profile)
1426	-
1427	- get :view_page, :profile => profile.identifier, :page => [ a.name.to_slug ]
1428	- assert_tag :tag => 'meta', :attributes => { :name => 'twitter:image', :content => /\/images\/x.png/ }
1429	- assert_tag :tag => 'meta', :attributes => { :property => 'og:image', :content => /\/images\/x.png/ }
1430	- end
1431	-
1432	should 'manage private article visualization' do	1408	should 'manage private article visualization' do
1433	community = Community.create(:name => 'test-community')	1409	community = Community.create(:name => 'test-community')
1434	community.add_member(@profile)	1410	community.add_member(@profile)