[Mezuro] Completed module result model, fixtures and tests.

João M. M. da Silva + Paulo Meirelles · João M. M. da Silva
1 parent 4b852f68
Showing 4 changed files with 24 additions and 74 deletions Show diff stats
plugins/mezuro/lib/kalibro/module_result.rb
plugins/mezuro/test/fixtures/module_result_fixtures.rb
plugins/mezuro/test/unit/kalibro/module_result_test.rb
plugins/mezuro/test/unit/kalibro/module_test.rb
 class Kalibro::ModuleResult < Kalibro::Model
-  attr_accessor :module, :date, :grade, :metric_result, :compound_metric_with_error
+  attr_accessor :id, :module, :grade, :parent_id
-  def self.find_by_project_name_and_module_name_and_date(project_name, module_name, date)
-    new request(
-    'ModuleResult',
-    :get_module_result,
-      {
-        :project_name => project_name, 
-        :module_name => module_name,
-        :date => date_with_milliseconds(date)
-      })[:module_result]
+  def self.find(id)
+    new request('ModuleResult', :get_module_result, { :module_result_id => id })[:module_result]
   end
-  
-  def self.all_by_project_name_and_module_name(project_name, module_name)
-    response = request(
-    'ModuleResult',
-    :get_result_history,
-      {
-        :project_name => project_name, 
-        :module_name => module_name
-      })[:module_result]
-    Kalibro::ModuleResult.to_objects_array(response)
+
+  def children
+    hash_array = self.class.request('ModuleResult',:children_of, {:module_result_id => self.id})[:module_result].to_a
+    hash_array.map { |module_result| self.class.new module_result }
   end
   def module=(value)
     @module = Kalibro::Module.to_object value
   end
-  def date=(value)
-    @date = value.is_a?(String) ? DateTime.parse(value) : value
-  end
-
   def grade=(value)
     @grade = value.to_f
   end
-  def metric_result=(value)
-    @metric_result = Kalibro::MetricResult.to_objects_array value
-  end
-  
-  def metric_results
-    @metric_result
-  end
-  
-  def metric_results=(metric_results)
-    @metric_result = metric_results
-  end
-
-  def compound_metric_with_error=(value)
-    @compound_metric_with_error = Kalibro::CompoundMetricWithError.to_objects_array value
-  end
-
-  def compound_metrics_with_error
-    @compound_metric_with_error
-  end
-
-  def compound_metrics_with_error=(compound_metrics_with_error)
-    @compound_metric_with_error = compound_metrics_with_error
-  end
-
 end
 require File.dirname(__FILE__) + '/module_fixtures'
-require File.dirname(__FILE__) + '/metric_result_fixtures'
-require File.dirname(__FILE__) + '/compound_metric_with_error_fixtures'
 class ModuleResultFixtures
@@ -10,17 +8,17 @@ class ModuleResultFixtures
   def self.module_result_hash
     {
+      :id => 42,
       :module => ModuleFixtures.module_hash,
-      :date => '2011-10-20T18:26:43.151+00:00',
       :grade => 10.0,
-      :metric_result => [
-        MetricResultFixtures.native_metric_result_hash,
-        MetricResultFixtures.compound_metric_result_hash],
-      :compound_metric_with_error => [CompoundMetricWithErrorFixtures.compound_metric_with_error_hash],
-      :attributes! => {
-        :module => {
-          'xmlns:xsi'=> 'http://www.w3.org/2001/XMLSchema-instance',
-          'xsi:type' => 'kalibro:moduleXml'  }
+      :parent_id => 31,
+      :attributes! =>
+      {
+        :module =>
+        {
+          "xmlns:xsi"=>"http://www.w3.org/2001/XMLSchema-instance",
+          "xsi:type"=>"kalibro:moduleXml"
+        }
       }
     }
   end
@@ -9,7 +9,7 @@ class ModuleResultTest &lt; ActiveSupport::TestCase
     @module_result = ModuleResultFixtures.module_result
   end
   should 'create module result' do
-    assert_equal @module_result.date.to_s , Kalibro::ModuleResult.new(@hash).date.to_s
+    assert_equal @hash[:id] , Kalibro::ModuleResult.new(@hash).id
   end
   should 'convert module result to hash' do
@@ -17,22 +17,15 @@ class ModuleResultTest &lt; ActiveSupport::TestCase
   end
   should 'find module result' do
-    date = DateTime.parse(@module_result.date.to_s)
-    name = @module_result.module.name
-    request_body = {:project_name => name, :module_name => name, :date => '2011-10-20T18:26:43.0+00:00'}
     response = {:module_result => @hash}
-    Kalibro::ModuleResult.expects(:request).with('ModuleResult',:get_module_result, request_body).returns(response)
-    assert_equal @module_result.grade, Kalibro::ModuleResult.find_by_project_name_and_module_name_and_date(name, name, date).grade
+    Kalibro::ModuleResult.expects(:request).with('ModuleResult',:get_module_result, {:module_result_id => @module_result.id}).returns(response)
+    assert_equal @module_result.grade, Kalibro::ModuleResult.find(@module_result.id).grade
   end
-  should 'find all module results' do
-    name = @module_result.module.name
-    request_body = {:project_name => name, :module_name => name}
-    response = {:module_result => @hash}
-    Kalibro::ModuleResult.expects(:request).with('ModuleResult',:get_result_history, request_body).returns(response)
-    response_array = Kalibro::ModuleResult.all_by_project_name_and_module_name(name, name)
-    assert_equal [@module_result].class, response_array.class
-    assert_equal @module_result.grade, response_array[0].grade
+  should 'return children of a module result' do
+    response = {:module_result => [@hash]}
+    Kalibro::ModuleResult.expects(:request).with('ModuleResult',:children_of, {:module_result_id => @module_result.id}).returns(response)
+    assert @hash[:id], @module_result.children.first.id
   end
 end
@@ -12,7 +12,7 @@ class ModuleTest &lt; ActiveSupport::TestCase
   should 'create module from hash' do
     assert_equal @hash[:name], Kalibro::Module.new(@hash).name
   end
-  
+
   should 'convert module to hash' do
     assert_equal @hash, @module.to_hash
   end
1	class Kalibro::ModuleResult < Kalibro::Model	1	class Kalibro::ModuleResult < Kalibro::Model
2		2
3	- attr_accessor :module, :date, :grade, :metric_result, :compound_metric_with_error	3	+ attr_accessor :id, :module, :grade, :parent_id
4		4
5	- def self.find_by_project_name_and_module_name_and_date(project_name, module_name, date)
6	- new request(
7	- 'ModuleResult',
8	- :get_module_result,
9	- {
10	- :project_name => project_name,
11	- :module_name => module_name,
12	- :date => date_with_milliseconds(date)
13	- })[:module_result]	5	+ def self.find(id)
		6	+ new request('ModuleResult', :get_module_result, { :module_result_id => id })[:module_result]
14	end	7	end
15	-
16	- def self.all_by_project_name_and_module_name(project_name, module_name)
17	- response = request(
18	- 'ModuleResult',
19	- :get_result_history,
20	- {
21	- :project_name => project_name,
22	- :module_name => module_name
23	- })[:module_result]
24	- Kalibro::ModuleResult.to_objects_array(response)	8	+
		9	+ def children
		10	+ hash_array = self.class.request('ModuleResult',:children_of, {:module_result_id => self.id})[:module_result].to_a
		11	+ hash_array.map { \|module_result\| self.class.new module_result }
25	end	12	end
26		13
27	def module=(value)	14	def module=(value)
28	@module = Kalibro::Module.to_object value	15	@module = Kalibro::Module.to_object value
29	end	16	end
30		17
31	- def date=(value)
32	- @date = value.is_a?(String) ? DateTime.parse(value) : value
33	- end
34	-
35	def grade=(value)	18	def grade=(value)
36	@grade = value.to_f	19	@grade = value.to_f
37	end	20	end
38		21
39	- def metric_result=(value)
40	- @metric_result = Kalibro::MetricResult.to_objects_array value
41	- end
42	-
43	- def metric_results
44	- @metric_result
45	- end
46	-
47	- def metric_results=(metric_results)
48	- @metric_result = metric_results
49	- end
50	-
51	- def compound_metric_with_error=(value)
52	- @compound_metric_with_error = Kalibro::CompoundMetricWithError.to_objects_array value
53	- end
54	-
55	- def compound_metrics_with_error
56	- @compound_metric_with_error
57	- end
58	-
59	- def compound_metrics_with_error=(compound_metrics_with_error)
60	- @compound_metric_with_error = compound_metrics_with_error
61	- end
62	-
63	end	22	end
	@@ -12,7 +12,7 @@ class ModuleTest < ActiveSupport::TestCase		@@ -12,7 +12,7 @@ class ModuleTest < ActiveSupport::TestCase
12	should 'create module from hash' do	12	should 'create module from hash' do
13	assert_equal @hash[:name], Kalibro::Module.new(@hash).name	13	assert_equal @hash[:name], Kalibro::Module.new(@hash).name
14	end	14	end
15	-	15	+
16	should 'convert module to hash' do	16	should 'convert module to hash' do
17	assert_equal @hash, @module.to_hash	17	assert_equal @hash, @module.to_hash
18	end	18	end