rails3: fix blog and forum tests

Rodrigo Souto
1 parent 2fe1ebd0
Showing 6 changed files with 29 additions and 23 deletions Show diff stats
app/models/blog.rb
app/models/external_feed.rb
app/models/rss_feed.rb
lib/acts_as_having_posts.rb
test/unit/blog_test.rb
test/unit/forum_test.rb
@@ -46,7 +46,9 @@ class Blog &lt; Folder
     self.external_feed_data = efeed
   end
-  def validate
+  validate :prepare_external_feed
+
+  def prepare_external_feed
     unless self.external_feed_data.nil?
       if self.external_feed(true) && self.external_feed.id == self.external_feed_data[:id].to_i
         self.external_feed.attributes = self.external_feed_data
@@ -10,6 +10,8 @@ class ExternalFeed &lt; ActiveRecord::Base
     { :conditions => ['(fetched_at is NULL) OR (fetched_at < ?)', Time.now - FeedUpdater.update_interval] }
   }
+  attr_accessible :address, :enabled
+
   def add_item(title, link, date, content)
     doc = Hpricot(content)
     doc.search('*').each do |p|
 class RssFeed < Article
+  attr_accessible :limit, :enabled
+
   def self.type_name
     _('RssFeed')
   end
@@ -28,9 +28,7 @@ module ActsAsHavingPosts
   def feed=(attrs)
     if attrs
       if self.feed
-        attrs.each do |key, value|
-          self.feed.send(key.to_s+'=', value)
-        end
+        self.feed.update_attributes(attrs)
       else
         self.feed_attrs = attrs
       end
@@ -38,14 +38,14 @@ class BlogTest &lt; ActiveSupport::TestCase
   should 'save feed options' do
     p = create_user('testuser').person
-    p.articles << Blog.new(:profile => p, :name => 'blog_feed_test')
+    p.articles << build(Blog, :profile => p, :name => 'blog_feed_test')
     p.blog.feed = { :limit => 7 }
     assert_equal 7, p.blog.feed.limit
   end
   should 'save feed options after create blog' do
     p = create_user('testuser').person
-    p.articles << Blog.new(:profile => p, :name => 'blog_feed_test', :feed => { :limit => 7 })
+    p.articles << build(Blog, :profile => p, :name => 'blog_feed_test', :feed => { :limit => 7 })
     assert_equal 7, p.blog.feed.limit
   end
@@ -56,7 +56,7 @@ class BlogTest &lt; ActiveSupport::TestCase
   should 'update posts per page setting' do
     p = create_user('testuser').person
-    p.articles << Blog.new(:profile => p, :name => 'Blog test')
+    p.articles << build(Blog, :profile => p, :name => 'Blog test')
     blog = p.blog
     blog.posts_per_page = 7
     assert blog.save!
@@ -95,7 +95,7 @@ class BlogTest &lt; ActiveSupport::TestCase
   should 'build external feed after save' do
     p = create_user('testuser').person
-    blog = Blog.new(:profile => p, :name => 'Blog test')
+    blog = build(Blog, :profile => p, :name => 'Blog test')
     blog.external_feed_builder = { :address => 'feed address' }
     blog.save!
     assert blog.external_feed.valid?
@@ -103,9 +103,9 @@ class BlogTest &lt; ActiveSupport::TestCase
   should 'update external feed' do
     p = create_user('testuser').person
-    blog = Blog.new(:profile => p, :name => 'Blog test')
+    blog = build(Blog, :profile => p, :name => 'Blog test')
     blog.save
-    e = ExternalFeed.new(:address => 'feed address')
+    e = build(ExternalFeed, :address => 'feed address')
     e.blog = blog
     e.save
     blog.reload
@@ -116,14 +116,14 @@ class BlogTest &lt; ActiveSupport::TestCase
   should 'invalid blog if has invalid external_feed' do
     p = create_user('testuser').person
-    blog = Blog.new(:profile => p, :name => 'Blog test', :external_feed_builder => {:enabled => true})
+    blog = build(Blog, :profile => p, :name => 'Blog test', :external_feed_builder => {:enabled => true})
     blog.save
     assert ! blog.valid?
   end
   should 'remove external feed when removing blog' do
     p = create_user('testuser').person
-    blog = Blog.create!(:name => 'Blog test', :profile => p, :external_feed_builder => {:enabled => true, :address => "http://bli.org/feed"})
+    blog = create(Blog, :name => 'Blog test', :profile => p, :external_feed_builder => {:enabled => true, :address => "http://bli.org/feed"})
     assert blog.external_feed
     assert_difference ExternalFeed, :count, -1 do
       blog.destroy
@@ -134,16 +134,17 @@ class BlogTest &lt; ActiveSupport::TestCase
     p = create_user('testuser').person
     fast_create(Blog, :name => 'Blog test', :profile_id => p.id)
     assert_nothing_raised ActiveRecord::RecordInvalid do
-      Blog.create!(:name => 'Another Blog', :profile => p)
+      create(Blog, :name => 'Another Blog', :profile => p)
     end
   end
   should 'not update slug from name for existing blog' do
     p = create_user('testuser').person
-    blog = Blog.create!(:name => 'Blog test', :profile => p)
-    assert_equal 'blog-test', blog.slug
-    blog.name = 'Changed name'
-    assert_not_equal 'changed-name', blog.slug
+    blog = create(Blog, :profile => p)
+    new_name = 'Changed name'
+    assert_not_equal new_name.to_slug, blog.slug
+    blog.name = new_name
+    assert_not_equal new_name.to_slug, blog.slug
   end
   should 'display full posts by default' do
@@ -153,7 +154,7 @@ class BlogTest &lt; ActiveSupport::TestCase
   should 'update visualization_format setting' do
     p = create_user('testuser').person
-    p.articles << Blog.new(:profile => p, :name => 'Blog test')
+    p.articles << build(Blog, :profile => p, :name => 'Blog test')
     blog = p.blog
     blog.visualization_format = 'short'
     assert blog.save!
@@ -161,7 +162,7 @@ class BlogTest &lt; ActiveSupport::TestCase
   end
   should 'allow only full and short as visualization_format' do
-    blog = Blog.new(:name => 'blog')
+    blog = build(Blog, :name => 'blog')
     blog.visualization_format = 'wrong_format'
     blog.valid?
     assert blog.errors[:visualization_format.to_s].present?
@@ -187,7 +188,7 @@ class BlogTest &lt; ActiveSupport::TestCase
   should 'update display posts in current language setting' do
     p = create_user('testuser').person
-    p.articles << Blog.new(:profile => p, :name => 'Blog test')
+    p.articles << build(Blog, :profile => p, :name => 'Blog test')
     blog = p.blog
     blog.display_posts_in_current_language = false
     assert blog.save! && blog.reload
@@ -95,9 +95,10 @@ class ForumTest &lt; ActiveSupport::TestCase
   should 'not update slug from name for existing forum' do
     p = create_user('testuser').person
     forum = create(Forum, :name => 'Forum test', :profile_id => p.id, :body => 'Forum')
-    assert_equal 'forum-test', forum.slug
-    forum.name = 'Changed name'
-    assert_not_equal 'changed-name', forum.slug
+    new_name = 'Changed name'
+    assert_not_equal new_name.to_slug, forum.slug
+    forum.name = new_name
+    assert_not_equal new_name.to_slug, forum.slug
   end
   should 'have posts' do
1	class RssFeed < Article	1	class RssFeed < Article
2		2
		3	+ attr_accessible :limit, :enabled
		4	+
3	def self.type_name	5	def self.type_name
4	_('RssFeed')	6	_('RssFeed')
5	end	7	end