Download as
Browse Code »

Commit 994858779af504c197ddd51eee76fbbaf3124c5c

Authored by Rodrigo Souto
1 parent 54e2f909
Exists in master and in 29 other branches add_member_task_reject_details, admin_visible_profile, article-list-template, community_notifications, contact_admin_translation, event_fixes, fix_comments_pagination, fix_rails4_organization_ratings, fix_sign_up_form, follow_step_fix, forum_topic_creation, mirror_block_improvements, multi_env_on_remote_user, new_security, noosfero_spb_ci, organization_ratings_improvements, organization_ratings_link_to_profile_stable-spb-1.3, organization_ratings_translations_fix, profile_api_improvements, ratings_minor_fixes, remote_user_fix, send_email_to_admins, stable-spb-1.3, stable-spb-1.3-fixes, stable-spb-1.4, stable-spb-1.5, suggest_rejected_value, web_steps_improvements, xss_terminate_custom_options

Fixing ApproveArticle rejection message 

  * Showing the name of the article
  * Returning message even without rejection explanation
Showing 2 changed files with 11 additions and 1 deletions   Show diff stats
app/models/approve_article.rb
  Diff comments   View file @9948587
@@ -116,10 +116,11 @@ class ApproveArticle < Task @@ -116,10 +116,11 @@ class ApproveArticle < Task
116 end 116 end
117 117
118 def task_cancelled_message 118 def task_cancelled_message
119 - message = _('Your request for publishing the article "{article}" was rejected.') 119 + message = _('Your request for publishing the article "%{article}" was rejected.') % {:article => name}
120 if !reject_explanation.blank? 120 if !reject_explanation.blank?
121 message += " " + _("Here is the reject explanation left by the administrator who rejected your article: \n\n%{reject_explanation}") % {:reject_explanation => reject_explanation} 121 message += " " + _("Here is the reject explanation left by the administrator who rejected your article: \n\n%{reject_explanation}") % {:reject_explanation => reject_explanation}
122 end 122 end
  123 + message
123 end 124 end
124 125
125 end 126 end
test/unit/approve_article_test.rb
  Diff comments   View file @9948587
@@ -413,5 +413,14 @@ class ApproveArticleTest < ActiveSupport::TestCase @@ -413,5 +413,14 @@ class ApproveArticleTest < ActiveSupport::TestCase
413 end 413 end
414 end 414 end
415 415
  416 + should 'return reject message even without reject explanation' do
  417 + task = ApproveArticle.new(:name => 'My Article')
  418 + assert_not_nil task.task_cancelled_message
  419 + end
  420 +
  421 + should 'show the name of the article in the reject message' do
  422 + task = ApproveArticle.new(:name => 'My Article')
  423 + assert_match /My Article/, task.task_cancelled_message
  424 + end
416 425
417 end 426 end