Adding (real) authors to articles

Rodrigo Souto
1 parent 3d858878
Showing 9 changed files with 79 additions and 26 deletions Show diff stats
app/controllers/my_profile/cms_controller.rb
app/models/article.rb
app/models/person.rb
db/migrate/20121024220349_add_author_id_to_article.rb
db/migrate/20121024222938_set_authors_based_on_article_versions.rb
db/schema.rb
test/functional/cms_controller_test.rb
test/unit/article_test.rb
test/unit/person_test.rb
@@ -119,6 +119,7 @@ class CmsController &lt; MyProfileController
     translations if @article.translatable?
     @article.profile = profile
+    @article.author = user
     @article.last_changed_by = user
     continue = params[:continue]
@@ -13,6 +13,12 @@ class Article &lt; ActiveRecord::Base
   # xss_terminate plugin can't sanitize array fields
   before_save :sanitize_tag_list
+  before_save do |article|
+    if article.author_id
+      article.author_name = Person.find(article.author_id).name
+    end
+  end
+
   belongs_to :profile
   validates_presence_of :profile_id, :name
   validates_presence_of :slug, :path, :if => lambda { |article| !article.name.blank? }
@@ -20,6 +26,7 @@ class Article &lt; ActiveRecord::Base
   validates_uniqueness_of :slug, :scope => ['profile_id', 'parent_id'], :message => N_('The title (article name) is already being used by another article, please use another title.'), :if => lambda { |article| !article.slug.blank? }
   belongs_to :last_changed_by, :class_name => 'Person', :foreign_key => 'last_changed_by_id'
+  belongs_to :author, :class_name => 'Person', :foreign_key => 'author_id'
   has_many :comments, :class_name => 'Comment', :foreign_key => 'source_id', :dependent => :destroy, :order => 'created_at asc'
@@ -278,7 +285,7 @@ class Article &lt; ActiveRecord::Base
     if last_comment
       {:date => last_comment.created_at, :author_name => last_comment.author_name, :author_url => last_comment.author_url}
     else
-      {:date => updated_at, :author_name => author.name, :author_url => author.url}
+      {:date => updated_at, :author_name => author_name, :author_url => author ? author.url : nil}
     end
   end
@@ -430,7 +437,7 @@ class Article &lt; ActiveRecord::Base
   end
   def allow_post_content?(user = nil)
-    user && (user.has_permission?('post_content', profile) || allow_publish_content?(user) && (user == self.creator))
+    user && (user.has_permission?('post_content', profile) || allow_publish_content?(user) && (user == author))
   end
   def allow_publish_content?(user = nil)
@@ -527,16 +534,8 @@ class Article &lt; ActiveRecord::Base
     false
   end
-  def author
-    if reference_article
-      reference_article.author
-    else
-      last_changed_by || profile
-    end
-  end
-
   def author_name
-    setting[:author_name].blank? ? author.name : setting[:author_name]
+    author ? author.name : setting[:author_name]
   end
   alias :active_record_cache_key :cache_key
@@ -561,11 +560,6 @@ class Article &lt; ActiveRecord::Base
     truncate sanitize_html(self.lead), :length => 170, :omission => '...'
   end
-  def creator
-    creator_id = versions[0][:last_changed_by_id]
-    creator_id && Profile.find(creator_id)
-  end
-
   def notifiable?
     false
   end
@@ -54,6 +54,8 @@ class Person &lt; Profile
   has_many :scraps_sent, :class_name => 'Scrap', :foreign_key => :sender_id, :dependent => :destroy
+  has_many :creations, :class_name => 'Article', :foreign_key => :author_id
+
   named_scope :more_popular,
       :select => "#{Profile.qualified_column_names}, count(friend_id) as total",
       :group => Profile.qualified_column_names,
@@ -0,0 +1,11 @@
+class AddAuthorIdToArticle < ActiveRecord::Migration
+  def self.up
+    add_column :articles, :author_id, :integer
+    add_column :article_versions, :author_id, :integer
+  end
+
+  def self.down
+    remove_column :articles, :author_id
+    remove_column :article_versions, :author_id, :integer
+  end
+end
@@ -0,0 +1,9 @@
+class SetAuthorsBasedOnArticleVersions < ActiveRecord::Migration
+  def self.up
+    update('UPDATE articles SET author_id = (SELECT profiles.id FROM articles as a INNER JOIN article_versions ON a.id = article_versions.article_id INNER JOIN profiles ON profiles.id = article_versions.last_changed_by_id WHERE article_versions.version = 1 AND articles.id = a.id)')
+  end
+
+  def self.down
+    say "Can not be revesed!"
+  end
+end
@@ -9,7 +9,7 @@
 #
 # It's strongly recommended to check this file into your version control system.
-ActiveRecord::Schema.define(:version => 20120825185219) do
+ActiveRecord::Schema.define(:version => 20121024222938) do
   create_table "abuse_reports", :force => true do |t|
     t.integer  "reporter_id"
@@ -86,6 +86,7 @@ ActiveRecord::Schema.define(:version =&gt; 20120825185219) do
     t.string   "language"
     t.string   "source_name"
     t.integer  "license_id"
+    t.integer  "author_id"
   end
   create_table "articles", :force => true do |t|
@@ -127,6 +128,7 @@ ActiveRecord::Schema.define(:version =&gt; 20120825185219) do
     t.string   "language"
     t.string   "source_name"
     t.integer  "license_id"
+    t.integer  "author_id"
   end
   add_index "articles", ["translation_of_id"], :name => "index_articles_on_translation_of_id"
@@ -1556,6 +1556,16 @@ class CmsControllerTest &lt; ActionController::TestCase
     assert_equal license, article.license
   end
+  should 'set author when creating article' do
+    login_as(profile.identifier)
+
+    post :new, :type => 'TinyMceArticle', :profile => profile.identifier, :article => { :name => 'Sample Article', :body => 'content ...' }
+
+    a = profile.articles.find_by_path('sample-article')
+    assert_not_nil a
+    assert_equal profile, a.author
+  end
+
   protected
   # FIXME this is to avoid adding an extra dependency for a proper JSON parser.
@@ -708,14 +708,6 @@ class ArticleTest &lt; ActiveSupport::TestCase
     assert_equal a.url, a.view_url
   end
-  should 'know its author' do
-    assert_equal profile, Article.new(:last_changed_by => profile).author
-  end
-
-  should 'use owning profile as author when we dont know who did the last change' do
-    assert_equal profile, Article.new(:last_changed_by => nil, :profile => profile).author
-  end
-
   should 'have published_at' do
     assert_respond_to Article.new, :published_at
   end
@@ -1372,7 +1364,7 @@ class ArticleTest &lt; ActiveSupport::TestCase
     assert Article.method_defined?('author_name')
   end
-  should "the author_name returns the name od the article's author" do
+  should "the author_name returns the name of the article's author" do
     author = mock()
     author.expects(:name).returns('author name')
     a = Article.new
@@ -1782,4 +1774,25 @@ class ArticleTest &lt; ActiveSupport::TestCase
     assert_equal license, article.license
   end
+  should 'be able to have an author' do
+    author = fast_create(Person)
+    article = Article.new
+    assert_nothing_raised do
+      article.author = author
+    end
+  end
+
+  should 'set author_name before saving article if there is an author' do
+    author = fast_create(Person)
+    article = fast_create(Article, :profile_id => fast_create(Profile).id)
+    article.author = author
+    article.save!
+    assert_equal author.name, article.author_name
+
+    author_name = author.name
+    author.destroy
+    article.reload
+    assert_equal author_name, article.author_name
+  end
+
 end
@@ -1262,4 +1262,15 @@ class PersonTest &lt; ActiveSupport::TestCase
     assert person.has_permission?('bli', Profile.new)
   end
+
+  should 'have creations' do
+    person = create_user('some-user').person
+    a1 = fast_create(Article, :author_id => person.id)
+    a2 = fast_create(Article, :author_id => person.id)
+    a3 = fast_create(Article)
+
+    assert_includes person.creations, a1
+    assert_includes person.creations, a2
+    assert_not_includes person.creations, a3
+  end
 end
	@@ -119,6 +119,7 @@ class CmsController < MyProfileController		@@ -119,6 +119,7 @@ class CmsController < MyProfileController
119	translations if @article.translatable?	119	translations if @article.translatable?
120		120
121	@article.profile = profile	121	@article.profile = profile
		122	+ @article.author = user
122	@article.last_changed_by = user	123	@article.last_changed_by = user
123		124
124	continue = params[:continue]	125	continue = params[:continue]
	@@ -54,6 +54,8 @@ class Person < Profile		@@ -54,6 +54,8 @@ class Person < Profile
54		54
55	has_many :scraps_sent, :class_name => 'Scrap', :foreign_key => :sender_id, :dependent => :destroy	55	has_many :scraps_sent, :class_name => 'Scrap', :foreign_key => :sender_id, :dependent => :destroy
56		56
		57	+ has_many :creations, :class_name => 'Article', :foreign_key => :author_id
		58	+
57	named_scope :more_popular,	59	named_scope :more_popular,
58	:select => "#{Profile.qualified_column_names}, count(friend_id) as total",	60	:select => "#{Profile.qualified_column_names}, count(friend_id) as total",
59	:group => Profile.qualified_column_names,	61	:group => Profile.qualified_column_names,
@@ -0,0 +1,11 @@		@@ -0,0 +1,11 @@
	1	+class AddAuthorIdToArticle < ActiveRecord::Migration
	2	+ def self.up
	3	+ add_column :articles, :author_id, :integer
	4	+ add_column :article_versions, :author_id, :integer
	5	+ end
	6	+
	7	+ def self.down
	8	+ remove_column :articles, :author_id
	9	+ remove_column :article_versions, :author_id, :integer
	10	+ end
	11	+end
@@ -0,0 +1,9 @@		@@ -0,0 +1,9 @@
	1	+class SetAuthorsBasedOnArticleVersions < ActiveRecord::Migration
	2	+ def self.up
	3	+ update('UPDATE articles SET author_id = (SELECT profiles.id FROM articles as a INNER JOIN article_versions ON a.id = article_versions.article_id INNER JOIN profiles ON profiles.id = article_versions.last_changed_by_id WHERE article_versions.version = 1 AND articles.id = a.id)')
	4	+ end
	5	+
	6	+ def self.down
	7	+ say "Can not be revesed!"
	8	+ end
	9	+end
	@@ -1556,6 +1556,16 @@ class CmsControllerTest < ActionController::TestCase		@@ -1556,6 +1556,16 @@ class CmsControllerTest < ActionController::TestCase
1556	assert_equal license, article.license	1556	assert_equal license, article.license
1557	end	1557	end
1558		1558
		1559	+ should 'set author when creating article' do
		1560	+ login_as(profile.identifier)
		1561	+
		1562	+ post :new, :type => 'TinyMceArticle', :profile => profile.identifier, :article => { :name => 'Sample Article', :body => 'content ...' }
		1563	+
		1564	+ a = profile.articles.find_by_path('sample-article')
		1565	+ assert_not_nil a
		1566	+ assert_equal profile, a.author
		1567	+ end
		1568	+
1559	protected	1569	protected
1560		1570
1561	# FIXME this is to avoid adding an extra dependency for a proper JSON parser.	1571	# FIXME this is to avoid adding an extra dependency for a proper JSON parser.
	@@ -1262,4 +1262,15 @@ class PersonTest < ActiveSupport::TestCase		@@ -1262,4 +1262,15 @@ class PersonTest < ActiveSupport::TestCase
1262		1262
1263	assert person.has_permission?('bli', Profile.new)	1263	assert person.has_permission?('bli', Profile.new)
1264	end	1264	end
		1265	+
		1266	+ should 'have creations' do
		1267	+ person = create_user('some-user').person
		1268	+ a1 = fast_create(Article, :author_id => person.id)
		1269	+ a2 = fast_create(Article, :author_id => person.id)
		1270	+ a3 = fast_create(Article)
		1271	+
		1272	+ assert_includes person.creations, a1
		1273	+ assert_includes person.creations, a2
		1274	+ assert_not_includes person.creations, a3
		1275	+ end
1265	end	1276	end