Download as
Browse Code »

Commit 9a2bbd09154179bab2a04099216d783e87e41d78

Authored by Daniela Feitosa
1 parent 3d461d73
Exists in master and in 29 other branches add_member_task_reject_details, admin_visible_profile, article-list-template, community_notifications, contact_admin_translation, event_fixes, fix_comments_pagination, fix_rails4_organization_ratings, fix_sign_up_form, follow_step_fix, forum_topic_creation, mirror_block_improvements, multi_env_on_remote_user, new_security, noosfero_spb_ci, organization_ratings_improvements, organization_ratings_link_to_profile_stable-spb-1.3, organization_ratings_translations_fix, profile_api_improvements, ratings_minor_fixes, remote_user_fix, send_email_to_admins, stable-spb-1.3, stable-spb-1.3-fixes, stable-spb-1.4, stable-spb-1.5, suggest_rejected_value, web_steps_improvements, xss_terminate_custom_options

Returning 0 on price_description_percentage when price is 0 

(ActionItem2273)
Showing 2 changed files with 23 additions and 0 deletions   Show diff stats
app/models/product.rb
  Diff comments   View file @9a2bbd0
@@ -196,6 +196,7 @@ class Product < ActiveRecord::Base @@ -196,6 +196,7 @@ class Product < ActiveRecord::Base
196 end 196 end
197 197
198 def price_description_percentage 198 def price_description_percentage
  199 + return 0 if price.blank? || price.zero?
199 total_production_cost * 100 / price 200 total_production_cost * 100 / price
200 end 201 end
201 202
test/unit/product_test.rb
  Diff comments   View file @9a2bbd0
@@ -510,4 +510,26 @@ class ProductTest < Test::Unit::TestCase @@ -510,4 +510,26 @@ class ProductTest < Test::Unit::TestCase
510 assert_equal "50.00", product.formatted_value(:inputs_cost) 510 assert_equal "50.00", product.formatted_value(:inputs_cost)
511 end 511 end
512 512
  513 + should 'return 0 on price_description_percentage by default' do
  514 + assert_equal 0, Product.new.price_description_percentage
  515 + end
  516 +
  517 + should 'return 0 on price_description_percentage if price is 0' do
  518 + product = fast_create(Product, :price => 0)
  519 +
  520 + assert_equal 0, product.price_description_percentage
  521 + end
  522 +
  523 + should 'return 0 on price_description_percentage if price is not defined' do
  524 + product = fast_create(Product)
  525 +
  526 + assert_equal 0, product.price_description_percentage
  527 + end
  528 +
  529 + should 'return 0 on price_description_percentage if total_production_cost is 0' do
  530 + product = fast_create(Product, :price => 50)
  531 +
  532 + assert_equal 0, product.price_description_percentage
  533 + end
  534 +
513 end 535 end