adding pagination for article's comments

Leandro Nunes dos Santos
1 parent 8748da0c
Showing 5 changed files with 32 additions and 51 deletions Show diff stats
app/controllers/public/content_viewer_controller.rb
app/models/comment.rb
app/views/content_viewer/view_page.rhtml
test/functional/content_viewer_controller_test.rb
test/unit/comment_test.rb
@@ -99,9 +99,7 @@ class ContentViewerController &lt; ApplicationController
       end
     end
-    comments = @page.comments.without_spam
-    @comments = comments.as_thread
-    @comments_count = comments.count
+    @comments = @page.comments.without_spam.without_reply.paginate(:per_page => per_page, :page => params[:comment_page] )
     if params[:slideshow]
       render :action => 'slideshow', :layout => 'slideshow'
     end
@@ -17,6 +17,7 @@ class Comment &lt; ActiveRecord::Base
   belongs_to :reply_of, :class_name => 'Comment', :foreign_key => 'reply_of_id'
   named_scope :without_spam, :conditions => ['spam IS NULL OR spam = ?', false]
+  named_scope :without_reply, :conditions => ['reply_of_id IS NULL']
   named_scope :spam, :conditions => ['spam = ?', true]
   # unauthenticated authors:
@@ -152,21 +153,6 @@ class Comment &lt; ActiveRecord::Base
     @replies = comments_list
   end
-  def self.as_thread
-    result = {}
-    root = []
-    order(:id).each do |c|
-      c.replies = []
-      result[c.id] ||= c
-      if result[c.reply_of_id]
-        result[c.reply_of_id].replies << c
-      else
-        root << c
-      end
-    end
-    root
-  end
-
   include ApplicationHelper
   def reported_version(options = {})
     comment = self
@@ -88,18 +88,19 @@
 <div class="comments" id="comments_list">
-  <% if @page.accept_comments? || @comments_count > 0 %>
-    <h3 <%= 'class="no-comments-yet"' if @comments_count == 0 %>>
+  <% if @page.accept_comments? || @comments.count > 0 %>
+    <h3 <%= 'class="no-comments-yet"' if @comments.count == 0 %>>
       <%= number_of_comments(@page) %>
     </h3>
   <% end %>
-  <% if @page.accept_comments? && @comments_count > 1 %>
+  <% if @page.accept_comments? && @comments.count > 1 %>
     <%= link_to(_('Post a comment'), '#', :class => 'display-comment-form', :id => 'top-post-comment-button', :onclick => "jQuery('#page-comment-form .display-comment-form').first().click();") %>
   <% end %>
   <ul class="article-comments-list">
     <%= render :partial => 'comment/comment', :collection => @comments %>
+    <%= pagination_links @comments, :param_name => 'comment_page' %>
   </ul>
   <% if @page.accept_comments? %>
@@ -1084,13 +1084,13 @@ class ContentViewerControllerTest &lt; ActionController::TestCase
     article.save!
     comment1 = article.comments.build(:author => profile, :title => 'hi', :body => 'hello')
     comment1.save!
-    comment2 = article.comments.build(:author => profile, :title => 'hi', :body => 'hello', :reply_of_id => comment1.id)
+    comment2 = article.comments.build(:author => profile, :title => 'hi', :body => 'hello')
     comment2.save!
     get :view_page, :profile => 'testuser', :page => [ 'test' ]
     assert_tag :tag => 'a', :attributes => { :id => 'top-post-comment-button' }
   end
-  should 'store number of comments' do
+  should 'not show a post comment button on top if there are one comment and one reply' do
     profile = create_user('testuser').person
     article = profile.articles.build(:name => 'test')
     article.save!
@@ -1099,7 +1099,7 @@ class ContentViewerControllerTest &lt; ActionController::TestCase
     comment2 = article.comments.build(:author => profile, :title => 'hi', :body => 'hello', :reply_of_id => comment1.id)
     comment2.save!
     get :view_page, :profile => 'testuser', :page => [ 'test' ]
-    assert_equal 2, assigns(:comments_count)
+    assert_no_tag :tag => 'a', :attributes => { :id => 'top-post-comment-button' }
   end
   should 'suggest article link displayed into article-actions div' do
@@ -1178,11 +1178,22 @@ class ContentViewerControllerTest &lt; ActionController::TestCase
   should 'not display comments marked as spam' do
     article = fast_create(Article, :profile_id => profile.id)
-    ham = fast_create(Comment, :source_id => article.id, :source_type => 'Article')
-    spam = fast_create(Comment, :source_id => article.id, :source_type => 'Article', :spam => true)
+    ham = fast_create(Comment, :source_id => article.id, :source_type => 'Article', :title => 'some content')
+    spam = fast_create(Comment, :source_id => article.id, :source_type => 'Article', :spam => true, :title => 'this is a spam')
     get 'view_page', :profile => profile.identifier, :page => article.path.split('/')
-    assert_equal 1, assigns(:comments_count)
+    assert_no_tag :tag => 'h4', :content => /spam/
   end
+  should 'display pagination links of comments' do
+    article = fast_create(Article, :profile_id => profile.id)
+    for n in 1..15
+      article.comments.create!(:author => profile, :title => "some title #{n}", :body => 'some body #{n}')
+    end
+    assert_equal 15, article.comments.count
+
+    get 'view_page', :profile => profile.identifier, :page => article.path.split('/')
+    assert_tag :tag => 'a', :attributes => { :href => "/#{profile.identifier}/#{article.path}?comment_page=2", :rel => 'next' }
+  end 
+
 end
@@ -285,21 +285,6 @@ class CommentTest &lt; ActiveSupport::TestCase
     assert_equal [c1,c3], c.reload.children
   end
-  should "return comments as a thread" do
-    a = fast_create(Article)
-    c0 = fast_create(Comment, :source_id => a.id)
-    c1 = fast_create(Comment, :reply_of_id => c0.id, :source_id => a.id)
-    c2 = fast_create(Comment, :reply_of_id => c1.id, :source_id => a.id)
-    c3 = fast_create(Comment, :reply_of_id => c0.id, :source_id => a.id)
-    c4 = fast_create(Comment, :source_id => a.id)
-    result = a.comments.as_thread
-    assert_equal c0.id, result[0].id
-    assert_equal [c1.id, c3.id], result[0].replies.map(&:id)
-    assert_equal [c2.id], result[0].replies[0].replies.map(&:id)
-    assert_equal c4.id, result[1].id
-    assert result[1].replies.empty?
-  end
-
   should "return activities comments as a thread" do
     person = fast_create(Person)
     a = TextileArticle.create!(:profile => person, :name => 'My article', :body => 'Article body')
@@ -515,15 +500,6 @@ class CommentTest &lt; ActiveSupport::TestCase
     assert_equal c, SpamNotification.marked_as_ham
   end
-  should 'ignore spam when constructing threads' do
-    original = create_comment
-    response = create_comment(:reply_of_id => original.id)
-    original.spam!
-
-    assert_equivalent [response], Comment.without_spam.as_thread
-  end
-
-
   should 'store User-Agent' do
     c = Comment.new(:user_agent => 'foo')
     assert_equal 'foo', c.user_agent
@@ -700,6 +676,15 @@ class CommentTest &lt; ActiveSupport::TestCase
     assert_equal c1, c1.comment_root
   end
+  should 'be able to select non-reply comments' do
+    c1 = fast_create(Comment)
+    c2 = fast_create(Comment, :reply_of_id => c1.id)
+    c3 = fast_create(Comment, :reply_of_id => c2.id)
+    c4 = fast_create(Comment)
+
+    assert_equivalent [c1,c4], Comment.without_reply
+  end
+
   private
   def create_comment(args = {})
	@@ -17,6 +17,7 @@ class Comment < ActiveRecord::Base		@@ -17,6 +17,7 @@ class Comment < ActiveRecord::Base
17	belongs_to :reply_of, :class_name => 'Comment', :foreign_key => 'reply_of_id'	17	belongs_to :reply_of, :class_name => 'Comment', :foreign_key => 'reply_of_id'
18		18
19	named_scope :without_spam, :conditions => ['spam IS NULL OR spam = ?', false]	19	named_scope :without_spam, :conditions => ['spam IS NULL OR spam = ?', false]
		20	+ named_scope :without_reply, :conditions => ['reply_of_id IS NULL']
20	named_scope :spam, :conditions => ['spam = ?', true]	21	named_scope :spam, :conditions => ['spam = ?', true]
21		22
22	# unauthenticated authors:	23	# unauthenticated authors:
	@@ -152,21 +153,6 @@ class Comment < ActiveRecord::Base		@@ -152,21 +153,6 @@ class Comment < ActiveRecord::Base
152	@replies = comments_list	153	@replies = comments_list
153	end	154	end
154		155
155	- def self.as_thread
156	- result = {}
157	- root = []
158	- order(:id).each do \|c\|
159	- c.replies = []
160	- result[c.id] \|\|= c
161	- if result[c.reply_of_id]
162	- result[c.reply_of_id].replies << c
163	- else
164	- root << c
165	- end
166	- end
167	- root
168	- end
169	-
170	include ApplicationHelper	156	include ApplicationHelper
171	def reported_version(options = {})	157	def reported_version(options = {})
172	comment = self	158	comment = self