[Mezuro] New validations for readings.

Daniel Alves + Diego Araújo + Guilherme Rojas · Paulo Meireles
1 parent 09f2a25b
Showing 4 changed files with 45 additions and 1 deletions Show diff stats
plugins/mezuro/controllers/myprofile/mezuro_plugin_reading_controller.rb
plugins/mezuro/public/javascripts/validations.js
plugins/mezuro/test/functional/myprofile/mezuro_plugin_reading_controller_test.rb
plugins/mezuro/views/mezuro_plugin_reading/_form.html.erb
@@ -4,6 +4,10 @@ class MezuroPluginReadingController &lt; MezuroPluginMyprofileController
   def new
     @reading_group_content = profile.articles.find(params[:id])
+    
+    readings = Kalibro::Reading.readings_of @reading_group_content.reading_group_id
+    @parser="|*|"
+    @labels_and_grades = readings.map {|reading| "#{reading.label}#{@parser}#{reading.grade}#{@parser}"}
   end
   def save
@@ -20,6 +24,15 @@ class MezuroPluginReadingController &lt; MezuroPluginMyprofileController
   def edit
     @reading_group_content = profile.articles.find(params[:id])
     @reading = Kalibro::Reading.find params[:reading_id]
+    
+    readings = Kalibro::Reading.readings_of @reading_group_content.reading_group_id
+    readings = readings.select {|reading| (reading.id != @reading.id)}
+    @parser="|*|"
+    @labels_and_grades = readings.map do |reading| 
+      if(reading.id != @reading.id) 
+        "#{reading.label}#{@parser}#{reading.grade}#{@parser}" 
+      end
+    end
   end
   def destroy
@@ -32,5 +45,4 @@ class MezuroPluginReadingController &lt; MezuroPluginMyprofileController
       redirect_to_error_page reading.errors[0].message
     end
   end
-
 end
@@ -24,10 +24,30 @@ function validate_new_reading() {
   var name = jQuery('#reading_label').val();
   var grade = jQuery('#reading_grade').val();
   var color = jQuery('#reading_color').val();
+
   if (is_null(name) || is_null(grade) || is_null(color)){
     alert("Please fill all fields marked with (*).");
     return false;
   }
+
+  var parser = jQuery('#labels_and_grades').attr('data-parser');
+  var labels_and_grades = jQuery('#labels_and_grades').attr('data-list').split(parser);
+  for (var id = 0; id < labels_and_grades.length; id = id + 2) {
+    if (labels_and_grades[id] == name) {
+      alert("This label already exists! Please, choose another one.");
+      return false;
+    } 
+    
+    if (labels_and_grades[id+1] == grade || labels_and_grades[id+1] == grade + ".0") {
+      alert("This grade already exists! Please, choose another one.");
+      return false;
+    }
+  }
+
+  if (!color.match(/^[a-fA-F0-9]{6}$/)) {
+      alert("This is not a valid color.");
+      return false;
+  } 
   return true;
 }
@@ -21,7 +21,11 @@ class MezuroPluginReadingControllerTest &lt; ActionController::TestCase
   end
   should 'set variables to create a new reading' do
+    parser = "|*|"    
+    Kalibro::Reading.expects(:readings_of).with(@content.reading_group_id).returns([@reading])
     get :new, :profile => @profile.identifier, :id => @content.id
+    assert_equal parser, assigns(:parser)
+    assert_equal ["#{@reading.label}#{parser}#{@reading.grade}#{parser}"], assigns(:labels_and_grades)
     assert_equal @content.id, assigns(:reading_group_content).id
     assert_response :success
   end
@@ -44,10 +48,16 @@ class MezuroPluginReadingControllerTest &lt; ActionController::TestCase
   end
   should 'set variables to edit a reading' do
+    parser = "|*|"    
+    another_reading = ReadingFixtures.reading
+    another_reading.id = 10
+    Kalibro::Reading.expects(:readings_of).with(@content.reading_group_id).returns([@reading, another_reading])
     Kalibro::Reading.expects(:find).with(@reading.id.to_s).returns(@reading)
     get :edit, :profile => @profile.identifier, :id => @content.id, :reading_id => @reading.id
     assert_equal @content.id, assigns(:reading_group_content).id
     assert_equal @reading, assigns(:reading)
+    assert_equal parser, assigns(:parser)
+    assert_equal ["#{another_reading.label}#{parser}#{another_reading.grade}#{parser}"], assigns(:labels_and_grades)
     assert_response :success
   end
@@ -8,4 +8,6 @@
 <%= required labelled_form_field _('Color:'),
 colorpicker_field(:reading, :color) %>Click in the field to change Color
+<div id="labels_and_grades" data-list="<%= @labels_and_grades %>" data-parser="<%= @parser %>"/>
+
 <p><%= f.submit "Save" %></p>
	@@ -24,10 +24,30 @@ function validate_new_reading() {		@@ -24,10 +24,30 @@ function validate_new_reading() {
24	var name = jQuery('#reading_label').val();	24	var name = jQuery('#reading_label').val();
25	var grade = jQuery('#reading_grade').val();	25	var grade = jQuery('#reading_grade').val();
26	var color = jQuery('#reading_color').val();	26	var color = jQuery('#reading_color').val();
		27	+
27	if (is_null(name) \|\| is_null(grade) \|\| is_null(color)){	28	if (is_null(name) \|\| is_null(grade) \|\| is_null(color)){
28	alert("Please fill all fields marked with (*).");	29	alert("Please fill all fields marked with (*).");
29	return false;	30	return false;
30	}	31	}
		32	+
		33	+ var parser = jQuery('#labels_and_grades').attr('data-parser');
		34	+ var labels_and_grades = jQuery('#labels_and_grades').attr('data-list').split(parser);
		35	+ for (var id = 0; id < labels_and_grades.length; id = id + 2) {
		36	+ if (labels_and_grades[id] == name) {
		37	+ alert("This label already exists! Please, choose another one.");
		38	+ return false;
		39	+ }
		40	+
		41	+ if (labels_and_grades[id+1] == grade \|\| labels_and_grades[id+1] == grade + ".0") {
		42	+ alert("This grade already exists! Please, choose another one.");
		43	+ return false;
		44	+ }
		45	+ }
		46	+
		47	+ if (!color.match(/^[a-fA-F0-9]{6}$/)) {
		48	+ alert("This is not a valid color.");
		49	+ return false;
		50	+ }
31	return true;	51	return true;
32	}	52	}
33		53
	@@ -8,4 +8,6 @@		@@ -8,4 +8,6 @@
8	<%= required labelled_form_field _('Color:'),	8	<%= required labelled_form_field _('Color:'),
9	colorpicker_field(:reading, :color) %>Click in the field to change Color	9	colorpicker_field(:reading, :color) %>Click in the field to change Color
10		10
		11	+<div id="labels_and_grades" data-list="<%= @labels_and_grades %>" data-parser="<%= @parser %>"/>
		12	+
11	<p><%= f.submit "Save" %></p>	13	<p><%= f.submit "Save" %></p>