Download as
Browse Code »

Commit 9e89e39ee200972acfa8387615b3c8ef050aacf7

Authored by Arthur Esposte
1 parent dc5507b5
Exists in master and in 29 other branches add_member_task_reject_details, admin_visible_profile, article-list-template, community_notifications, contact_admin_translation, event_fixes, fix_comments_pagination, fix_rails4_organization_ratings, fix_sign_up_form, follow_step_fix, forum_topic_creation, mirror_block_improvements, multi_env_on_remote_user, new_security, noosfero_spb_ci, organization_ratings_improvements, organization_ratings_link_to_profile_stable-spb-1.3, organization_ratings_translations_fix, profile_api_improvements, ratings_minor_fixes, remote_user_fix, send_email_to_admins, stable-spb-1.3, stable-spb-1.3-fixes, stable-spb-1.4, stable-spb-1.5, suggest_rejected_value, web_steps_improvements, xss_terminate_custom_options

Change remote user plugin to handle any exception

Showing 2 changed files with 11 additions and 3 deletions   Show diff stats
plugins/remote_user/lib/remote_user_plugin.rb
  Diff comments   View file @9e89e39
@@ -48,7 +48,7 @@ class RemoteUserPlugin < Noosfero::Plugin @@ -48,7 +48,7 @@ class RemoteUserPlugin < Noosfero::Plugin
48 end 48 end
49 end 49 end
50 end 50 end
51 - rescue ActiveRecord::RecordInvalid => invalid 51 + rescue
52 session[:notice] = _('Could not create the remote_user.') 52 session[:notice] = _('Could not create the remote_user.')
53 render_404 53 render_404
54 end 54 end
plugins/remote_user/test/functional/remote_user_plugin_test.rb
  Diff comments   View file @9e89e39
@@ -3,7 +3,7 @@ require File.dirname(__FILE__) + '/../../../../test/test_helper' @@ -3,7 +3,7 @@ require File.dirname(__FILE__) + '/../../../../test/test_helper'
3 # Re-raise errors caught by the controller. 3 # Re-raise errors caught by the controller.
4 class AccountController; def rescue_action(e) raise e end; end 4 class AccountController; def rescue_action(e) raise e end; end
5 5
6 -class AccountControllerTest < ActionController::TestCase 6 +class AccountControllerTest < ActionController::TestCase
7 def setup 7 def setup
8 @environment = Environment.default 8 @environment = Environment.default
9 @environment.enabled_plugins = ['RemoteUserPlugin'] 9 @environment.enabled_plugins = ['RemoteUserPlugin']
@@ -125,10 +125,18 @@ class AccountControllerTest &lt; ActionController::TestCase @@ -125,10 +125,18 @@ class AccountControllerTest &lt; ActionController::TestCase
125 get :index 125 get :index
126 126
127 assert session[:user].blank? 127 assert session[:user].blank?
128 - 128 +
129 @request.env["HTTP_REMOTE_USER"] = "" 129 @request.env["HTTP_REMOTE_USER"] = ""
130 get :index 130 get :index
131 131
132 assert session[:user].blank? 132 assert session[:user].blank?
133 end 133 end
  134 +
  135 + should 'not create a new user if his informations is invalid' do
  136 + @request.env["HTTP_REMOTE_USER"] = "*%&invalid user name&%*"
  137 + get :index
  138 +
  139 + assert session[:user].blank?
  140 + assert_response 404
  141 + end
134 end 142 end