Making tests pass

Antonio Terceiro
1 parent 34f936c8
Showing 4 changed files with 20 additions and 17 deletions Show diff stats
app/helpers/application_helper.rb
test/functional/doc_controller_test.rb
test/unit/application_helper_test.rb
test/unit/doc_section_test.rb
@@ -362,6 +362,7 @@ module ApplicationHelper
         return render :file => file, :use_full_path => false
       end
     end
+    nil
   end
   def theme_header
@@ -23,20 +23,20 @@ class DocControllerTest &lt; ActionController::TestCase
   end
   should 'translate section' do
-    get :section, :section => 'admin'
+    get :section, :section => 'user'
     assert_equal 'en', assigns(:section).language
     @controller.stubs(:language).returns('pt')
-    get :section, :section => 'admin'
+    get :section, :section => 'user'
     assert_equal 'pt', assigns(:section).language
   end
   should 'translate topic' do
-    get :topic, :section => 'admin', :topic => '100-email'
+    get :topic, :section => 'user', :topic => 'accepting-friends'
     assert_equal 'en', assigns(:topic).language
     @controller.stubs(:language).returns('pt')
-    get :topic, :section => 'admin', :topic => '100-email'
+    get :topic, :section => 'user', :topic => 'accepting-friends'
     assert_equal 'pt', assigns(:topic).language
   end
@@ -170,8 +170,10 @@ class ApplicationHelperTest &lt; Test::Unit::TestCase
   should 'ignore unexisting theme footer' do
     stubs(:theme_path).returns('/user_themes/mytheme')
     footer_path = RAILS_ROOT + '/public/user_themes/mytheme/footer.rhtml'
+    alternate_footer_path = RAILS_ROOT + '/public/user_themes/mytheme/footer.html.erb'
     File.expects(:exists?).with(footer_path).returns(false)
+    File.expects(:exists?).with(alternate_footer_path).returns(false)
     expects(:render).with(:file => footer).never
     assert_nil theme_footer
@@ -21,7 +21,7 @@ class DocSectionTest &lt; ActiveSupport::TestCase
   should 'list available sections' do
     sections = DocSection.all
     assert(sections.size > 0, 'should load sections ')
-    assert(sections.find { |item| item.title == 'Administration'}, 'should find section "Administration"')
+    assert(sections.find { |item| item.title == 'Content Management'}, 'should find section "Content Management"')
     assert(sections.find { |item| item.title == 'User features'}, 'should find section "User features"')
   end
@@ -30,7 +30,7 @@ class DocSectionTest &lt; ActiveSupport::TestCase
   # break. If those translations change, this test will also break.
   should 'list section for a given language' do
     sections = DocSection.all('pt')
-    assert(sections.find { |item| item.title == 'Administração'}, 'should find section "Administration" translated')
+    assert(sections.find { |item| item.title == 'Gerenciamento de conteúdo'}, 'should find section "Content Management" translated')
     assert(sections.find { |item| item.title == 'Funcionalidades de Usuário'}, 'should find section "User features" translated')
   end
@@ -46,28 +46,28 @@ class DocSectionTest &lt; ActiveSupport::TestCase
   # This test also depends on the existance of specific documentation sections.
   # The same conditions as the above tests apply.
   should 'list items' do
-    section = DocSection.all.find {|item| item.title == 'Administration' }
+    section = DocSection.all.find {|item| item.title == 'Content Management' }
     assert section.items.size > 0, "should load at least one item"
-    assert section.items.find {|item| item.title == 'E-mail settings' && item.text =~ /<h1>E-mail settings/ }, 'should find "E-mail settings" topic'
-    assert section.items.find {|item| item.title == 'Managing user roles' && item.text =~ /<h1>Managing/ }, 'should find "Managing user roles" topic'
+    assert section.items.find {|item| item.title == 'Adding pictures to gallery' && item.text =~ /<h1>Adding pictures to gallery/ }, 'should find "Adding pictures to gallery" topic'
+    assert section.items.find {|item| item.title == 'Creating a blog' && item.text =~ /<h1>Creating a blog/ }, 'should find "Creating a blog" topic'
   end
   # This test assumes ... (yada, yada, yada, the same as above)
   should 'load translated items' do
-    section = DocSection.all('pt').find {|item| item.title == 'Administração' }
+    section = DocSection.all('pt').find {|item| item.title == 'Gerenciamento de conteúdo' }
     assert section.items.size > 0, "should load at least one item"
-    assert section.items.find {|item| item.title == 'Configurações de e-mail' && item.text =~ /<h1>Configurações/ }, 'should find translated "E-mail settings" topic'
-    assert section.items.find {|item| item.title == 'Gerenciando papéis de usuários' && item.text =~ /<h1>Gerenciando/ }, 'should find translated "Managing user roles" topic'
+    assert section.items.find {|item| item.title == 'Adicionando fotos na galeria' && item.text =~ /<h1>Adicionando fotos na galeria/ }, 'should find translated "Adding pictures to gallery" topic'
+    assert section.items.find {|item| item.title == 'Criando um blog' && item.text =~ /<h1>Criando um blog/ }, 'should find translated "Creating a blog" topic'
   end
   # This test assumes that Klingon (tlh) is not supported. If Noosfero does get
   # aa Klingon translation, then this test will fail
   should 'fallback to load original items when translation is not available' do
-    section = DocSection.find('admin', 'tlh')
-    assert_equal 'Administration', section.title
+    section = DocSection.find('user', 'tlh')
+    assert_equal 'User features', section.title
-    topic = section.find('100-email')
-    assert_equal 'E-mail settings', topic.title
+    topic = section.find('accepting-friends')
+    assert_equal 'Accepting friends', topic.title
   end
   should 'find in items' do
@@ -80,8 +80,8 @@ class DocSectionTest &lt; ActiveSupport::TestCase
   end
   should 'be able to find section by its id' do
-    assert_equal "Administration", DocSection.find('admin').title
     assert_equal "User features", DocSection.find('user').title
+    assert_equal "Content Management", DocSection.find('cms').title
   end
   should 'load null section (the root)' do
	@@ -362,6 +362,7 @@ module ApplicationHelper		@@ -362,6 +362,7 @@ module ApplicationHelper
362	return render :file => file, :use_full_path => false	362	return render :file => file, :use_full_path => false
363	end	363	end
364	end	364	end
		365	+ nil
365	end	366	end
366		367
367	def theme_header	368	def theme_header
	@@ -23,20 +23,20 @@ class DocControllerTest < ActionController::TestCase		@@ -23,20 +23,20 @@ class DocControllerTest < ActionController::TestCase
23	end	23	end
24		24
25	should 'translate section' do	25	should 'translate section' do
26	- get :section, :section => 'admin'	26	+ get :section, :section => 'user'
27	assert_equal 'en', assigns(:section).language	27	assert_equal 'en', assigns(:section).language
28		28
29	@controller.stubs(:language).returns('pt')	29	@controller.stubs(:language).returns('pt')
30	- get :section, :section => 'admin'	30	+ get :section, :section => 'user'
31	assert_equal 'pt', assigns(:section).language	31	assert_equal 'pt', assigns(:section).language
32	end	32	end
33		33
34	should 'translate topic' do	34	should 'translate topic' do
35	- get :topic, :section => 'admin', :topic => '100-email'	35	+ get :topic, :section => 'user', :topic => 'accepting-friends'
36	assert_equal 'en', assigns(:topic).language	36	assert_equal 'en', assigns(:topic).language
37		37
38	@controller.stubs(:language).returns('pt')	38	@controller.stubs(:language).returns('pt')
39	- get :topic, :section => 'admin', :topic => '100-email'	39	+ get :topic, :section => 'user', :topic => 'accepting-friends'
40	assert_equal 'pt', assigns(:topic).language	40	assert_equal 'pt', assigns(:topic).language
41	end	41	end
42		42