Fixing tests that depended on the old layout

Antonio Terceiro
1 parent 6c22b7ef
Showing 6 changed files with 20 additions and 12 deletions Show diff stats
test/functional/application_controller_test.rb
test/functional/profile_editor_controller_test.rb
test/functional/search_controller_test.rb
test/integration/assets_menu_test.rb
test/integration/categories_menu_test.rb
test/integration/search_popup_test.rb
@@ -175,6 +175,7 @@ class ApplicationControllerTest &lt; Test::Unit::TestCase
   end
   should 'display only some categories in menu' do
+    @controller.stubs(:get_layout).returns('application')
     c1 = Environment.default.categories.create!(:name => 'Category 1', :display_color => 1, :parent => nil, :display_in_menu => true )
     c2 = Environment.default.categories.create!(:name => 'Category 2', :display_color => nil, :parent => c1, :display_in_menu => true )
     get :index
@@ -182,6 +183,7 @@ class ApplicationControllerTest &lt; Test::Unit::TestCase
   end
   should 'not display some categories in menu' do
+    @controller.stubs(:get_layout).returns('application')
     c1 = Environment.default.categories.create!(:name => 'Category 1', :display_color => 1, :parent_id => nil, :display_in_menu => true)
     c2 = Environment.default.categories.create!(:name => 'Category 2', :display_color => nil, :parent_id => c1)
     get :index
@@ -198,16 +200,8 @@ class ApplicationControllerTest &lt; Test::Unit::TestCase
     assert_tag :tag => 'option', :attributes => { :value => 'it' }, :content => 'Italiano'
   end
-  should 'display links for select language' do
-    Noosfero.expects(:locales).returns({ 'en' => 'English', 'pt_BR' => 'Português Brasileiro', 'fr' => 'Français', 'it' => 'Italiano' }).at_least_once
-    get :index, :lang => 'en'
-    assert_no_tag :tag => 'a', :attributes => { :href => /\?lang=en/ }, :content => 'English'
-    assert_tag :tag => 'a', :attributes => { :href => /\?lang=pt_BR/ }, :content => 'Português Brasileiro'
-    assert_tag :tag => 'a', :attributes => { :href => /\?lang=fr/ }, :content => 'Français'
-    assert_tag :tag => 'a', :attributes => { :href => /\?lang=it/ }, :content => 'Italiano'
-  end
-
   should 'display link to webmail if enabled for system and for user' do
+    @controller.stubs(:get_layout).returns('application')
     login_as('ze')
     MailConf.expects(:enabled?).returns(true)
     MailConf.expects(:webmail_url).returns('http://web.mail/')
@@ -218,6 +212,7 @@ class ApplicationControllerTest &lt; Test::Unit::TestCase
   end
   should 'not display link to webmail if not enabled for system' do
+    @controller.stubs(:get_layout).returns('application')
     login_as('ze')
     MailConf.expects(:enabled?).returns(false)
@@ -226,6 +221,7 @@ class ApplicationControllerTest &lt; Test::Unit::TestCase
   end
   should 'not display link in menu to webmail if not enabled for user' do
+    @controller.stubs(:get_layout).returns('application')
     login_as('ze')
     MailConf.expects(:enabled?).returns(true)
     User.any_instance.expects(:enable_email).returns(false)
@@ -389,6 +385,7 @@ class ApplicationControllerTest &lt; Test::Unit::TestCase
   end
   should 'display menu links for my environment when logged in other environment' do
+    @controller.stubs(:get_layout).returns('application')
     e = Environment.create!(:name => 'other_environment')
     e.domains << Domain.new(:name => 'other.environment')
     e.save!
@@ -410,10 +410,10 @@ class ProfileEditorControllerTest &lt; Test::Unit::TestCase
   end
   should 'not link to mailconf for organizations' do
-    MailConf.stubs(:enabled?).returns(true).at_least_once
+    MailConf.stubs(:enabled?).returns(true)
     org = fast_create(Organization)
     get :index, :profile => org.identifier
-    assert_no_tag :tag => 'a', :attributes => { :href => '/myprofile/testorg/mailconf' }
+    assert_no_tag :tag => 'a', :attributes => { :href => "/myprofile/#{org.identifier}/mailconf" }
   end
   should 'not link to mailconf if mail not enabled' do
@@ -981,7 +981,7 @@ class SearchControllerTest &lt; Test::Unit::TestCase
   should 'not display steps when searching not on wizard' do
     c1 = create_profile_with_optional_category(Community, 'a beautiful community')
     get :index, :query => 'beautiful', :find_in => [ 'communities' ]
-    assert_equal 'layouts/application', @response.layout
+    assert_match 'layouts/application', @response.layout
     assert_no_tag :tag => 'div', :attributes => {:id => 'wizard-steps'}
   end
@@ -3,6 +3,9 @@ require &quot;#{File.dirname(__FILE__)}/../test_helper&quot;
 class AssetsMenuTest < ActionController::IntegrationTest
   def setup
+    HomeController.any_instance.stubs(:get_layout).returns('application')
+    SearchController.any_instance.stubs(:get_layout).returns('application')
+
     parent = Category.create!(:name => "Parent Category", :environment => Environment.default, :display_color => 1)
     @category = Category.create!(:name => "Category A", :environment => Environment.default, :parent => parent)
   end
@@ -3,6 +3,9 @@ require &quot;#{File.dirname(__FILE__)}/../test_helper&quot;
 class CategoriesMenuTest < ActionController::IntegrationTest
   def setup
+    HomeController.any_instance.stubs(:get_layout).returns('application')
+    SearchController.any_instance.stubs(:get_layout).returns('application')
+
     Category.delete_all
     @cat1 = Category.create!(:display_in_menu => true, :name => 'Food', :environment => Environment.default, :display_color => 1)
     @cat2 = Category.create!(:display_in_menu => true, :name => 'Vegetables', :environment => Environment.default, :parent => @cat1)
@@ -2,6 +2,11 @@ require &quot;#{File.dirname(__FILE__)}/../test_helper&quot;
 class SearchPopupTest < ActionController::IntegrationTest
+  def setup
+    HomeController.any_instance.stubs(:get_layout).returns('application')
+    SearchController.any_instance.stubs(:get_layout).returns('application')
+  end
+
   should 'link to search without category when not inside a filter' do
     get '/'
     assert_tag :tag => 'a', :attributes => { :href => '/search/popup' }
	@@ -410,10 +410,10 @@ class ProfileEditorControllerTest < Test::Unit::TestCase		@@ -410,10 +410,10 @@ class ProfileEditorControllerTest < Test::Unit::TestCase
410	end	410	end
411		411
412	should 'not link to mailconf for organizations' do	412	should 'not link to mailconf for organizations' do
413	- MailConf.stubs(:enabled?).returns(true).at_least_once	413	+ MailConf.stubs(:enabled?).returns(true)
414	org = fast_create(Organization)	414	org = fast_create(Organization)
415	get :index, :profile => org.identifier	415	get :index, :profile => org.identifier
416	- assert_no_tag :tag => 'a', :attributes => { :href => '/myprofile/testorg/mailconf' }	416	+ assert_no_tag :tag => 'a', :attributes => { :href => "/myprofile/#{org.identifier}/mailconf" }
417	end	417	end
418		418
419	should 'not link to mailconf if mail not enabled' do	419	should 'not link to mailconf if mail not enabled' do
	@@ -981,7 +981,7 @@ class SearchControllerTest < Test::Unit::TestCase		@@ -981,7 +981,7 @@ class SearchControllerTest < Test::Unit::TestCase
981	should 'not display steps when searching not on wizard' do	981	should 'not display steps when searching not on wizard' do
982	c1 = create_profile_with_optional_category(Community, 'a beautiful community')	982	c1 = create_profile_with_optional_category(Community, 'a beautiful community')
983	get :index, :query => 'beautiful', :find_in => [ 'communities' ]	983	get :index, :query => 'beautiful', :find_in => [ 'communities' ]
984	- assert_equal 'layouts/application', @response.layout	984	+ assert_match 'layouts/application', @response.layout
985	assert_no_tag :tag => 'div', :attributes => {:id => 'wizard-steps'}	985	assert_no_tag :tag => 'div', :attributes => {:id => 'wizard-steps'}
986	end	986	end
987		987