Commit b18f899bfafd5516f4b960772b4c903ead58d4ad
1 parent
df124dae
Exists in
master
and in
29 other branches
Storing time when external feed was fetched as datetime instead of date
(ActionItem1643)
Showing
3 changed files
with
28 additions
and
2 deletions
Show diff stats
db/migrate/20100822034415_change_external_feed_fetched_at_column_type.rb
0 → 100644
@@ -0,0 +1,13 @@ | @@ -0,0 +1,13 @@ | ||
1 | +class ChangeExternalFeedFetchedAtColumnType < ActiveRecord::Migration | ||
2 | + def self.up | ||
3 | + change_table :external_feeds do |t| | ||
4 | + t.change :fetched_at, :datetime | ||
5 | + end | ||
6 | + end | ||
7 | + | ||
8 | + def self.down | ||
9 | + change_table :external_feeds do |t| | ||
10 | + t.change :fetched_at, :date | ||
11 | + end | ||
12 | + end | ||
13 | +end |
db/schema.rb
@@ -9,7 +9,7 @@ | @@ -9,7 +9,7 @@ | ||
9 | # | 9 | # |
10 | # It's strongly recommended to check this file into your version control system. | 10 | # It's strongly recommended to check this file into your version control system. |
11 | 11 | ||
12 | -ActiveRecord::Schema.define(:version => 20100730141134) do | 12 | +ActiveRecord::Schema.define(:version => 20100822034415) do |
13 | 13 | ||
14 | create_table "article_versions", :force => true do |t| | 14 | create_table "article_versions", :force => true do |t| |
15 | t.integer "article_id" | 15 | t.integer "article_id" |
@@ -190,7 +190,7 @@ ActiveRecord::Schema.define(:version => 20100730141134) do | @@ -190,7 +190,7 @@ ActiveRecord::Schema.define(:version => 20100730141134) do | ||
190 | 190 | ||
191 | create_table "external_feeds", :force => true do |t| | 191 | create_table "external_feeds", :force => true do |t| |
192 | t.string "feed_title" | 192 | t.string "feed_title" |
193 | - t.date "fetched_at" | 193 | + t.datetime "fetched_at" |
194 | t.string "address" | 194 | t.string "address" |
195 | t.integer "blog_id", :null => false | 195 | t.integer "blog_id", :null => false |
196 | t.boolean "enabled", :default => true, :null => false | 196 | t.boolean "enabled", :default => true, :null => false |
test/unit/external_feed_test.rb
@@ -128,4 +128,17 @@ class ExternalFeedTest < ActiveSupport::TestCase | @@ -128,4 +128,17 @@ class ExternalFeedTest < ActiveSupport::TestCase | ||
128 | assert_equal 0, ExternalFeed.new.update_errors | 128 | assert_equal 0, ExternalFeed.new.update_errors |
129 | end | 129 | end |
130 | 130 | ||
131 | + should 'save hour when feed was fetched' do | ||
132 | + external_feed = create(:external_feed) | ||
133 | + | ||
134 | + now = Time.parse('2009-01-23 09:35') | ||
135 | + Time.stubs(:now).returns(now) | ||
136 | + | ||
137 | + external_feed.finish_fetch | ||
138 | + external_feed.reload | ||
139 | + | ||
140 | + assert_equal 9, external_feed.fetched_at.hour | ||
141 | + assert_equal 35, external_feed.fetched_at.min | ||
142 | + end | ||
143 | + | ||
131 | end | 144 | end |