Fixed tolerance_time tests

Daniela Feitosa
1 parent 21316947
Showing 4 changed files with 19 additions and 13 deletions Show diff stats
plugins/tolerance_time/db/migrate/20141119204010_add_timestamps_to_tolerance.rb
plugins/tolerance_time/test/unit/comment_test.rb
plugins/tolerance_time/test/unit/tolerance_time_plugin/publication_test.rb
plugins/tolerance_time/test/unit/tolerance_time_plugin/tolerance_test.rb
@@ -0,0 +1,5 @@
+class AddTimestampsToTolerance < ActiveRecord::Migration
+  def change
+    add_timestamps :tolerance_time_plugin_tolerances
+  end
+end
@@ -3,8 +3,8 @@ require File.dirname(__FILE__) + &#39;/../../../../test/test_helper&#39;
 class CommentTest < ActiveSupport::TestCase
   should 'create a publication after posting a comment' do
     article = fast_create(Article, :profile_id => fast_create(Person).id)
-    comment = Comment.new(:author_id => fast_create(Person).id, :body => 'Hello There!', :source_id => article.id)
-    assert_difference ToleranceTimePlugin::Publication, :count do
+    comment = Comment.new(:author => fast_create(Person), :body => 'Hello There!', :source => article)
+    assert_difference 'ToleranceTimePlugin::Publication.count', 1 do
       comment.save!
     end
     assert_not_nil ToleranceTimePlugin::Publication.find_by_target(comment)
@@ -13,7 +13,7 @@ class CommentTest &lt; ActiveSupport::TestCase
   should 'destroy publication if the comment is destroyed' do
     profile = fast_create(Profile)
     article = fast_create(Article, :profile_id => profile.id)
-    comment = fast_create(Comment, :source_id => article.id)
+    comment = fast_create(Comment, :source_id => article)
     comment_publication = ToleranceTimePlugin::Publication.create!(:target => comment)
     comment.destroy
     assert_raise ActiveRecord::RecordNotFound do
@@ -4,13 +4,14 @@ class ToleranceTimePlugin::PublicationTest &lt; ActiveSupport::TestCase
   should 'validate presence of target' do
     publication = ToleranceTimePlugin::Publication.new
     publication.valid?
-    assert publication.errors.invalid?(:target_id)
-    assert publication.errors.invalid?(:target_type)
+    assert publication.errors[:target_id].present?
+    assert publication.errors[:target_type].present?
     publication.target = fast_create(Article)
     publication.valid?
-    assert !publication.errors.invalid?(:target_id)
-    assert !publication.errors.invalid?(:target_type)
+
+    assert !publication.errors[:target_id].present?
+    assert !publication.errors[:target_type].present?
   end
   should 'validate uniqueness of target' do
@@ -19,7 +20,7 @@ class ToleranceTimePlugin::PublicationTest &lt; ActiveSupport::TestCase
     p2 = ToleranceTimePlugin::Publication.new(:target => target)
     p2.valid?
-    assert p2.errors.invalid?(:target_id)
+    assert p2.errors[:target_id].present?
   end
   should 'be able to find publication by target' do
@@ -4,11 +4,11 @@ class ToleranceTimePlugin::ToleranceTest &lt; ActiveSupport::TestCase
   should 'validate presence of profile' do
     tolerance = ToleranceTimePlugin::Tolerance.new
     tolerance.valid?
-    assert tolerance.errors.invalid?(:profile_id)
+    assert tolerance.errors[:profile_id].present?
     tolerance.profile = fast_create(Profile)
     tolerance.valid?
-    assert !tolerance.errors.invalid?(:profile_id)
+    assert !tolerance.errors[:profile_id].present?
   end
   should 'validate uniqueness of profile' do
@@ -17,7 +17,7 @@ class ToleranceTimePlugin::ToleranceTest &lt; ActiveSupport::TestCase
     t2 = ToleranceTimePlugin::Tolerance.new(:profile => profile)
     t2.valid?
-    assert t2.errors.invalid?(:profile_id)
+    assert t2.errors[:profile_id].present?
   end
   should 'validate integer format for comment and content tolerance' do
@@ -27,8 +27,8 @@ class ToleranceTimePlugin::ToleranceTest &lt; ActiveSupport::TestCase
     tolerance.comment_tolerance = 'sdfa'
     tolerance.content_tolerance = 4.5
     tolerance.valid?
-    assert tolerance.errors.invalid?(:comment_tolerance)
-    assert tolerance.errors.invalid?(:content_tolerance)
+    assert tolerance.errors[:comment_tolerance].present?
+    assert tolerance.errors[:content_tolerance].present?
     tolerance.comment_tolerance = 3
     tolerance.content_tolerance = 6
@@ -0,0 +1,5 @@		@@ -0,0 +1,5 @@
	1	+class AddTimestampsToTolerance < ActiveRecord::Migration
	2	+ def change
	3	+ add_timestamps :tolerance_time_plugin_tolerances
	4	+ end
	5	+end