Download as
Browse Code »

Commit b7a6c7e4c2eec0b4e5ec6941d11cc6677d408107

Authored by Antonio Terceiro
1 parent 8233605b
Exists in master and in 29 other branches add_member_task_reject_details, admin_visible_profile, article-list-template, community_notifications, contact_admin_translation, event_fixes, fix_comments_pagination, fix_rails4_organization_ratings, fix_sign_up_form, follow_step_fix, forum_topic_creation, mirror_block_improvements, multi_env_on_remote_user, new_security, noosfero_spb_ci, organization_ratings_improvements, organization_ratings_link_to_profile_stable-spb-1.3, organization_ratings_translations_fix, profile_api_improvements, ratings_minor_fixes, remote_user_fix, send_email_to_admins, stable-spb-1.3, stable-spb-1.3-fixes, stable-spb-1.4, stable-spb-1.5, suggest_rejected_value, web_steps_improvements, xss_terminate_custom_options

ActionItem835: bringing features from zen3 branch 

Everything that was in the zen3-specific branch was brought to the
master branch either directly as a enhancement or as a configuration
that will be available and turned on on zen3 itself.
Showing 9 changed files with 48 additions and 8 deletions   Show diff stats
app/controllers/my_profile/cms_controller.rb
  Diff comments   View file @b7a6c7e
... ... @@ -102,7 +102,9 @@ class CmsController < MyProfileController
102 102  
103 103 raise "Invalid article type #{@type}" unless valid_article_type?(@type)
104 104 klass = @type.constantize
105   - @article = klass.new(params[:article])
  105 + article_data = environment.enabled?('articles_dont_accept_comments_by_default') ? { :accept_comments => false } : {}
  106 + article_data.merge!(params[:article]) if params[:article]
  107 + @article = klass.new(article_data)
106 108  
107 109 parent = check_parent(params[:parent_id])
108 110 if parent
... ...
app/controllers/my_profile/memberships_controller.rb
  Diff comments   View file @b7a6c7e
... ... @@ -20,7 +20,9 @@ class MembershipsController < MyProfileController
20 20 end
21 21  
22 22 def new_community
23   - @community = Community.new(params[:community])
  23 + community_data = environment.enabled?('organizations_are_moderated_by_default') ? { :moderated_articles => true } : {}
  24 + community_data.merge!(params[:community]) if params[:community]
  25 + @community = Community.new(community_data)
24 26 @wizard = params[:wizard].blank? ? false : params[:wizard]
25 27 if request.post?
26 28 @community.environment = environment
... ...
app/models/environment.rb
  Diff comments   View file @b7a6c7e
... ... @@ -50,6 +50,11 @@ class Environment < ActiveRecord::Base
50 50 'use_portal_community' => _('Use the portal as news source for front page'),
51 51 'user_themes' => N_('Allow users to create their own themes'),
52 52 'search_in_home' => N_("Display search form in home page"),
  53 +
  54 + 'cant_change_homepage' => N_("Don't allow users to change which article to use as homepage"),
  55 + 'display_header_footer_explanation' => N_("Display explanation about header and footer"),
  56 + 'articles_dont_accept_comments_by_default' => N_("Articles don't accept comments by default"),
  57 + 'organizations_are_moderated_by_default' => N_("Organizations have moderated publication by default"),
53 58 }
54 59 end
55 60  
... ...
app/views/box_organizer/_link_list_block.rhtml
  Diff comments   View file @b7a6c7e
... ... @@ -5,7 +5,7 @@
5 5 <% for link in @block.links do %>
6 6 <tr>
7 7 <td><%= select_tag 'block[links][][icon]', @block.icons_options(link['icon']) %></td>
8   - <td><%= text_field_tag 'block[links][][name]', link[:name] %></td>
  8 + <td><%= text_field_tag 'block[links][][name]', link[:name], :maxlength => 20 %></td>
9 9 <td class='cel-address'><%= text_field_tag 'block[links][][address]', link[:address] %></td>
10 10 </tr>
11 11 <% end %>
... ... @@ -13,6 +13,6 @@
13 13 </div>
14 14  
15 15 <%= link_to_function(_('New link'), nil, :class => 'button icon-add with-text') do |page|
16   - page.insert_html :bottom, 'links', content_tag('tr', content_tag('td', select_tag('block[links][][icon]', @block.icons_options)) + content_tag('td',text_field_tag('block[links][][name]')) + content_tag('td',text_field_tag('block[links][][address]', nil, :class => 'cel-address'))) +
17   - javascript_tag("$('edit-link-list-block').scrollTop = $('edit-link-list-block').scrollHeight")
  16 + page.insert_html :bottom, 'links', content_tag('tr', content_tag('td', select_tag('block[links][][icon]', @block.icons_options)) + content_tag('td',text_field_tag('block[links][][name]', '', :maxlength => 20)) + content_tag('td',text_field_tag('block[links][][address]', nil, :class => 'cel-address'))) +
  17 + javascript_tag("$('edit-link-list-block').scrollTop = $('edit-link-list-block').scrollHeight")
18 18 end %>
... ...
app/views/box_organizer/edit.rhtml
  Diff comments   View file @b7a6c7e
... ... @@ -2,7 +2,7 @@
2 2  
3 3 <% form_tag(:action => 'save', :id => @block.id) do %>
4 4  
5   - <%= labelled_form_field(_('Custom title for this block: '), text_field(:block, :title)) %>
  5 + <%= labelled_form_field(_('Custom title for this block: '), text_field(:block, :title, :maxlength => 20)) %>
6 6  
7 7 <%= render :partial => partial_for_class(@block.class) %>
8 8  
... ...
app/views/cms/view.rhtml
  Diff comments   View file @b7a6c7e
... ... @@ -58,7 +58,9 @@
58 58 <td class="article-controls">
59 59 <%= button_without_text :edit, _('Properties'), :action => 'edit', :id => folder.id %>
60 60 <%= button_without_text :eyes, _('Public view'), folder.url %>
61   - <%= button_without_text :home, _('Use as homepage'), { :action => 'set_home_page', :id => folder.id }, :method => :post %>
  61 + <% if !environment.enabled?('cant_change_homepage') %>
  62 + <%= button_without_text :home, _('Use as homepage'), { :action => 'set_home_page', :id => folder.id }, :method => :post %>
  63 + <% end %>
62 64 <%= button_without_text :delete, _('Delete'), { :action => 'destroy', :id => folder.id }, :method => :post, :confirm => _('Are you sure that you want to remove this folder? Note that all the items inside it will also be removed!') %>
63 65 </td>
64 66 </tr>
... ... @@ -80,7 +82,9 @@
80 82 <% if profile.person? %>
81 83 <%= button_without_text :spread, _('Spread this'), :action => 'publish', :id => item.id %>
82 84 <% end %>
83   - <%= button_without_text :home, _('Use as homepage'), { :action => 'set_home_page', :id => item.id }, :method => :post %>
  85 + <% if !environment.enabled?('cant_change_homepage') %>
  86 + <%= button_without_text :home, _('Use as homepage'), { :action => 'set_home_page', :id => item.id }, :method => :post %>
  87 + <% end %>
84 88 <%= button_without_text :delete, _('Delete'), { :action => 'destroy', :id => item.id }, :method => :post, :confirm => _('Are you sure that you want to remove this item?') %>
85 89 </td>
86 90 </tr>
... ...
app/views/profile_editor/header_footer.rhtml
  Diff comments   View file @b7a6c7e
... ... @@ -4,6 +4,22 @@
4 4  
5 5 <% form_tag do %>
6 6 <div style='width: 90%; margin: auto;'>
  7 + <% if environment.enabled?('display_header_footer_explanation') %>
  8 + <div class='explanation'>
  9 + <%= _('Using the fields below you can customize the header and footer for your website:') %>
  10 + <ul>
  11 + <li><%= _('On header, you can include a personalized banner by first adding in "Manage content", and then referencing it here. A good format is 468 X 60 pixels, PNG format.') %></li>
  12 + <li><%= _('On footer, you can include a slogan and your contact information etc.') %></li>
  13 + </ul>
  14 + <p>
  15 + <%= _('See existing examples:') %>
  16 + </p>
  17 + <ul>
  18 + <li><a href='http://www.zen3.net/coalition-ecopc'>ecoPC Coalition</a></li>
  19 + <li><a href="http://www.zen3.net/ynternet.org">Ynternet.org Foundation</a></li>
  20 + </ul>
  21 + </div>
  22 + <% end %>
7 23 <h2><%= _('Content for header ') %></h2>
8 24 <%= text_area_tag(:custom_header, @header, :style => 'width: 100%; height: 150px;') %>
9 25 <h2><%= _('Content for footer') %></h2>
... ...
config/environment.rb
  Diff comments   View file @b7a6c7e
... ... @@ -115,6 +115,7 @@ Noosfero.locales = {
115 115 'en' => 'English',
116 116 'pt_BR' => 'Português',
117 117 'fr' => 'Français',
  118 + 'hy' => 'հայերեն լեզու',
118 119 }
119 120 # if you want to override this, do it in config/local.rb !
120 121 Noosfero.default_locale = 'en'
... ...
test/functional/cms_controller_test.rb
  Diff comments   View file @b7a6c7e
... ... @@ -97,6 +97,16 @@ class CmsControllerTest &lt; Test::Unit::TestCase
97 97 assert_tag :tag => 'a', :content => 'Use as homepage', :attributes => { :href => "/myprofile/#{profile.identifier}/cms/set_home_page/#{a.id}" }
98 98 end
99 99  
  100 + should 'not display set as home page if disabled in environment' do
  101 + article = profile.articles.create!(:name => 'my new home page')
  102 + folder = Folder.new(:name => 'article folder'); profile.articles << folder; folder.save!
  103 + Article.stubs(:short_description).returns('bli')
  104 + env = Environment.default; env.enable('cant_change_homepage'); env.save!
  105 + get :index, :profile => profile.identifier
  106 + assert_no_tag :tag => 'a', :content => 'Use as homepage', :attributes => { :href => "/myprofile/#{profile.identifier}/cms/set_home_page/#{article.id}" }
  107 + assert_no_tag :tag => 'a', :content => 'Use as homepage', :attributes => { :href => "/myprofile/#{profile.identifier}/cms/set_home_page/#{folder.id}" }
  108 + end
  109 +
100 110 should 'be able to set home page' do
101 111 a = profile.articles.build(:name => 'my new home page')
102 112 a.save!
... ...