ActionItem 2287: Create, edit and assign roles

Caio Almeida
1 parent f3850081
Showing 10 changed files with 93 additions and 5 deletions Show diff stats
app/controllers/admin/role_controller.rb
app/models/profile.rb
app/views/profile_members/change_role.rhtml
app/views/role/_form.rhtml
app/views/role/index.rhtml
app/views/role/new.rhtml
test/functional/role_controller_test.rb
test/unit/profile_test.rb
vendor/plugins/access_control/lib/role.rb
vendor/plugins/access_control/test/role_test.rb
@@ -5,6 +5,20 @@ class RoleController &lt; AdminController
     @roles = environment.roles.find(:all)
   end
+  def new
+    @role = Role.new
+  end
+
+  def create
+    @role = Role.new :name => params[:role][:name], :permissions => params[:role][:permissions], :environment => environment
+    if @role.save
+      redirect_to :action => 'show', :id => @role
+    else
+      session[:notice] = _('Failed to create role')
+      render :action => 'new'
+    end
+  end
+
   def show
     @role = environment.roles.find(params[:id])
   end
@@ -20,12 +20,16 @@ class Profile &lt; ActiveRecord::Base
       find_role('editor', env_id)
     end
     def self.organization_member_roles(env_id)
-      [admin(env_id), moderator(env_id), member(env_id)]
+      all_roles(env_id).select{ |r| r.key.match(/^profile_/) unless r.key.blank? }
     end
     def self.all_roles(env_id)
-      [admin(env_id), member(env_id), moderator(env_id), owner(env_id), editor(env_id)]
+      Role.all :conditions => { :environment_id => env_id }
+    end
+    def self.method_missing(m, *args, &block)
+      role = find_role(m, args[0])
+      return role unless role.nil?
+      super
     end
-
     private
     def self.find_role(name, env_id)
       ::Role.find_by_key_and_environment_id("profile_#{name}", env_id)
@@ -5,6 +5,11 @@
   <%= _('Roles:') %> <br>
   <% @roles.each do |r| %>
     <%= labelled_check_box(r.name, 'roles[]', r.id, @associations.map(&:role).include?(r) ) %><br/>
+    <ul class="role-permissions">
+      <% r.permissions.each do |p| %>
+        <li><%= p %></li>
+      <% end %>
+    </ul>
   <% end %>
   <%= hidden_field_tag 'person', @member.id %>
@@ -6,9 +6,10 @@
   <%= required f.text_field(:name) %>
-  <%= _('Permissions:') %> <br>
+  <p><%= _('Permissions:') %><p>
   <% permissions.keys.each do |p| %>
-    <%= labelled_check_box(permission_name(p), "role[permissions][]", p, role.has_permission?(p)) %> <br/>
+    <%= check_box_tag("role[permissions][]", p, role.has_permission?(p), { :id => p }) %>
+    <%= content_tag(:label, permission_name(p), { :for => p }) %><br/>
   <% end %>
   <% button_bar do %>
@@ -19,4 +19,5 @@
 <% button_bar do %>
   <%= button :back, _('Back'), :controller => 'admin_panel' %>
+  <%= button :add, _('New'), :action => 'new' %>
 <% end %>
@@ -0,0 +1,3 @@
+<h2> <%= _("Create a new role") %> </h2>
+
+<%= render :partial => 'form', :locals => { :mode => :create, :role => @role, :permissions => ActiveRecord::Base::PERMISSIONS[@role.kind] } %>
@@ -59,6 +59,26 @@ class RoleControllerTest &lt; ActionController::TestCase
     assert_not_nil session[:notice]
   end
+  def test_should_see_new_role_page
+    get 'new'
+    assert_response :success
+    assert_not_nil assigns(:role)
+  end
+
+  def test_should_create_new_role
+    assert_difference Role, :count do
+      post 'create', :role => { :name => 'Test Role', :permissions => ["test"] }
+    end
+    assert_redirected_to :action => 'show', :id => Role.last.id
+  end
+
+  def test_should_not_create_new_role
+    assert_no_difference Role, :count do
+      post 'create', :role => { }
+    end
+    assert_template :new
+  end
+
   should 'not crash when editing role with no permissions' do
     role = Role.create!(:name => 'test_role', :environment => Environment.default)
@@ -1740,6 +1740,30 @@ class ProfileTest &lt; ActiveSupport::TestCase
     assert_includes Profile.communities, child
   end
+  should 'get organization roles' do
+    env = fast_create(Environment)
+    roles = %w(foo bar profile_foo profile_bar).map{ |r| Role.create!(:name => r, :key => r, :environment_id => env.id, :permissions => ["some"]) }
+    Role.create! :name => 'test', :key => 'profile_test', :environment_id => env.id + 1
+    Profile::Roles.expects(:all_roles).returns(roles)
+    assert_equal roles[2..3], Profile::Roles.organization_member_roles(env.id)
+  end
+
+  should 'get all roles' do
+    env = fast_create(Environment)
+    roles = %w(foo bar profile_foo profile_bar).map{ |r| Role.create!(:name => r, :environment_id => env.id, :permissions => ["some"]) }
+    Role.create! :name => 'test', :environment_id => env.id + 1
+    assert_equal roles, Profile::Roles.all_roles(env.id)
+  end
+
+  should 'define method for role' do
+    env = fast_create(Environment)
+    r = Role.create! :name => 'Test Role', :environment_id => env.id
+    assert_equal r, Profile::Roles.test_role(env.id)
+    assert_raise NoMethodError do
+      Profile::Roles.invalid_role(env.id)
+    end
+  end
+
   private
   def assert_invalid_identifier(id)
@@ -6,6 +6,7 @@ class Role &lt; ActiveRecord::Base
   validates_presence_of :name
   validates_uniqueness_of :name, :scope => :environment_id
   validates_uniqueness_of :key, :if => lambda { |role| !role.key.blank? }, :scope => :environment_id
+  before_validation_on_create :create_key
   def initialize(*args)
     super(*args)
@@ -54,4 +55,9 @@ class Role &lt; ActiveRecord::Base
   def perms
     ActiveRecord::Base::PERMISSIONS
   end
+
+  private
+  def create_key
+    self.key = 'profile_' + self.name.gsub(' ', '_').gsub(/[^a-zA-Z0-9_]/, '').downcase if self.key.blank? && !self.name.blank?
+  end
 end
@@ -107,4 +107,14 @@ class RoleTest &lt; Test::Unit::TestCase
     assert !RoleAssignment.exists?(ra.id)
   end
+  def test_should_define_key_for_role_if_key_not_present
+    r = Role.create! :name => 'Test Role'
+    assert_equal 'profile_test_role', r.key
+  end
+
+  def test_should_not_define_key_for_role_if_key_present
+    r = Role.create! :name => 'Test Role', :key => 'foo'
+    assert_equal 'foo', r.key
+  end
+
 end
	@@ -5,6 +5,20 @@ class RoleController < AdminController		@@ -5,6 +5,20 @@ class RoleController < AdminController
5	@roles = environment.roles.find(:all)	5	@roles = environment.roles.find(:all)
6	end	6	end
7		7
		8	+ def new
		9	+ @role = Role.new
		10	+ end
		11	+
		12	+ def create
		13	+ @role = Role.new :name => params[:role][:name], :permissions => params[:role][:permissions], :environment => environment
		14	+ if @role.save
		15	+ redirect_to :action => 'show', :id => @role
		16	+ else
		17	+ session[:notice] = _('Failed to create role')
		18	+ render :action => 'new'
		19	+ end
		20	+ end
		21	+
8	def show	22	def show
9	@role = environment.roles.find(params[:id])	23	@role = environment.roles.find(params[:id])
10	end	24	end
	@@ -19,4 +19,5 @@		@@ -19,4 +19,5 @@
19		19
20	<% button_bar do %>	20	<% button_bar do %>
21	<%= button :back, _('Back'), :controller => 'admin_panel' %>	21	<%= button :back, _('Back'), :controller => 'admin_panel' %>
		22	+ <%= button :add, _('New'), :action => 'new' %>
22	<% end %>	23	<% end %>
@@ -0,0 +1,3 @@		@@ -0,0 +1,3 @@
	1	+<h2> <%= _("Create a new role") %> </h2>
	2	+
	3	+<%= render :partial => 'form', :locals => { :mode => :create, :role => @role, :permissions => ActiveRecord::Base::PERMISSIONS[@role.kind] } %>
	@@ -59,6 +59,26 @@ class RoleControllerTest < ActionController::TestCase		@@ -59,6 +59,26 @@ class RoleControllerTest < ActionController::TestCase
59	assert_not_nil session[:notice]	59	assert_not_nil session[:notice]
60	end	60	end
61		61
		62	+ def test_should_see_new_role_page
		63	+ get 'new'
		64	+ assert_response :success
		65	+ assert_not_nil assigns(:role)
		66	+ end
		67	+
		68	+ def test_should_create_new_role
		69	+ assert_difference Role, :count do
		70	+ post 'create', :role => { :name => 'Test Role', :permissions => ["test"] }
		71	+ end
		72	+ assert_redirected_to :action => 'show', :id => Role.last.id
		73	+ end
		74	+
		75	+ def test_should_not_create_new_role
		76	+ assert_no_difference Role, :count do
		77	+ post 'create', :role => { }
		78	+ end
		79	+ assert_template :new
		80	+ end
		81	+
62	should 'not crash when editing role with no permissions' do	82	should 'not crash when editing role with no permissions' do
63	role = Role.create!(:name => 'test_role', :environment => Environment.default)	83	role = Role.create!(:name => 'test_role', :environment => Environment.default)
64		84
	@@ -1740,6 +1740,30 @@ class ProfileTest < ActiveSupport::TestCase		@@ -1740,6 +1740,30 @@ class ProfileTest < ActiveSupport::TestCase
1740	assert_includes Profile.communities, child	1740	assert_includes Profile.communities, child
1741	end	1741	end
1742		1742
		1743	+ should 'get organization roles' do
		1744	+ env = fast_create(Environment)
		1745	+ roles = %w(foo bar profile_foo profile_bar).map{ \|r\| Role.create!(:name => r, :key => r, :environment_id => env.id, :permissions => ["some"]) }
		1746	+ Role.create! :name => 'test', :key => 'profile_test', :environment_id => env.id + 1
		1747	+ Profile::Roles.expects(:all_roles).returns(roles)
		1748	+ assert_equal roles[2..3], Profile::Roles.organization_member_roles(env.id)
		1749	+ end
		1750	+
		1751	+ should 'get all roles' do
		1752	+ env = fast_create(Environment)
		1753	+ roles = %w(foo bar profile_foo profile_bar).map{ \|r\| Role.create!(:name => r, :environment_id => env.id, :permissions => ["some"]) }
		1754	+ Role.create! :name => 'test', :environment_id => env.id + 1
		1755	+ assert_equal roles, Profile::Roles.all_roles(env.id)
		1756	+ end
		1757	+
		1758	+ should 'define method for role' do
		1759	+ env = fast_create(Environment)
		1760	+ r = Role.create! :name => 'Test Role', :environment_id => env.id
		1761	+ assert_equal r, Profile::Roles.test_role(env.id)
		1762	+ assert_raise NoMethodError do
		1763	+ Profile::Roles.invalid_role(env.id)
		1764	+ end
		1765	+ end
		1766	+
1743	private	1767	private
1744		1768
1745	def assert_invalid_identifier(id)	1769	def assert_invalid_identifier(id)
	@@ -107,4 +107,14 @@ class RoleTest < Test::Unit::TestCase		@@ -107,4 +107,14 @@ class RoleTest < Test::Unit::TestCase
107	assert !RoleAssignment.exists?(ra.id)	107	assert !RoleAssignment.exists?(ra.id)
108	end	108	end
109		109
		110	+ def test_should_define_key_for_role_if_key_not_present
		111	+ r = Role.create! :name => 'Test Role'
		112	+ assert_equal 'profile_test_role', r.key
		113	+ end
		114	+
		115	+ def test_should_not_define_key_for_role_if_key_present
		116	+ r = Role.create! :name => 'Test Role', :key => 'foo'
		117	+ assert_equal 'foo', r.key
		118	+ end
		119	+
110	end	120	end