Download as
Browse Code »

Commit bedac4e4d130911a45498e0dfa3508e33e64d4f2

Authored by Larissa Reis
1 parent 3526dd07
Exists in master and in 29 other branches add_member_task_reject_details, admin_visible_profile, article-list-template, community_notifications, contact_admin_translation, event_fixes, fix_comments_pagination, fix_rails4_organization_ratings, fix_sign_up_form, follow_step_fix, forum_topic_creation, mirror_block_improvements, multi_env_on_remote_user, new_security, noosfero_spb_ci, organization_ratings_improvements, organization_ratings_link_to_profile_stable-spb-1.3, organization_ratings_translations_fix, profile_api_improvements, ratings_minor_fixes, remote_user_fix, send_email_to_admins, stable-spb-1.3, stable-spb-1.3-fixes, stable-spb-1.4, stable-spb-1.5, suggest_rejected_value, web_steps_improvements, xss_terminate_custom_options

Prevents expired form from being submited in task page

Showing 2 changed files with 5 additions and 1 deletions   Show diff stats
plugins/custom_forms/lib/custom_forms_plugin/membership_survey.rb
  Diff comments   View file @bedac4e
@@ -9,6 +9,8 @@ class CustomFormsPlugin::MembershipSurvey < Task @@ -9,6 +9,8 @@ class CustomFormsPlugin::MembershipSurvey < Task
9 9
10 def perform 10 def perform
11 form = CustomFormsPlugin::Form.find(form_id) 11 form = CustomFormsPlugin::Form.find(form_id)
  12 + raise 'Form expired' if form.expired?
  13 +
12 answers = build_answers(submission, form) 14 answers = build_answers(submission, form)
13 s = CustomFormsPlugin::Submission.create!(:form => form, :profile => target) 15 s = CustomFormsPlugin::Submission.create!(:form => form, :profile => target)
14 answers.map {|answer| answer.submission = s; answer.save!} 16 answers.map {|answer| answer.submission = s; answer.save!}
plugins/custom_forms/views/tasks/custom_forms_plugin/_membership_survey_accept_details.html.erb
  Diff comments   View file @bedac4e
@@ -3,8 +3,10 @@ @@ -3,8 +3,10 @@
3 3
4 <h2><%= @form.name %></h2> 4 <h2><%= @form.name %></h2>
5 <p><%= @form.description %></p> 5 <p><%= @form.description %></p>
  6 +<% if @form.expired? %>
  7 + <h3><%= _('Sorry, you can\'t fill this form right now') %></h3>
  8 +<% end %>
6 9
7 <% f.fields_for :submission do |fi| %> 10 <% f.fields_for :submission do |fi| %>
8 - <%#= fi.error_messages_for :submission %>  
9 <%= render :partial => 'shared/form_submission', :locals => {:f => fi} %> 11 <%= render :partial => 'shared/form_submission', :locals => {:f => fi} %>
10 <% end %> 12 <% end %>