Download as
Browse Code »

Commit c0e786385914481d4e017cd60d9e8a1a4aeff8ed

Authored by Rodrigo Souto
1 parent 1b7dcab6
Exists in master and in 29 other branches add_member_task_reject_details, admin_visible_profile, article-list-template, community_notifications, contact_admin_translation, event_fixes, fix_comments_pagination, fix_rails4_organization_ratings, fix_sign_up_form, follow_step_fix, forum_topic_creation, mirror_block_improvements, multi_env_on_remote_user, new_security, noosfero_spb_ci, organization_ratings_improvements, organization_ratings_link_to_profile_stable-spb-1.3, organization_ratings_translations_fix, profile_api_improvements, ratings_minor_fixes, remote_user_fix, send_email_to_admins, stable-spb-1.3, stable-spb-1.3-fixes, stable-spb-1.4, stable-spb-1.5, suggest_rejected_value, web_steps_improvements, xss_terminate_custom_options

Removing ApplicationHelper include from plugin 

This causes the plugin to mistakenly answer to :comment_actions with
ApplicationHelper method.

(ActionItem2755)
Showing 2 changed files with 2 additions and 1 deletions   Show diff stats
plugins/google_analytics/lib/google_analytics_plugin.rb
  Diff comments   View file @c0e7863
@@ -6,7 +6,6 @@ class GoogleAnalyticsPlugin < Noosfero::Plugin @@ -6,7 +6,6 @@ class GoogleAnalyticsPlugin < Noosfero::Plugin
6 include ActionView::Helpers::FormHelper 6 include ActionView::Helpers::FormHelper
7 include ActionView::Helpers::UrlHelper 7 include ActionView::Helpers::UrlHelper
8 include ActionView::Helpers::TagHelper 8 include ActionView::Helpers::TagHelper
9 - include ApplicationHelper  
10 9
11 def self.plugin_name 10 def self.plugin_name
12 "Google Analytics" 11 "Google Analytics"
plugins/google_analytics/views/profile-editor-extras.rhtml
  Diff comments   View file @c0e7863
  1 +<% extend ApplicationHelper %>
  2 +
1 <h2><%= _('Statistics') %></h2> 3 <h2><%= _('Statistics') %></h2>
2 <%= labelled_form_field(_('Google Analytics Profile ID'), text_field(:profile_data, :google_analytics_profile_id, :value => profile_id)) %> 4 <%= labelled_form_field(_('Google Analytics Profile ID'), text_field(:profile_data, :google_analytics_profile_id, :value => profile_id)) %>
3 <%= link_to(_('See how to configure statistics for your profile'), '/doc/plugins/google_analytics', :target => '_blank') %> 5 <%= link_to(_('See how to configure statistics for your profile'), '/doc/plugins/google_analytics', :target => '_blank') %>