Download as
Browse Code »

Commit cd8db653189648b8bb8246333afa09da706a041f

Authored by AntonioTerceiro
1 parent 6eae175f
Exists in master and in 29 other branches add_member_task_reject_details, admin_visible_profile, article-list-template, community_notifications, contact_admin_translation, event_fixes, fix_comments_pagination, fix_rails4_organization_ratings, fix_sign_up_form, follow_step_fix, forum_topic_creation, mirror_block_improvements, multi_env_on_remote_user, new_security, noosfero_spb_ci, organization_ratings_improvements, organization_ratings_link_to_profile_stable-spb-1.3, organization_ratings_translations_fix, profile_api_improvements, ratings_minor_fixes, remote_user_fix, send_email_to_admins, stable-spb-1.3, stable-spb-1.3-fixes, stable-spb-1.4, stable-spb-1.5, suggest_rejected_value, web_steps_improvements, xss_terminate_custom_options

ActionItem466: use eager loading in map_traversal 

instead of having O(n) SQL queries, let's do only O(log(n)).


git-svn-id: https://svn.colivre.coop.br/svn/noosfero/trunk@2058 3f533792-8f58-4932-b0fe-aaf55b0a4547
Showing 1 changed file with 6 additions and 8 deletions   Show diff stats
lib/acts_as_filesystem.rb
  Diff comments   View file @cd8db65
... ... @@ -158,15 +158,13 @@ module ActsAsFileSystem
158 158 end
159 159  
160 160 def map_traversal(&block)
161   - stack = []
162 161 result = []
163   - stack.push(self)
164   - while !stack.empty?
165   - element = stack.pop
166   - result.push(element)
167   - element.children.reverse.each do |item|
168   - stack.push(item)
169   - end
  162 + current_level = [self]
  163 +
  164 + while !current_level.empty?
  165 + result += current_level
  166 + ids = current_level.map(&:id)
  167 + current_level = self.class.find(:all, :conditions => { :parent_id => ids})
170 168 end
171 169 block ||= (lambda { |x| x })
172 170 result.map(&block)
... ...