Download as
Browse Code »

Commit d005f12011a1bdff20234b8eabf432a984e681e7

Authored by Antonio Terceiro
1 parent 243a2726
Exists in master and in 29 other branches add_member_task_reject_details, admin_visible_profile, article-list-template, community_notifications, contact_admin_translation, event_fixes, fix_comments_pagination, fix_rails4_organization_ratings, fix_sign_up_form, follow_step_fix, forum_topic_creation, mirror_block_improvements, multi_env_on_remote_user, new_security, noosfero_spb_ci, organization_ratings_improvements, organization_ratings_link_to_profile_stable-spb-1.3, organization_ratings_translations_fix, profile_api_improvements, ratings_minor_fixes, remote_user_fix, send_email_to_admins, stable-spb-1.3, stable-spb-1.3-fixes, stable-spb-1.4, stable-spb-1.5, suggest_rejected_value, web_steps_improvements, xss_terminate_custom_options

Avoid crash with users who are not logged in 

(ActionItem2345)
Showing 2 changed files with 7 additions and 1 deletions   Show diff stats
app/models/article.rb
  Diff comments   View file @d005f12
@@ -417,7 +417,7 @@ class Article < ActiveRecord::Base @@ -417,7 +417,7 @@ class Article < ActiveRecord::Base
417 end 417 end
418 418
419 def allow_edit?(user) 419 def allow_edit?(user)
420 - allow_post_content?(user) || allow_members_to_edit && user.is_member_of?(profile) 420 + allow_post_content?(user) || user && allow_members_to_edit && user.is_member_of?(profile)
421 end 421 end
422 422
423 def comments_updated 423 def comments_updated
test/unit/article_test.rb
  Diff comments   View file @d005f12
@@ -1665,4 +1665,10 @@ class ArticleTest < ActiveSupport::TestCase @@ -1665,4 +1665,10 @@ class ArticleTest < ActiveSupport::TestCase
1665 assert_equal true, a.allow_edit?(member) 1665 assert_equal true, a.allow_edit?(member)
1666 end 1666 end
1667 1667
  1668 + should 'not crash on allow_edit without a current user' do
  1669 + a = build(Article)
  1670 + a.allow_members_to_edit = true
  1671 + assert !a.allow_edit?(nil)
  1672 + end
  1673 +
1668 end 1674 end