Download as
Browse Code »

Commit d6ddc97dbcc7ddbaecdbd15b990679b4d3045adf

Authored by Larissa Reis
1 parent 9cf96ec9
Exists in master and in 29 other branches add_member_task_reject_details, admin_visible_profile, article-list-template, community_notifications, contact_admin_translation, event_fixes, fix_comments_pagination, fix_rails4_organization_ratings, fix_sign_up_form, follow_step_fix, forum_topic_creation, mirror_block_improvements, multi_env_on_remote_user, new_security, noosfero_spb_ci, organization_ratings_improvements, organization_ratings_link_to_profile_stable-spb-1.3, organization_ratings_translations_fix, profile_api_improvements, ratings_minor_fixes, remote_user_fix, send_email_to_admins, stable-spb-1.3, stable-spb-1.3-fixes, stable-spb-1.4, stable-spb-1.5, suggest_rejected_value, web_steps_improvements, xss_terminate_custom_options

[search-improvements] Allows more than one search input per page 

  Some users have a profile search block in their pages, so sometimes
  there are more than one search input per page. I changed the
  autocomplete to use class instead of id to select all inputs.
Showing 4 changed files with 6 additions and 6 deletions   Show diff stats
app/helpers/application_helper.rb
  Diff comments   View file @d6ddc97
... ... @@ -1419,7 +1419,7 @@ module ApplicationHelper
1419 1419 end
1420 1420  
1421 1421 def search_input_with_suggestions(name, asset, default, options = {})
1422   - text_field_tag name, default, options.merge({:id => 'search-input', 'data-asset' => asset})
  1422 + text_field_tag name, default, options.merge({:class => 'search-input-with-suggestions', 'data-asset' => asset})
1423 1423 end
1424 1424  
1425 1425 def profile_suggestion_profile_connections(suggestion)
... ...
app/views/search/_search_form.html.erb
  Diff comments   View file @d6ddc97
... ... @@ -9,7 +9,7 @@
9 9  
10 10 <div class="search-field">
11 11 <span class="formfield">
12   - <%= search_input_with_suggestions('query', @asset, @query, {:size => 50, :placeholder => hint}) %>
  12 + <%= search_input_with_suggestions('query', @asset, @query, {:id => 'search-input', :size => 50, :placeholder => hint}) %>
13 13 </span>
14 14  
15 15 <%= submit_button(:search, _('Search')) %>
... ...
public/javascripts/application.js
  Diff comments   View file @d6ddc97
... ... @@ -1090,7 +1090,7 @@ jQuery(document).ready(function(){
1090 1090 // Suggestions on search inputs
1091 1091 (function($) {
1092 1092 var suggestions_cache = {};
1093   - $("#search-input").autocomplete({
  1093 + $(".search-input-with-suggestions").autocomplete({
1094 1094 minLength: 2,
1095 1095 select: function(event, ui){
1096 1096 $(this).val(ui.item.value);
... ... @@ -1102,7 +1102,7 @@ jQuery(document).ready(function(){
1102 1102 response(suggestions_cache[term]);
1103 1103 return;
1104 1104 }
1105   - request["asset"] = $("#search-input").data("asset");
  1105 + request["asset"] = this.element.data("asset");
1106 1106 $.getJSON("/search/suggestions", request, function(data, status, xhr) {
1107 1107 suggestions_cache[term] = data;
1108 1108 response(data);
... ...
public/javascripts/search.js
  Diff comments   View file @d6ddc97
... ... @@ -37,12 +37,12 @@
37 37 });
38 38  
39 39 // Real time search
40   - // $("input#search-input").typeWatch({
  40 + // $(".search-input-with-suggestions").typeWatch({
41 41 // callback: function (value) {$('form.search_form').submit()},
42 42 // wait: 750,
43 43 // highlight: true,
44 44 // captureLength: 2
45 45 // });
46 46  
47   - $("input#search-input").bind('notext', function(){ $('form.search_form').submit() });
  47 + $(".search-input-with-suggestions").bind('notext', function(){ $('form.search_form').submit() });
48 48 })(jQuery);
... ...