curriculum_lattes_plugin: fixed functionals tests

Daniela Feitosa
1 parent 1ea73489
Showing 2 changed files with 11 additions and 7 deletions Show diff stats
app/controllers/my_profile/profile_editor_controller.rb
test/functional/profile_editor_controller_test.rb
@@ -15,16 +15,16 @@ class ProfileEditorController &lt; MyProfileController
     @possible_domains = profile.possible_domains
     if request.post?
       params[:profile_data][:fields_privacy] ||= {} if profile.person? && params[:profile_data].is_a?(Hash)
-      begin
-        Profile.transaction do
-          Image.transaction do
+      Profile.transaction do
+        Image.transaction do
+          begin
             @plugins.dispatch(:profile_editor_transaction_extras)
             @profile_data.update_attributes!(params[:profile_data])
             redirect_to :action => 'index', :profile => profile.identifier
+          rescue Exception => ex
+            profile.identifier = params[:profile] if profile.identifier.blank?
           end
         end
-      rescue Exception => ex
-        profile.identifier = params[:profile] if profile.identifier.blank?
       end
     end
   end
@@ -230,16 +230,20 @@ class ProfileEditorControllerTest &lt; ActionController::TestCase
   should 'back when update community info fail' do
     org = fast_create(Community)
-    Community.any_instance.stubs(:update_attributes).returns(false)
+    Community.any_instance.expects(:update_attributes!).raises(ActiveRecord::RecordInvalid)
     post :edit, :profile => org.identifier
+
     assert_template 'edit'
+    assert_response :success
   end
   should 'back when update enterprise info fail' do
     org = fast_create(Enterprise)
-    Enterprise.any_instance.stubs(:update_attributes).returns(false)
+
+    Enterprise.any_instance.expects(:update_attributes!).raises(ActiveRecord::RecordInvalid)
     post :edit, :profile => org.identifier
     assert_template 'edit'
+    assert_response :success
   end
   should 'show edit profile button' do