Download as
Browse Code »

Commit f4699a8e484f86fdaab420746c7682b4321239d9

Authored by Rodrigo Souto
1 parent e9b2ae4f
Exists in master and in 29 other branches add_member_task_reject_details, admin_visible_profile, article-list-template, community_notifications, contact_admin_translation, event_fixes, fix_comments_pagination, fix_rails4_organization_ratings, fix_sign_up_form, follow_step_fix, forum_topic_creation, mirror_block_improvements, multi_env_on_remote_user, new_security, noosfero_spb_ci, organization_ratings_improvements, organization_ratings_link_to_profile_stable-spb-1.3, organization_ratings_translations_fix, profile_api_improvements, ratings_minor_fixes, remote_user_fix, send_email_to_admins, stable-spb-1.3, stable-spb-1.3-fixes, stable-spb-1.4, stable-spb-1.5, suggest_rejected_value, web_steps_improvements, xss_terminate_custom_options

[search-improvements] If no results indexed, relevance must be zero

Showing 2 changed files with 9 additions and 0 deletions   Show diff stats
app/models/search_term.rb
  Diff comments   View file @f4699a8
@@ -42,6 +42,7 @@ class SearchTerm < ActiveRecord::Base @@ -42,6 +42,7 @@ class SearchTerm < ActiveRecord::Base
42 42
43 def calculate_relevance(valid_occurrences) 43 def calculate_relevance(valid_occurrences)
44 indexed = valid_occurrences.last.indexed.to_f 44 indexed = valid_occurrences.last.indexed.to_f
  45 + return 0 if indexed == 0
45 total = valid_occurrences.last.total.to_f 46 total = valid_occurrences.last.total.to_f
46 (1 - indexed/total)*100 47 (1 - indexed/total)*100
47 end 48 end
test/unit/search_term_test.rb
  Diff comments   View file @f4699a8
@@ -118,4 +118,12 @@ class SearchTermTest < ActiveSupport::TestCase @@ -118,4 +118,12 @@ class SearchTermTest < ActiveSupport::TestCase
118 118
119 assert st1.score > st2.score, "Less ratio results:total are not getting higher scores." 119 assert st1.score > st2.score, "Less ratio results:total are not getting higher scores."
120 end 120 end
  121 +
  122 + should 'consider relevance zero if no results indexed' do
  123 + st = SearchTerm.find_or_create('st', Environment.default)
  124 + SearchTermOccurrence.create!(:search_term => st, :total => 10, :indexed => 0)
  125 + SearchTerm.calculate_scores
  126 + st.reload
  127 + assert_equal 0, st.score
  128 + end
121 end 129 end