Download as
Browse Code »

Commit faeba294e907bb66a0b7774dabbbe6ce0eff81f5

Authored by Antonio Terceiro
1 parent bbfaed44
Exists in master and in 29 other branches add_member_task_reject_details, admin_visible_profile, article-list-template, community_notifications, contact_admin_translation, event_fixes, fix_comments_pagination, fix_rails4_organization_ratings, fix_sign_up_form, follow_step_fix, forum_topic_creation, mirror_block_improvements, multi_env_on_remote_user, new_security, noosfero_spb_ci, organization_ratings_improvements, organization_ratings_link_to_profile_stable-spb-1.3, organization_ratings_translations_fix, profile_api_improvements, ratings_minor_fixes, remote_user_fix, send_email_to_admins, stable-spb-1.3, stable-spb-1.3-fixes, stable-spb-1.4, stable-spb-1.5, suggest_rejected_value, web_steps_improvements, xss_terminate_custom_options

Environment: use contact_email for notifications 

There is no point at all in send email to the noreply_email
Showing 2 changed files with 7 additions and 1 deletions   Show diff stats
app/models/environment.rb
  Diff comments   View file @faeba29
@@ -804,7 +804,7 @@ class Environment < ActiveRecord::Base @@ -804,7 +804,7 @@ class Environment < ActiveRecord::Base
804 end 804 end
805 805
806 def notification_emails 806 def notification_emails
807 - [noreply_email.blank? ? nil : noreply_email].compact + admins.map(&:email) 807 + [contact_email].select(&:present?) + admins.map(&:email)
808 end 808 end
809 809
810 after_create :create_templates 810 after_create :create_templates
test/unit/environment_test.rb
  Diff comments   View file @faeba29
@@ -195,6 +195,12 @@ class EnvironmentTest < ActiveSupport::TestCase @@ -195,6 +195,12 @@ class EnvironmentTest < ActiveSupport::TestCase
195 assert !env.errors[:contact_email.to_s].present? 195 assert !env.errors[:contact_email.to_s].present?
196 end 196 end
197 197
  198 + should 'notify contact email' do
  199 + env = Environment.new(:contact_email => 'foo@bar.com')
  200 + env.stubs(:admins).returns([])
  201 + assert_equal ['foo@bar.com'], env.notification_emails
  202 + end
  203 +
198 should 'provide a default hostname' do 204 should 'provide a default hostname' do
199 env = fast_create(Environment) 205 env = fast_create(Environment)
200 env.domains << create(Domain, :name => 'example.com', :is_default => true) 206 env.domains << create(Domain, :name => 'example.com', :is_default => true)