tests: Remove unecessary test request/response

Braulio Bhavamitra
1 parent 76e29aed
Showing 89 changed files with 51 additions and 189 deletions Show diff stats
plugins/admin_notifications/test/functional/account_controller_test.rb
plugins/admin_notifications/test/functional/admin_notifications_plugin_admin_controller_test.rb
plugins/admin_notifications/test/functional/admin_notifications_plugin_myprofile_controller_test.rb
plugins/admin_notifications/test/functional/admin_notifications_plugin_public_controller_test.rb
plugins/admin_notifications/test/functional/home_controller_test.rb
plugins/analytics/test/functional/content_viewer_controller_test.rb
plugins/comment_group/test/functional/comment_group_plugin_profile_controller_test.rb
plugins/comment_group/test/functional/comment_group_plugin_public_controller_test.rb
plugins/custom_forms/test/functional/custom_forms_plugin_myprofile_controller_test.rb
plugins/custom_forms/test/functional/custom_forms_plugin_profile_controller_test.rb
plugins/display_content/test/functional/display_content_plugin_admin_controller_test.rb
plugins/display_content/test/functional/display_content_plugin_myprofile_controller_test.rb
plugins/driven_signup/test/integration/account_controller_test.rb
plugins/google_analytics/test/functional/profile_editor_controller_test.rb
plugins/google_cse/test/functional/google_cse_plugin_controller_test.rb
plugins/html5_video/test/functional/content_viewer_controler_test.rb
plugins/ldap/test/functional/account_controller_plugin_test.rb
plugins/mark_comment_as_read/test/functional/mark_comment_as_read_plugin_profile_controller_test.rb
plugins/metadata/test/functional/content_viewer_controller_test.rb
plugins/metadata/test/functional/home_controller_test.rb
@@ -8,8 +8,7 @@ end
 class AccountControllerTest < ActionController::TestCase
   def setup
     @controller = AccountController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
+
     @person = create_user('person').person
     @environment = Environment.default
@@ -4,8 +4,6 @@ require_relative &#39;../../controllers/admin_notifications_plugin_admin_controller&#39;
 class AdminNotificationsPluginAdminControllerTest < ActionController::TestCase
   def setup
     @controller = AdminNotificationsPluginAdminController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
     @person = create_user('person').person
     @environment = Environment.default
@@ -7,8 +7,6 @@ require(
 class AdminNotificationsPluginMyprofileControllerTest < ActionController::TestCase
   def setup
     @controller = AdminNotificationsPluginMyprofileController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
     @person = create_user('person').person
     @community = fast_create(Community)
@@ -7,8 +7,6 @@ require(
 class AdminNotificationsPluginPublicControllerTest < ActionController::TestCase
   def setup
     @controller = AdminNotificationsPluginPublicController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
     @person = create_user('person').person
     @environment = Environment.default
@@ -7,8 +7,7 @@ end
 class HomeControllerTest < ActionController::TestCase
   def setup
     @controller = HomeController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
+
     @person = create_user('person').person
     @environment = Environment.default
@@ -5,8 +5,6 @@ class ContentViewerControllerTest &lt; ActionController::TestCase
   def setup
     @controller = ContentViewerController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
     @environment = Environment.default
     @environment.enabled_plugins += ['AnalyticsPlugin']
@@ -5,8 +5,6 @@ class CommentGroupPluginProfileControllerTest &lt; ActionController::TestCase
   def setup
     @controller = CommentGroupPluginProfileController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
     @profile = create_user('testuser').person
     @article = profile.articles.build(:name => 'test')
@@ -5,8 +5,6 @@ class CommentGroupPluginPublicControllerTest &lt; ActionController::TestCase
   def setup
     @controller = CommentGroupPluginPublicController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
     @profile = create_user('testuser').person
     @article = profile.articles.build(:name => 'test')
@@ -4,8 +4,7 @@ require_relative &#39;../../controllers/custom_forms_plugin_myprofile_controller&#39;
 class CustomFormsPluginMyprofileControllerTest < ActionController::TestCase
   def setup
     @controller = CustomFormsPluginMyprofileController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
+
     @profile = create_user('profile').person
     login_as(@profile.identifier)
     environment = Environment.default
@@ -4,8 +4,7 @@ require_relative &#39;../../controllers/custom_forms_plugin_profile_controller&#39;
 class CustomFormsPluginProfileControllerTest < ActionController::TestCase
   def setup
     @controller = CustomFormsPluginProfileController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
+
     @profile = create_user('profile').person
     login_as(@profile.identifier)
     environment = Environment.default
@@ -5,8 +5,6 @@ class DisplayContentPluginAdminControllerTest &lt; ActionController::TestCase
   def setup
     @controller = DisplayContentPluginAdminController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
     @environment = Environment.default
     user_login = create_admin_user(@environment)
@@ -5,8 +5,6 @@ class DisplayContentPluginMyprofileControllerTest &lt; ActionController::TestCase
   def setup
     @controller = DisplayContentPluginMyprofileController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
     user = create_user('testinguser')
     login_as(user.login)
@@ -7,8 +7,7 @@ class AccountControllerTest &lt; ActionDispatch::IntegrationTest
   def setup
     @controller = AccountController.new
-    @request = ActionController::TestRequest.new
-    @response = ActionController::TestResponse.new
+    @request    = ActionController::TestRequest.new
     e = Environment.default
     e.enable 'skip_new_user_email_confirmation', true
@@ -5,8 +5,7 @@ class ProfileEditorControllerTest &lt; ActionController::TestCase
   def setup
     @controller = ProfileEditorController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
+
     @profile = create_user('default_user').person
     login_as(@profile.identifier)
     Environment.default.enable_plugin(GoogleAnalyticsPlugin.name)
@@ -5,8 +5,6 @@ class GoogleCsePluginControllerTest &lt; ActionController::TestCase
   def setup
     @controller = GoogleCsePluginController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
   end
   should 'get results page' do
@@ -7,8 +7,6 @@ class ContentViewerControllerTest &lt; ActionController::TestCase
   def setup
     @controller = ContentViewerController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
     @profile = create_user('testinguser').person
     @environment = @profile.environment
@@ -4,8 +4,6 @@ class AccountControllerPluginTest &lt; ActionController::TestCase
   def setup
     @controller = AccountController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
     @environment = Environment.default
     @environment.enabled_plugins = ['LdapPlugin']
@@ -4,8 +4,7 @@ require_relative &#39;../../controllers/mark_comment_as_read_plugin_profile_controll
 class MarkCommentAsReadPluginProfileControllerTest < ActionController::TestCase
   def setup
     @controller = MarkCommentAsReadPluginProfileController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
+
     @profile = create_user('profile').person
     @article = TinyMceArticle.create!(:profile => @profile, :name => 'An article')
     @comment = Comment.new(:source => @article, :author => @profile, :body => 'test')
@@ -6,8 +6,6 @@ class ContentViewerControllerTest &lt; ActionController::TestCase
   def setup
     @controller = ContentViewerController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
     @profile = create_user('testinguser').person
     @environment = @profile.environment
@@ -5,8 +5,6 @@ class HomeControllerTest &lt; ActionController::TestCase
   def setup
     @controller = HomeController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
     @environment = Environment.default
     @environment.enabled_plugins += ['MetadataPlugin']
@@ -6,8 +6,6 @@ if defined? ProductsPlugin
       def setup
         @controller = PageController.new
-        @request    = ActionController::TestRequest.new
-        @response   = ActionController::TestResponse.new
         @enterprise = fast_create(Enterprise, name: 'test', identifier: 'test_ent')
         @user = create_user_with_permission('test_user', 'manage_products', @enterprise)
         login_as :test_user
@@ -4,8 +4,6 @@ class NewsletterPluginAdminControllerTest &lt; ActionController::TestCase
   def setup
     @controller = NewsletterPluginAdminController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
     @admin = create_user('admin_newsletter').person
     @environment = @admin.environment
@@ -4,8 +4,7 @@ class NewsletterPluginControllerTest &lt; ActionController::TestCase
   def setup
     @controller = NewsletterPluginController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
+
     environment = fast_create(Environment)
     environment.enable_plugin(NewsletterPlugin)
     @controller.stubs(:environment).returns(environment)
@@ -8,8 +8,7 @@ class OpenGraphPlugin::MyprofileControllerTest &lt; ActionController::TestCase
   def setup
     @controller = OpenGraphPlugin::MyprofileController.new
-    @request = ActionController::TestRequest.new
-    @response = ActionController::TestResponse.new
+
     @actor = create_user.person
   end
@@ -8,8 +8,6 @@ class OrganizationRatingsPluginAdminControllerTest &lt; ActionController::TestCase
   def setup
     @controller = OrganizationRatingsPluginAdminController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
     @environment = Environment.default
     @environment.enabled_plugins = ['OrganizationRatingsPlugin']
@@ -8,8 +8,6 @@ class OrganizationRatingsPluginProfileControllerTest &lt; ActionController::TestCas
   def setup
     @controller = OrganizationRatingsPluginProfileController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
     @environment = Environment.default
     @environment.enabled_plugins = ['OrganizationRatingsPlugin']
@@ -4,8 +4,7 @@ class EnvironmentDesignControllerTest &lt; ActionController::TestCase
   def setup
     @controller = EnvironmentDesignController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
+
     Noosfero::Plugin::Manager.any_instance.stubs(:enabled_plugins).returns([PeopleBlockPlugin.new])
   end
@@ -4,8 +4,7 @@ class ProfileDesignControllerTest &lt; ActionController::TestCase
   def setup
     @controller = ProfileDesignController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
+
     Noosfero::Plugin::Manager.any_instance.stubs(:enabled_plugins).returns([PeopleBlockPlugin.new])
   end
@@ -4,8 +4,7 @@ class ProfileControllerTest &lt; ActionController::TestCase
   def setup
     @controller = ProfileController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
+
     Noosfero::Plugin::Manager.any_instance.stubs(:enabled_plugins).returns([PeopleBlockPlugin.new])
   end
@@ -8,8 +8,7 @@ class RelevantContentBlockTest &lt; ActiveSupport::TestCase
   def setup
     @controller = CommentController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
+
     @profile = create_user('testinguser').person
     @environment = @profile.environment
   end
@@ -9,8 +9,6 @@ class RelevantContentBlockTest &lt; ActiveSupport::TestCase
   def setup
     @controller = CommentController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
     @profile = create_user('testinguser').person
     @environment = @profile.environment
@@ -2,6 +2,8 @@ require &#39;test_helper&#39;
 class AccountControllerTest < ActionController::TestCase
   def setup
+    @controller = AccountController.new
+
     @environment = Environment.default
     @environment.enabled_plugins = ['RemoteUserPlugin']
     @environment.save
@@ -9,10 +11,6 @@ class AccountControllerTest &lt; ActionController::TestCase
     @another_environment = Environment.new(name: "AnotherEnvironment")
     @another_environment.enabled_plugins = ['RemoteUserPlugin']
     @another_environment.save
-
-    @controller = AccountController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
   end
   should 'not authenticate user if there is no remote user' do
@@ -5,8 +5,7 @@ class ShoppingCartPluginControllerTest &lt; ActionController::TestCase
   def setup
     @controller = ShoppingCartPluginController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
+
     @profile = fast_create(Enterprise)
     @profile.contact_email = 'enterprise@noosfero.org';@profile.save
     @product = fast_create(Product, profile_id: @profile.id)
@@ -5,8 +5,6 @@ class ContentViewerControllerTest &lt; ActionController::TestCase
   def setup
     @controller = ContentViewerController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
     @profile = create_user('testinguser').person
     @environment = @profile.environment
@@ -4,14 +4,12 @@ require_relative &#39;../../lib/ext/facets_browse&#39;
 class SearchControllerTest < ActionController::TestCase
   def setup
+    @controller = SearchController.new
+
     TestSolr.enable
     p1 = File.join(RAILS_ROOT, 'app', 'views')
     p2 = File.join(File.dirname(__FILE__) + '/../../views')
     SearchController.append_view_path([p1,p2])
-    @controller = SearchController.new
-    @request    = ActionController::TestRequest.new
-    @request.stubs(:ssl?).returns(false)
-    @response   = ActionController::TestResponse.new
     @category = Category.create!(:name => 'my category', :environment => Environment.default)
@@ -4,8 +4,7 @@ require_relative &#39;../../controllers/spaminator_plugin_admin_controller&#39;
 class SpaminatorPluginAdminControllerTest < ActionController::TestCase
   def setup
     @controller = SpaminatorPluginAdminController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
+
     @environment = Environment.default
     @settings = Noosfero::Plugin::Settings.new(@environment, SpaminatorPlugin)
     login_as(create_admin_user(@environment))
@@ -19,8 +19,6 @@ class AccountControllerTest &lt; ActionController::TestCase
   def setup
     @controller = AccountController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
     StoaPlugin::UspUser.create!({:codpes => 12345678, :cpf => Digest::MD5.hexdigest(SALT+'12345678'), :birth_date => '1970-01-30'}, :without_protection => true)
     Environment.default.enable_plugin(StoaPlugin.name)
     @user = create_user('joao-stoa', {:password => 'pass', :password_confirmation => 'pass'},:usp_id=>'87654321')
@@ -5,8 +5,7 @@ class InviteControllerTest &lt; ActionController::TestCase
   def setup
     @controller = InviteController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
+
     environment = Environment.default
     environment.enabled_plugins = ['StoaPlugin']
     environment.save!
@@ -7,8 +7,7 @@ class StoaPluginProfileEditorControllerTest &lt; ActionController::TestCase
   def setup
     @controller = ProfileEditorController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
+
     @person = User.create(:login => 'test_user', :email => 'test_user@example.com', :password => 'test', :password_confirmation => 'test').person
     login_as(@person.identifier)
     Environment.default.enable_plugin(StoaPlugin.name)
@@ -7,8 +7,6 @@ class StoaPluginControllerTest &lt; ActionController::TestCase
   def setup
     @controller = StoaPluginController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
     ApplicationRecord.configurations['stoa'] = {:adapter => 'sqlite3', :database => ':memory:', :verbosity => 'quiet'}
     env = Environment.default
     env.enable_plugin(StoaPlugin.name)
@@ -7,8 +7,7 @@ class SubOrganizationsPluginMyprofileController; def rescue_action(e) raise e en
 class SubOrganizationsPluginMyprofileControllerTest < ActionController::TestCase
   def setup
     @controller = SubOrganizationsPluginMyprofileController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
+
     @organization = Organization.create!(:name => 'My Organization', :identifier => 'my-organization')
     @person = create_user('person').person
     @organization.add_admin(@person)
@@ -8,8 +8,7 @@ class SubOrganizationsPluginProfileControllerTest &lt; ActionController::TestCase
   def setup
     @controller = SubOrganizationsPluginProfileController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
+
     @organization = Organization.create!(:name => 'My Organization', :identifier => 'my-organization')
     @person = create_user('person').person
     @organization.add_admin(@person)
@@ -4,8 +4,6 @@ class EnvironmentDesignControllerTest &lt; ActionController::TestCase
   def setup
     @controller = EnvironmentDesignController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
     Environment.delete_all
     User.delete_all
@@ -4,8 +4,6 @@ class ProfileDesignControllerTest &lt; ActionController::TestCase
   def setup
     @controller = ProfileDesignController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
     user = create_user('testinguser')
     login_as(user.login)
@@ -5,8 +5,7 @@ class CmsControllerTest &lt; ActionController::TestCase
   def setup
     @controller = CmsController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
+
     @person = create_user('test_user').person
     login_as :test_user
     e = Environment.default
@@ -5,8 +5,7 @@ class ContentViewerControllerTest &lt; ActionController::TestCase
   def setup
     @controller = ContentViewerController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
+
     @profile = create_user('testinguser').person
     @organization = fast_create(Organization)
@@ -5,8 +5,7 @@ class WorkAssignmentPluginMyprofileControllerTest &lt; ActionController::TestCase
   def setup
     @controller = WorkAssignmentPluginMyprofileController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
+
     @person = create_user('test_user').person
     login_as :test_user
     e = Environment.default
@@ -5,7 +5,6 @@ class BoxesTest &lt; ActiveSupport::TestCase
   def setup
     create_and_activate_user
     login_api
-#    @request = ActionController::TestRequest.new
   end
   kinds= %w[Profile Community Person Enterprise Environment]
@@ -11,8 +11,7 @@ class AccountControllerTest &lt; ActionController::TestCase
   def setup
     @controller = AccountController.new
-    @request = ActionController::TestRequest.new
-    @response = ActionController::TestResponse.new
+
     disable_signup_bot_check
   end
@@ -6,8 +6,7 @@ class AdminPanelControllerTest &lt; ActionController::TestCase
   all_fixtures
   def setup
     @controller = AdminPanelController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
+
     login_as(create_admin_user(Environment.default))
   end
@@ -4,10 +4,9 @@ require &#39;test_controller&#39;
 class ApplicationControllerTest < ActionController::TestCase
   all_fixtures
+
   def setup
     @controller = TestController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
   end
   def test_detection_of_environment_by_host
@@ -50,7 +49,7 @@ class ApplicationControllerTest &lt; ActionController::TestCase
     current = fast_create(Environment, :name => 'test environment')
     current.domains.create!(:name => 'example.com')
-    @request.expects(:host).returns('example.com').at_least_once
+    @request.env['HTTP_HOST'] = 'example.com'
     get :index
     assert_equal current, assigns(:environment)
@@ -5,8 +5,6 @@ class CategoriesControllerTest &lt; ActionController::TestCase
   all_fixtures
   def setup
     @controller = CategoriesController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
     @env = fast_create(Environment, :name => "My test environment")
     Environment.stubs(:default).returns(env)
@@ -5,8 +5,6 @@ class CommentControllerTest &lt; ActionController::TestCase
   def setup
     @controller = CommentController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
     @profile = create_user('testinguser').person
     @environment = @profile.environment
@@ -8,8 +8,6 @@ class ContactControllerTest &lt; ActionController::TestCase
   def setup
     @controller = ContactController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
     @profile = create_user('contact_test_user').person
     @enterprise = fast_create(Enterprise, :identifier => 'contact_test_enterprise', :name => 'Test contact enteprise')
@@ -7,8 +7,6 @@ class ContentViewerControllerTest &lt; ActionController::TestCase
   def setup
     @controller = ContentViewerController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
     @profile = create_user('testinguser').person
     @environment = @profile.environment
@@ -220,8 +218,7 @@ class ContentViewerControllerTest &lt; ActionController::TestCase
     profile.domains << Domain.create!(:name => 'micojones.net')
     profile.save!
-    ActionController::TestRequest.any_instance.expects(:host).returns('www.micojones.net').at_least_once
-
+    @request.env['HTTP_HOST'] = 'www.micojones.net'
     get :view_page, :page => []
     assert_equal profile, assigns(:profile)
@@ -7,8 +7,7 @@ class EditTemplateControllerTest &lt; ActionController::TestCase
   all_fixtures
   def setup
     @controller = EditTemplateController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
+
     login_as 'ze'
   end
@@ -9,8 +9,7 @@ class EnterpriseRegistrationControllerTest &lt; ActionController::TestCase
   def setup
     super
     @controller = EnterpriseRegistrationController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
+
     login_as 'ze'
   end
@@ -7,8 +7,6 @@ class EnterpriseValidationControllerTest &lt; ActionController::TestCase
   def setup
     @controller = EnterpriseValidationController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
     login_as 'ze'
     @user = Profile['ze']
@@ -7,8 +7,7 @@ class EnvironmentDesignControllerTest &lt; ActionController::TestCase
   def setup
     @controller = EnvironmentDesignController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
+
     Noosfero::Plugin::Manager.any_instance.stubs(:enabled_plugins).returns([])
   end
@@ -4,8 +4,6 @@ require &#39;environment_role_manager_controller&#39;
 class EnvironmentRoleManagerControllerTest < ActionController::TestCase
   def setup
     @controller = EnvironmentRoleManagerController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
   end
 end
@@ -4,8 +4,6 @@ class EnvironmentThemesControllerTest &lt; ActionController::TestCase
   def setup
     @controller = EnvironmentThemesController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
     Theme.stubs(:user_themes_dir).returns(TMP_THEMES_DIR)
@@ -6,8 +6,6 @@ class FavoriteEnterprisesControllerTest &lt; ActionController::TestCase
   self.default_params = {profile: 'testuser'}
   def setup
     @controller = FavoriteEnterprisesController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
     self.profile = create_user('testuser').person
     self.favorite_enterprise = fast_create(Enterprise, :name => 'the_enterprise', :identifier => 'the_enterprise')
@@ -6,8 +6,6 @@ class FeaturesControllerTest &lt; ActionController::TestCase
   all_fixtures
   def setup
     @controller = FeaturesController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
     login_as(create_admin_user(Environment.find(2)))
   end
@@ -6,8 +6,6 @@ class FriendsControllerTest &lt; ActionController::TestCase
   self.default_params = {profile: 'testuser'}
   def setup
     @controller = FriendsController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
     self.profile = create_user('testuser').person
     self.friend = create_user('thefriend').person
@@ -10,8 +10,6 @@ class HomeControllerTest &lt; ActionController::TestCase
   all_fixtures
   def setup
     @controller = HomeController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
   end
   should 'not display news from portal if disabled in environment' do
@@ -5,8 +5,7 @@ class LicensesControllerTest &lt; ActionController::TestCase
   def setup
     @controller = LicensesController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
+
     @environment = Environment.default
     login_as(create_admin_user(@environment))
   end
@@ -4,8 +4,7 @@ class MailconfControllerTest &lt; ActionController::TestCase
   def setup
     @controller = MailconfController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
+
     User.destroy_all
     @user = create_user('ze')
@@ -5,8 +5,6 @@ class MapBalloonControllerTest &lt; ActionController::TestCase
   def setup
     @controller = MapBalloonController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
     @profile = create_user('test_profile').person
     login_as(@profile.identifier)
@@ -6,8 +6,6 @@ class MapsControllerTest &lt; ActionController::TestCase
   def setup
     @controller = MapsController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
     @profile = create_user('test_profile').person
     login_as(@profile.identifier)
@@ -7,8 +7,6 @@ class MembershipsControllerTest &lt; ActionController::TestCase
   def setup
     @controller = MembershipsController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
     @profile = create_user('testuser').person
     login_as('testuser')
@@ -13,8 +13,6 @@ class MyProfileControllerTest &lt; ActionController::TestCase
   all_fixtures
   def setup
     @controller = MyProfileController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
   end
   def test_should_allow_person
@@ -5,8 +5,6 @@ class OrganizationsControllerTest &lt; ActionController::TestCase
   def setup
     @controller = OrganizationsController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
     @environment = Environment.default
@@ -6,8 +6,7 @@ class PluginsControllerTest &lt; ActionController::TestCase
   all_fixtures
   def setup
     @controller = PluginsController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
+
     @environment = Environment.default
     login_as(create_admin_user(@environment))
   end
@@ -11,8 +11,6 @@ class ProfileDesignControllerTest &lt; ActionController::TestCase
   attr_reader :holder
   def setup
     @controller = ProfileDesignController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
     @profile = @holder = create_user('designtestuser').person
     holder.save!
@@ -6,8 +6,7 @@ class ProfileEditorControllerTest &lt; ActionController::TestCase
   def setup
     @controller = ProfileEditorController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
+
     @profile = create_user('default_user').person
     Environment.default.affiliate(@profile, [Environment::Roles.admin(Environment.default.id)] + Profile::Roles.all_roles(Environment.default.id))
     login_as('default_user')
@@ -643,9 +642,10 @@ class ProfileEditorControllerTest &lt; ActionController::TestCase
     profile.domains << Domain.new(:name => 'myowndomain.net')
     profile.environment.domains << Domain.new(:name => 'myenv.net')
-    ActionController::TestRequest.any_instance.stubs(:host).returns(profile.hostname)
+    @request.env['HTTP_HOST'] = profile.hostname
     get :edit, :profile => profile.identifier
+
     assert_tag :tag => 'select', :attributes => { :name => 'profile_data[preferred_domain_id]' }, :descendant => { :tag => "option", :content => 'myowndomain.net' }
     assert_tag :tag => 'select', :attributes => { :name => 'profile_data[preferred_domain_id]' }, :descendant => { :tag => "option", :content => 'myenv.net' }
@@ -659,9 +659,10 @@ class ProfileEditorControllerTest &lt; ActionController::TestCase
     profile.domains << Domain.new(:name => 'myowndomain.net')
     profile.environment.domains << Domain.new(:name => 'myenv.net')
-    ActionController::TestRequest.any_instance.stubs(:host).returns(profile.hostname)
+    @request.env['HTTP_HOST'] = profile.hostname
     get :edit, :profile => profile.identifier
+
     assert_tag :tag => "select", :attributes => { :name => 'profile_data[preferred_domain_id]'}, :descendant => { :tag => 'option', :content => '&lt;Select domain&gt;', :attributes => { :value => '' } }
     post :edit, :profile => profile.identifier, :profile_data => { :preferred_domain_id => '' }
@@ -1112,8 +1113,10 @@ class ProfileEditorControllerTest &lt; ActionController::TestCase
   should 'not redirect if the profile_hostname is the same as environment hostname' do
     Person.any_instance.stubs(:hostname).returns('hostname.org')
     Environment.any_instance.stubs(:default_hostname).returns('hostname.org')
-    ActionController::TestRequest.any_instance.stubs(:host).returns('hostname.org')
+
+    @request.env['HTTP_HOST'] = 'hostname.org'
     get :index, :profile => profile.identifier
+
     assert_response :success
   end
@@ -5,8 +5,6 @@ class ProfileMembersControllerTest &lt; ActionController::TestCase
   def setup
     super
     @controller = ProfileMembersController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
   end
   should 'not access index if dont have permission' do
@@ -5,8 +5,7 @@ class ProfileRolesControllerTest &lt; ActionController::TestCase
   def setup
     @controller = ProfileRolesController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
+
     @role = Role.first
   end
@@ -4,8 +4,6 @@ require &#39;profile_search_controller&#39;
 class ProfileSearchControllerTest < ActionController::TestCase
   def setup
     @controller = ProfileSearchController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
     @person = fast_create(Person)
   end
@@ -4,8 +4,6 @@ class ProfileThemesControllerTest &lt; ActionController::TestCase
   def setup
     @controller = ProfileThemesController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
     Theme.stubs(:user_themes_dir).returns(TMP_THEMES_DIR)
@@ -5,8 +5,7 @@ class RegionValidatorsControllerTest &lt; ActionController::TestCase
   all_fixtures
   def setup
     @controller = RegionValidatorsController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
+
     login_as('ze')
   end
@@ -6,8 +6,7 @@ class RoleControllerTest &lt; ActionController::TestCase
   def setup
     @controller = RoleController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
+
     @role = Role.first
     login_as(:ze)
   end
@@ -4,9 +4,6 @@ class SearchControllerTest &lt; ActionController::TestCase
   def setup
     @controller = SearchController.new
-    @request    = ActionController::TestRequest.new
-    @request.stubs(:ssl?).returns(false)
-    @response   = ActionController::TestResponse.new
     @environment = Environment.default
     @category = Category.create!(:name => 'my-category', :environment => @environment)
@@ -4,8 +4,6 @@ require &#39;system_controller&#39;
 class SystemControllerTest < ActionController::TestCase
   def setup
     @controller = SystemController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
   end
   # Replace this with your real tests.
@@ -7,8 +7,6 @@ class TasksControllerTest &lt; ActionController::TestCase
   def setup
     @controller = TasksController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
     self.profile = create_user('testuser').person
     @controller.stubs(:profile).returns(profile)
@@ -5,8 +5,6 @@ class TemplatesControllerTest &lt; ActionController::TestCase
   def setup
     @controller = TemplatesController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
     @environment = Environment.default
     login_as(create_admin_user(@environment))
@@ -6,8 +6,7 @@ class TrustedSitesControllerTest &lt; ActionController::TestCase
   def setup
     @controller = TrustedSitesController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
+
     @role = Role.first
     @environment = Environment.default
     @environment.trusted_sites_for_iframe = ['existing.site.com']
@@ -5,8 +5,6 @@ class UsersControllerTest &lt; ActionController::TestCase
   def setup
     @controller = UsersController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
     @environment = Environment.default
@@ -4,8 +4,6 @@ class PermissionCheckTest &lt; ActionController::TestCase
   def setup
     @controller = AccessControlTestController.new
-    @request    = ActionController::TestRequest.new
-    @response   = ActionController::TestResponse.new
   end
   def test_access_denied
@@ -54,12 +54,11 @@ ActionController::Routing::Routes.draw { |map| map.resources :things, :collectio
 class ActionTrackerTest < ActiveSupport::TestCase
   def setup
+    @controller = ThingsController.new
+
     ActionTrackerConfig.current_user = proc{ SomeModel.first || SomeModel.create! }
     ActionTracker::Record.delete_all
     ActionTrackerConfig.verbs = { :some_verb => { :description => "Did something" } }
-    @request = ActionController::TestRequest.new
-    @response = ActionController::TestResponse.new
-    @controller = ThingsController.new
   end
   def test_index
	@@ -8,8 +8,7 @@ end		@@ -8,8 +8,7 @@ end
8	class AccountControllerTest < ActionController::TestCase	8	class AccountControllerTest < ActionController::TestCase
9	def setup	9	def setup
10	@controller = AccountController.new	10	@controller = AccountController.new
11	- @request = ActionController::TestRequest.new
12	- @response = ActionController::TestResponse.new	11	+
13	@person = create_user('person').person	12	@person = create_user('person').person
14		13
15	@environment = Environment.default	14	@environment = Environment.default
	@@ -7,8 +7,6 @@ require(		@@ -7,8 +7,6 @@ require(
7	class AdminNotificationsPluginMyprofileControllerTest < ActionController::TestCase	7	class AdminNotificationsPluginMyprofileControllerTest < ActionController::TestCase
8	def setup	8	def setup
9	@controller = AdminNotificationsPluginMyprofileController.new	9	@controller = AdminNotificationsPluginMyprofileController.new
10	- @request = ActionController::TestRequest.new
11	- @response = ActionController::TestResponse.new
12	@person = create_user('person').person	10	@person = create_user('person').person
13	@community = fast_create(Community)	11	@community = fast_create(Community)
14		12
	@@ -7,8 +7,6 @@ require(		@@ -7,8 +7,6 @@ require(
7	class AdminNotificationsPluginPublicControllerTest < ActionController::TestCase	7	class AdminNotificationsPluginPublicControllerTest < ActionController::TestCase
8	def setup	8	def setup
9	@controller = AdminNotificationsPluginPublicController.new	9	@controller = AdminNotificationsPluginPublicController.new
10	- @request = ActionController::TestRequest.new
11	- @response = ActionController::TestResponse.new
12	@person = create_user('person').person	10	@person = create_user('person').person
13		11
14	@environment = Environment.default	12	@environment = Environment.default
	@@ -7,8 +7,7 @@ end		@@ -7,8 +7,7 @@ end
7	class HomeControllerTest < ActionController::TestCase	7	class HomeControllerTest < ActionController::TestCase
8	def setup	8	def setup
9	@controller = HomeController.new	9	@controller = HomeController.new
10	- @request = ActionController::TestRequest.new
11	- @response = ActionController::TestResponse.new	10	+
12	@person = create_user('person').person	11	@person = create_user('person').person
13		12
14	@environment = Environment.default	13	@environment = Environment.default
	@@ -5,8 +5,6 @@ class ContentViewerControllerTest < ActionController::TestCase		@@ -5,8 +5,6 @@ class ContentViewerControllerTest < ActionController::TestCase
5		5
6	def setup	6	def setup
7	@controller = ContentViewerController.new	7	@controller = ContentViewerController.new
8	- @request = ActionController::TestRequest.new
9	- @response = ActionController::TestResponse.new
10		8
11	@environment = Environment.default	9	@environment = Environment.default
12	@environment.enabled_plugins += ['AnalyticsPlugin']	10	@environment.enabled_plugins += ['AnalyticsPlugin']
	@@ -5,8 +5,6 @@ class CommentGroupPluginProfileControllerTest < ActionController::TestCase		@@ -5,8 +5,6 @@ class CommentGroupPluginProfileControllerTest < ActionController::TestCase
5		5
6	def setup	6	def setup
7	@controller = CommentGroupPluginProfileController.new	7	@controller = CommentGroupPluginProfileController.new
8	- @request = ActionController::TestRequest.new
9	- @response = ActionController::TestResponse.new
10		8
11	@profile = create_user('testuser').person	9	@profile = create_user('testuser').person
12	@article = profile.articles.build(:name => 'test')	10	@article = profile.articles.build(:name => 'test')
	@@ -5,8 +5,6 @@ class DisplayContentPluginAdminControllerTest < ActionController::TestCase		@@ -5,8 +5,6 @@ class DisplayContentPluginAdminControllerTest < ActionController::TestCase
5		5
6	def setup	6	def setup
7	@controller = DisplayContentPluginAdminController.new	7	@controller = DisplayContentPluginAdminController.new
8	- @request = ActionController::TestRequest.new
9	- @response = ActionController::TestResponse.new
10		8
11	@environment = Environment.default	9	@environment = Environment.default
12	user_login = create_admin_user(@environment)	10	user_login = create_admin_user(@environment)
	@@ -7,8 +7,7 @@ class AccountControllerTest < ActionDispatch::IntegrationTest		@@ -7,8 +7,7 @@ class AccountControllerTest < ActionDispatch::IntegrationTest
7		7
8	def setup	8	def setup
9	@controller = AccountController.new	9	@controller = AccountController.new
10	- @request = ActionController::TestRequest.new
11	- @response = ActionController::TestResponse.new	10	+ @request = ActionController::TestRequest.new
12		11
13	e = Environment.default	12	e = Environment.default
14	e.enable 'skip_new_user_email_confirmation', true	13	e.enable 'skip_new_user_email_confirmation', true
	@@ -5,8 +5,6 @@ class GoogleCsePluginControllerTest < ActionController::TestCase		@@ -5,8 +5,6 @@ class GoogleCsePluginControllerTest < ActionController::TestCase
5		5
6	def setup	6	def setup
7	@controller = GoogleCsePluginController.new	7	@controller = GoogleCsePluginController.new
8	- @request = ActionController::TestRequest.new
9	- @response = ActionController::TestResponse.new
10	end	8	end
11		9
12	should 'get results page' do	10	should 'get results page' do
	@@ -7,8 +7,6 @@ class ContentViewerControllerTest < ActionController::TestCase		@@ -7,8 +7,6 @@ class ContentViewerControllerTest < ActionController::TestCase
7		7
8	def setup	8	def setup
9	@controller = ContentViewerController.new	9	@controller = ContentViewerController.new
10	- @request = ActionController::TestRequest.new
11	- @response = ActionController::TestResponse.new
12		10
13	@profile = create_user('testinguser').person	11	@profile = create_user('testinguser').person
14	@environment = @profile.environment	12	@environment = @profile.environment