25 Mar, 2016
1 commit
-
It now uses BoxesHelper logic instead of HTML generation within the model violating MVC. As it is a class within a module (`ContainerBlockPlugin::ContainerBlock`) `BoxesHelper` required fixes to handle the module prefix when searching for the proper view to render. Previously it would wrongly search for `blocks/container_block_plugin/container.html.erb` instead of `blocks/container.html.erb`.
24 Mar, 2016
10 commits
-
Makes max_size uniform between UploadedFile and Thumbnail closes #152 See merge request !804
-
Improve oauth client This MR is related to oauth-client plugin. Fix a bug in edit of providers and improve documentation. Making this plugin up-to-date. See merge request !821
23 Mar, 2016
10 commits
-
Decouple people block plugin Model html generation As a follow up for !803. This applies the same refactor to PeopleBlockPlugin removing HTML generation from models. Here is a build: https://travis-ci.org/rafamanzo/noosfero/builds/117720302 As it involved many changes, I figured it would be worth of its own MR. I'll work on other block plugins refactor following. Please let me know if you do not want one MR for each. See merge request !817
-
Signed-off-by: Lucas Kanashiro <kanashiro.duarte@gmail.com> Signed-off-by: Macartur Sousa <macartur.sc@gmail.com>
-
Signed-off-by: Lucas Kanashiro <kanashiro.duarte@gmail.com> Signed-off-by: Macartur Sousa <macartur.sc@gmail.com>
-
Keep filters after close tasks See merge request !798
-
- Rename TasksHelper file - Referencing TasksHelper in TaskController - Refactoring task_action/url helper method - Manage tasks feature - Update SuggetstArticle step - Adds functional test for keeping tasks filter Signed-off-by: Alexandre Barbosa <alexandreab@live.com> Signed-off-by: Joenio Costa <joenio@colivre.coop.br> Signed-off-by: Ábner Silva de Oliveira <abner.oliveira@serpro.gov.br> Signed-off-by: Gustavo Jaruga <darkshades@gmail.com> Signed-off-by: Marcos Ronaldo <marcos.rpj2@gmail.com>
-
This method was producing view code from within the model which is a violation of MVC. Part of the code was extracted into the new helper and most of it became a view. This follow the standard for using BoxesHelper#render_block_footer.
-
This method was producing view code from within the model which is a violation of MVC. Part of the code was extracted into the new helper and most of it became a view. This follow the standard for using BoxesHelper#render_block_content.
-
The method for build profile_image_link was part of ApplicationHelper but will also be necessary for building proper tests on a upcoming refactor for PeopleBlockPlugin. As including ApplicationHelper on unit tests has already caused issues with unwanted block behaviour regarding their visibility, this is a move in the direction of avoiding such issues before they happen and allow reliable future tests.
-
comment: make explicit fail-safe relation with profile and environment This tests are necessary because comment estabilishes a polymorphic relation with the source, which creates harsh conditions to determine how to relate it with the environment. See merge request !819
22 Mar, 2016
12 commits
-
This tests are necessary because comment estabilishes a polymorphic relation with the source, which creates harsh conditions to determine how to relate it with the environment.
-
gitlab-ci: temporarily disabling smoke test Selenium tests are failing randomly. This makes smoke tests to almost always fail, avoiding other tests to run. See merge request !818
-
Selenium tests are failing randomly. This makes smokes tests to almost always fail, avoiding other tests to run.
-
sniffer: drop sniffer_plugin_profiles table Changed pulled from ESCAMBO See merge request !809
-
plugin-hotspot: dinamic hotspot for models callbacks With this, every model that includes Noosfero::Plugin::HotSpot will provide callbacks hotspots for plugins to answer. The current callbacks included are {after,before}_{create,destroy,save}. So if a plugin wants to do something on a comment after_save, it should define a hotspot somewhat like this: def comment_after_save_callback(comment) <code-goes-here> end Obviously, the callback provides the object in context as parameter. This will replace the problematic common practice of creating a lib/ext/my_model.rb and injecting the callbacks inside the class which bypass the enabled plugins logic. Signed-off-by: Rodrigo Souto <rodrigo@colivre.coop.br> Signed-off-by: Marcos Ronaldo <marcos.rpj2@gmail.com> See merge request !810 -
Removes date fields format customization Aims to fix a bug where the _datepicker_ component was not able to correctly retrieve the date displayed in the text field due format compatibility. Since there is no reliable way to convert the formats (used by `strftime` and the _datepicker_), the option to customize the date format was removed from the `date_field` and `date_range_field` helpers. See merge request !811
-
API Improvements this MR is the same of !801 with some updates: * updated with master * added missing ruby-api-pagination dependency See merge request !815
21 Mar, 2016
5 commits
-
Signed-off-by: Marcos Ronaldo <marcos.rpj2@gmail.com> Signed-off-by: Joenio Costa <joenio@colivre.coop.br>
-
With this, every model that includes Noosfero::Plugin::HotSpot will provide callbacks hotspots for plugins to answer. The current callbacks included are {after,before}_{create,destroy,save}. So if a plugin wants to do something on a comment after_save, it should define a hotspot somewhat like this: def comment_after_save_callback(comment) <code-goes-here> end Obviously, the callback provides the object in context as parameter. This will replace the problematic common practice of creating a lib/ext/my_model.rb and injecting the callbacks inside the class which bypass the enabled plugins logic. Signed-off-by: Rodrigo Souto <rodrigo@colivre.coop.br> Signed-off-by: Marcos Ronaldo <marcos.rpj2@gmail.com>
18 Mar, 2016
1 commit
-
Signed-off-by: Gabriel Silva <gabriel93.silva@gmail.com>
17 Mar, 2016
1 commit