15 Mar, 2016
1 commit
-
Decouple html creation from models into helpers This is a work started by @joenio and continued by @danielafeitosa for which I have just fixed failling tests and some minor issues created by the refactor. This MR adds just the fixes that do not involve plugins. As I've discussed with @diguliu there ill be separate MRs for plugins allowing easier review e clean merges. See merge request !803
14 Mar, 2016
2 commits
-
Currently translated at 100.0% (15 of 15 strings)
-
Currently translated at 100.0% (2124 of 2124 strings)
12 Mar, 2016
4 commits
-
If is weirdly failing (https://gitlab.com/noosfero/noosfero/builds/852331)
-
This avoid unexpected failures with different environments defaults
10 Mar, 2016
30 commits
-
It was extracted into a helper and view which are the correct handlers for such logic.
-
This is one more step into decoupling HTML generation from models. All models with such method are expected to go through this refactor.
-
This was a missing refactor from bbf064e9b984a6ca29ff543e486f5b256bc46b2d.
-
After creating the ArticleBlock view test at ff15413b2a8dca45d9f64e57270f294e351a0098 this test got broken. The root cause was the inclusion of ApplicationHelper for the article_block_test which led to `custom_options_article` for CMSHelper tests to fail as the BlogHelper (included by ApplicationHelper) was overriding the method. This has been fized by remove the include to ApplicationHelper and extract the necessary methods to separate helpers which led to two new methods for ArticleHelper and one new helper the ButtonsHelper.
-
After removing the content method it is now necessary to use BoxesHelper#render_block_content.
-
By removing the content method, it is now necessary to turn the test into a view one using the BoxesHelper method and properly stubbing other helpers. This was inspired by the same conversion made by commit 23cca52cdaea5cc3b46e4982f30ad3426891e2f2 on MyNetworkBlock test.
-
By removing the content method, it is now necessary to turn the test into a view one using the BoxesHelper method and properly stubbing other helpers.
-
By removing the content method, it is now necessary to turn the test into a view one using the BoxesHelper method and properly stubbing other helpers. The view required fix at the html escaping method call synthax.
-
After removing the content method it is now necessary to use BoxesHelper#render_block_content. The view required fixes as it was still supposing the old interface coupled into the model instead of receiving the model object. And it had a programming error that prevented results from getting displayed.
-
After removing the content method it is now necessary to use BoxesHelper#render_block_content.
-
After removing the content method it is now necessary to use BoxesHelper#render_block_content.
-
After removing the content method it is now necessary to use BoxesHelper#render_block_content.
-
By removing the content method, it is now necessary to turn the test into a view one using the BoxesHelper method and properly stubbing other helpers. This was inspired by the same conversion made by commit 23cca52cdaea5cc3b46e4982f30ad3426891e2f2 on MyNetworkBlock test.
-
By removing the content method, it is now necessary to turn the test into a view one. This was inspired by the same conversion made by commit 23cca52cdaea5cc3b46e4982f30ad3426891e2f2 on MyNetworkBlock test.
-
After the extraction of HTML dependencies into helpers it has been broken.
-
also: * rename login_block.html.erb -> login.html.erb * created symlinks for ProfileListBlock subclasses
09 Mar, 2016
3 commits
-
Add primary key to article follower table to fix has many through association The article follower table does not have the primary key. When we have has_many through association this key is needed. I made some tests for increase and decrease followers_count column that was not working properly because of this See merge request !805
