Merge Request #2

← To merge requests From gitlab_integration into master
Merged
softwarepublico/omniauth-remote-user!2
Created by Thiago Ribeiro

Gitlab integration

Quick changes beacuse:

  • New heder name for user data.
  • Publish gem.
Assignee: Antonio Terceiro
Milestone: None

Merged by Antonio Terceiro

Source branch has been removed
Commits (2)
3 participants
  • 75e3b052e046e34cbb10917c5f9901d7?s=40&d=identicon
    Link here  
    Antonio Terceiro @terceiro

    make sure to tag the exact version you publish to rubygems

    Choose File ...   File name...
    Cancel
  • 800e3af93350753db9dee1864cef10ff?s=40&d=identicon
    Link here  
    Thiago Ribeiro @thiago

    Ok, that's really a good pratice. Done.

    Choose File ...   File name...
    Cancel
    • 9fe63c7bd60deeb55e409a1d7dd173f5?s=40&d=identicon
    Show/hide discussion
    Sergio Oliveira started a discussion on the diff
    last updated by Sergio Oliveira
    lib/omniauth/strategies/remote_user.rb
    70 70 end
    71 71  
    72 72 info do
    73   - user_data = request.env['HTTP_REMOTE_USER_DATA']
      73 + user_data = request.env['X_REMOTE_USER_DATA']
    1
    • 9fe63c7bd60deeb55e409a1d7dd173f5?s=40&d=identicon
      Link here  
      Sergio Oliveira @seocam

      I believe the header name should come with the prefix HTTP_ still. Actually that's something the CGI handler will add to all (or mostly) the headers. Am I right @terceiro?

      Choose File ...   File name...
      Cancel
  • 800e3af93350753db9dee1864cef10ff?s=40&d=identicon
    Link here  
    Thiago Ribeiro @thiago

    @seocam I believe you're right , when this change will be in colab ? We will test as soon as possible .

    Choose File ...   File name...
    Cancel
  • 9fe63c7bd60deeb55e409a1d7dd173f5?s=40&d=identicon
    Link here  
    Sergio Oliveira @seocam

    @thiagitosouza feel free to send a MR! ;)

    Choose File ...   File name...
    Cancel