Download as
Browse Code »

Commit 0c5d448b16b6fa1797c75da2760213ce9278295e

Authored by Leandro Santos
1 parent af89dbce
Exists in master and in 28 other branches 1.2+SPB2, 2_split_by_role, add_fields_in_api, api_fixies, api_pagination, api_private_token, api_tasks, article_hit_count, blog_page_bug, checkbox_to_user_can_edit_page, communities_ratings, communities_ratings_moderation, community_ratings_rebase, fix_cloned_article_parent, fix_gallery_image_url, fix_javascript_categories, fix_optional_fields, fix_suggest_article, fix_user_email_validation, highlight_block_fix, notification_plugin, notification_plugin_rebase, script_to_update, split_by_role, stable, temp_ratings, tests, tests_fixies

ActionItem2131: Hidding sensible information of person and community profile's

Showing 3 changed files with 19 additions and 10 deletions   Show diff stats
app/views/profile/_profile.rhtml
  Diff comments   View file @0c5d448
... ... @@ -11,19 +11,14 @@
11 11 <% end %>
12 12  
13 13 <% if @profile.organization? %>
14   - <% if @profile.public? || (logged_in? && current_person.follows?(@profile)) %>
15   - <% tabs << {:title => _('What\'s new'), :id => 'profile-network', :content => (render :partial => 'profile_network')} %>
16   - <% end %>
  14 + <% tabs << {:title => _('What\'s new'), :id => 'profile-network', :content => (render :partial => 'profile_network')} %>
17 15 <% tabs << {:title => _('Profile'), :id => 'organization-profile', :content => (render :partial => 'organization_profile')} %>
18 16 <% elsif @profile.person? %>
19 17 <% if logged_in? && current_person.follows?(@profile) %>
20 18 <% tabs << {:title => _('Network'), :id => 'profile-network', :content => (render :partial => 'profile_network')} %>
21 19 <% end %>
22 20  
23   - <% if @profile.public? || (logged_in? && current_person.follows?(@profile)) %>
24   - <% tabs << {:title => _('Activity'), :id => 'profile-activity', :content => (render :partial => 'profile_activity')} %>
25   - <% end %>
26   -
  21 + <% tabs << {:title => _('Activity'), :id => 'profile-activity', :content => (render :partial => 'profile_activity')} %>
27 22 <% tabs << {:title => _('Profile'), :id => 'person-profile', :content => (render :partial => 'person_profile')} %>
28 23 <% end %>
29 24  
... ...
app/views/profile/index.rhtml
  Diff comments   View file @0c5d448
... ... @@ -15,6 +15,8 @@
15 15 </div>
16 16 <% end %>
17 17  
18   -<table class='profile'>
19   - <%= render :partial => 'profile' %>
20   -</table>
  18 +<% if @profile.public? || (logged_in? && current_person.follows?(@profile)) %>
  19 + <table class='profile'>
  20 + <%= render :partial => 'profile' %>
  21 + </table>
  22 +<% end %>
... ...
features/private_profile.feature
  Diff comments   View file @0c5d448
... ... @@ -40,3 +40,15 @@ Feature: private profiles
40 40 When I am on Safernet's homepage
41 41 Then I should see "What's new"
42 42  
  43 + Scenario: person private profiles should not display sensible information
  44 + Given I am logged in as "joao"
  45 + When I go to shygirl's homepage
  46 + Then I should not see "Basic information"
  47 + Then I should not see "Work"
  48 + Then I should not see "Enterprises"
  49 + Then I should not see "Network"
  50 +
  51 + Scenario: community private profiles should not display sensible information
  52 + Given I am logged in as "joao"
  53 + When I go to Safernet's homepage
  54 + Then I should not see "Basic information"
... ...