Download as
Browse Code »

Commit 0c8eff93411b037fb8374bd149f2f494d675d499

Authored by Antonio Terceiro
1 parent 771ecf69
Exists in master and in 27 other branches 1.2+SPB2, 2_split_by_role, add_fields_in_api, api_fixies, api_pagination, api_private_token, api_tasks, article_hit_count, blog_page_bug, checkbox_to_user_can_edit_page, communities_ratings, communities_ratings_moderation, community_ratings_rebase, fix_cloned_article_parent, fix_gallery_image_url, fix_javascript_categories, fix_optional_fields, fix_suggest_article, fix_user_email_validation, highlight_block_fix, notification_plugin, notification_plugin_rebase, script_to_update, split_by_role, temp_ratings, tests, tests_fixies

rails3: remove useless named scope in Article 

It seems it was created to avoid including too many objects when
retrieving that named_scope, but using :joins instead of :includes
already does this.
Showing 2 changed files with 2 additions and 4 deletions   Show diff stats
app/models/article.rb
  Diff comments   View file @0c8eff9
... ... @@ -217,10 +217,8 @@ class Article < ActiveRecord::Base
217 217 {:conditions => [ 'parent_id is null and profile_id = ?', profile.id ]}
218 218 }
219 219  
220   - scope :join_profile, :joins => [:profile]
221   -
222 220 scope :public,
223   - :conditions => [ "advertise = ? AND published = ? AND profiles.visible = ? AND profiles.public_profile = ?", true, true, true, true ]
  221 + :conditions => [ "advertise = ? AND published = ? AND profiles.visible = ? AND profiles.public_profile = ?", true, true, true, true ], :joins => [:profile]
224 222  
225 223 scope :more_recent,
226 224 :conditions => [ "advertise = ? AND published = ? AND profiles.visible = ? AND profiles.public_profile = ? AND
... ...
test/unit/article_test.rb
  Diff comments   View file @0c8eff9
... ... @@ -1618,7 +1618,7 @@ class ArticleTest < ActiveSupport::TestCase
1618 1618 art4 = Article.create!(:name => 'article 4', :profile_id => fast_create(Person, :visible => false).id)
1619 1619 art5 = Article.create!(:name => 'article 5', :profile_id => fast_create(Person, :public_profile => false).id)
1620 1620  
1621   - articles = Article.join_profile.public
  1621 + articles = Article.public
1622 1622 assert_includes articles, art1
1623 1623 assert_not_includes articles, art2
1624 1624 assert_not_includes articles, art3
... ...