Download as
Browse Code »

Commit 1098be610d999b0a54c80a299a69453dd8f1e7b5

Authored by Antonio Terceiro
1 parent 9593b2d9
Exists in master and in 28 other branches 1.2+SPB2, 2_split_by_role, add_fields_in_api, api_fixies, api_pagination, api_private_token, api_tasks, article_hit_count, blog_page_bug, checkbox_to_user_can_edit_page, communities_ratings, communities_ratings_moderation, community_ratings_rebase, fix_cloned_article_parent, fix_gallery_image_url, fix_javascript_categories, fix_optional_fields, fix_suggest_article, fix_user_email_validation, highlight_block_fix, notification_plugin, notification_plugin_rebase, script_to_update, split_by_role, stable, temp_ratings, tests, tests_fixies

Replacing scary eval's with String#constantize

Showing 2 changed files with 2 additions and 2 deletions   Show diff stats
app/controllers/admin/plugins_controller.rb
  Diff comments   View file @1098be6
1 class PluginsController < AdminController 1 class PluginsController < AdminController
2 2
3 def index 3 def index
4 - @active_plugins = Noosfero::Plugin.all.map {|plugin_name| eval(plugin_name)}.compact 4 + @active_plugins = Noosfero::Plugin.all.map {|plugin_name| plugin_name.constantize }.compact
5 end 5 end
6 6
7 post_only :update 7 post_only :update
lib/noosfero/plugin/manager.rb
  Diff comments   View file @1098be6
@@ -12,7 +12,7 @@ class Noosfero::Plugin::Manager @@ -12,7 +12,7 @@ class Noosfero::Plugin::Manager
12 12
13 def enabled_plugins 13 def enabled_plugins
14 @enabled_plugins ||= (Noosfero::Plugin.all & context.environment.enabled_plugins).map do |plugin| 14 @enabled_plugins ||= (Noosfero::Plugin.all & context.environment.enabled_plugins).map do |plugin|
15 - p = eval(plugin).new 15 + p = plugin.constantize.new
16 p.context = context 16 p.context = context
17 p 17 p
18 end 18 end