Comments created by removed users are displayed

* If the comment was created by a user that now doesn't exist: *In the place of name is displayed "(removed user)" *In the avatar is displayed "unknown user" avatar ActionItem1296

Comments created by removed users are displayed
* If the comment was created by a user that now doesn't exist: *In the place of name is displayed "(removed user)" *In the avatar is displayed "unknown user" avatar ActionItem1296
Daniela Feitosa · Antonio Terceiro
1 parent 2cd8dbb3
Showing 4 changed files with 30 additions and 5 deletions Show diff stats
app/models/comment.rb
app/views/content_viewer/_comment.rhtml
test/functional/content_viewer_controller_test.rb
test/unit/comment_test.rb
@@ -21,9 +21,9 @@ class Comment &lt; ActiveRecord::Base
   def author_name
     if author
-      author.name
+      author.short_name
     else
-      name
+      author_id ? '' : name
     end
   end
@@ -39,6 +39,14 @@ class Comment &lt; ActiveRecord::Base
     article.view_url.merge(:anchor => anchor)
   end
+  def message
+   author_id ? _('(removed user)') : ('<br />' + _('(unauthenticated user)'))
+  end
+
+  def removed_user_image
+    '/images/icons-app/user_icon_size-minor.png'
+  end
+
   def anchor
     "comment-#{id}"
   end
@@ -8,15 +8,16 @@
   <% end %>
   <% if comment.author %>
-    <%= link_to content_tag( 'span', comment.author.short_name, :class => 'comment-info' ), comment.author.url,
+    <%= link_to content_tag( 'span', comment.author_name, :class => 'comment-info' ), comment.author.url,
         :class => 'comment-picture',
         :style => 'background-image:url(%s)' % profile_icon(comment.author, :minor)
     %>
   <% else %>
     <%# unauthenticated user: display gravatar icon %>
-    <%= content_tag 'span', content_tag('span', comment.name + '<br/>'+ _('(unauthenticated user)'), :class => 'comment-info'),
+    <% url_image = comment.author_id ? comment.removed_user_image : str_gravatar_url_for( comment.email, :size => 50 ) %>
+    <%= content_tag 'span', content_tag('span', comment.author_name + comment.message, :class => 'comment-info'),
         :class => 'comment-picture',
-        :style => 'background-image:url(%s)' % str_gravatar_url_for( comment.email, :size => 50 )
+        :style => 'background-image:url(%s)' % url_image
     %>
   <% end %>
@@ -883,4 +883,16 @@ class ContentViewerControllerTest &lt; Test::Unit::TestCase
     post :view_page, :profile => profile.identifier, :page => [ 'myarticle' ], :comment => { :title => 'crap!', :body => 'I think that this article is crap' }
     assert_not_equal yesterday, assigns(:page).updated_at
   end
+
+  should 'display message if user was removed' do
+    article = profile.articles.create(:name => 'comment test')
+    to_be_removed = create_user('removed_user').person
+    comment = article.comments.create(:author => to_be_removed, :title => 'Test Comment', :body => 'My author does not exist =(')
+    to_be_removed.destroy
+
+    get :view_page, :profile => profile.identifier, :page => article.explode_path
+
+    assert_tag :tag => 'span', :content => '(removed user)', :attributes => {:class => 'comment-info'}
+  end
+
 end
@@ -78,6 +78,10 @@ class CommentTest &lt; Test::Unit::TestCase
     assert_equal 'anonymous coward', Comment.new(:name => 'anonymous coward').author_name
   end
+  should 'provide empty text for author name if user was removed ' do
+    assert_equal '', Comment.new(:author_id => 9999).author_name
+  end
+
   should "provide author e-mail for athenticated authors" do
     owner = create_user('testuser').person
     assert_equal owner.email, Comment.new(:author => owner).author_email
	@@ -883,4 +883,16 @@ class ContentViewerControllerTest < Test::Unit::TestCase		@@ -883,4 +883,16 @@ class ContentViewerControllerTest < Test::Unit::TestCase
883	post :view_page, :profile => profile.identifier, :page => [ 'myarticle' ], :comment => { :title => 'crap!', :body => 'I think that this article is crap' }	883	post :view_page, :profile => profile.identifier, :page => [ 'myarticle' ], :comment => { :title => 'crap!', :body => 'I think that this article is crap' }
884	assert_not_equal yesterday, assigns(:page).updated_at	884	assert_not_equal yesterday, assigns(:page).updated_at
885	end	885	end
		886	+
		887	+ should 'display message if user was removed' do
		888	+ article = profile.articles.create(:name => 'comment test')
		889	+ to_be_removed = create_user('removed_user').person
		890	+ comment = article.comments.create(:author => to_be_removed, :title => 'Test Comment', :body => 'My author does not exist =(')
		891	+ to_be_removed.destroy
		892	+
		893	+ get :view_page, :profile => profile.identifier, :page => article.explode_path
		894	+
		895	+ assert_tag :tag => 'span', :content => '(removed user)', :attributes => {:class => 'comment-info'}
		896	+ end
		897	+
886	end	898	end