Download as
Browse Code »

Commit 1668fe7d50803460a247eec5a2d068bb93c2eb08

Authored by Antonio Terceiro
1 parent 10218c1d
Exists in master and in 28 other branches 1.2+SPB2, 2_split_by_role, add_fields_in_api, api_fixies, api_pagination, api_private_token, api_tasks, article_hit_count, blog_page_bug, checkbox_to_user_can_edit_page, communities_ratings, communities_ratings_moderation, community_ratings_rebase, fix_cloned_article_parent, fix_gallery_image_url, fix_javascript_categories, fix_optional_fields, fix_suggest_article, fix_user_email_validation, highlight_block_fix, notification_plugin, notification_plugin_rebase, script_to_update, split_by_role, stable, temp_ratings, tests, tests_fixies

Avoid division by zero on ProfileListBlock 

(ActionItem1682)
Showing 2 changed files with 2 additions and 2 deletions   Show diff stats
app/models/profile_list_block.rb
  Diff comments   View file @1668fe7
@@ -21,7 +21,7 @@ class ProfileListBlock < Block @@ -21,7 +21,7 @@ class ProfileListBlock < Block
21 end 21 end
22 22
23 def randomizer 23 def randomizer
24 - @randomizer ||= "(profiles.id % #{rand(profile_count)})" 24 + @randomizer ||= "(profiles.id % #{rand(profile_count + 1)})"
25 end 25 end
26 26
27 # the title of the block. Probably will be overriden in subclasses. 27 # the title of the block. Probably will be overriden in subclasses.
test/unit/profile_list_block_test.rb
  Diff comments   View file @1668fe7
@@ -153,7 +153,7 @@ class ProfileListBlockTest < Test::Unit::TestCase @@ -153,7 +153,7 @@ class ProfileListBlockTest < Test::Unit::TestCase
153 should 'randomize using modulo operator and random number' do 153 should 'randomize using modulo operator and random number' do
154 block = ProfileListBlock.new 154 block = ProfileListBlock.new
155 block.expects(:profile_count).returns(10) 155 block.expects(:profile_count).returns(10)
156 - block.expects(:rand).with(10).returns(5) 156 + block.expects(:rand).with(11).returns(5)
157 assert_match /profiles.id % 5/, block.randomizer 157 assert_match /profiles.id % 5/, block.randomizer
158 end 158 end
159 159