Download as
Browse Code »

Commit 182685eb2b62c217e7cfdd4d21cd4f9c8689a4ac

Authored by Rodrigo Souto
1 parent 3776461b
Exists in master and in 27 other branches 1.2+SPB2, 2_split_by_role, add_fields_in_api, api_fixies, api_pagination, api_private_token, api_tasks, article_hit_count, blog_page_bug, checkbox_to_user_can_edit_page, communities_ratings, communities_ratings_moderation, community_ratings_rebase, fix_cloned_article_parent, fix_gallery_image_url, fix_javascript_categories, fix_optional_fields, fix_suggest_article, fix_user_email_validation, highlight_block_fix, notification_plugin, notification_plugin_rebase, script_to_update, split_by_role, temp_ratings, tests, tests_fixies

[template-welcome-page] Not copy templates welcome-page 

(ActionItem3075)
Showing 2 changed files with 16 additions and 1 deletions   Show diff stats
app/models/profile.rb
  Diff comments   View file @182685e
... ... @@ -605,7 +605,7 @@ private :generate_url, :url_options
605 605 end
606 606  
607 607 def copy_article_tree(article, parent=nil)
608   - return if article.is_a?(RssFeed)
  608 + return if !copy_article?(article)
609 609 original_article = self.articles.find_by_name(article.name)
610 610 if original_article
611 611 num = 2
... ... @@ -625,6 +625,11 @@ private :generate_url, :url_options
625 625 end
626 626 end
627 627  
  628 + def copy_article?(article)
  629 + !article.is_a?(RssFeed) &&
  630 + !(is_template && article.slug=='welcome-page')
  631 + end
  632 +
628 633 # Adds a person as member of this Profile.
629 634 def add_member(person)
630 635 if self.has_members?
... ...
test/unit/profile_test.rb
  Diff comments   View file @182685e
... ... @@ -1955,4 +1955,14 @@ class ProfileTest < ActiveSupport::TestCase
1955 1955 p = fast_create(Profile)
1956 1956 assert p.folder_types.include?('ProfileTest::Folder1')
1957 1957 end
  1958 +
  1959 + should 'not copy rss_feed' do
  1960 + assert !fast_create(Profile).copy_article?(fast_create(RssFeed))
  1961 + end
  1962 +
  1963 + should 'not copy template welcome_page' do
  1964 + template = fast_create(Person, :is_template => true)
  1965 + welcome_page = fast_create(TinyMceArticle, :slug => 'welcome-page', :profile_id => template.id)
  1966 + assert !template.copy_article?(welcome_page)
  1967 + end
1958 1968 end
... ...