removing html validation to remove tidy dependency. This library is not mantaine…

…d anymore. Otherwise there is more effectively method to validate html nowadays

removing html validation to remove tidy dependency. This library is not mantaine…
…d anymore. Otherwise there is more effectively method to validate html nowadays
Leandro Santos
1 parent 892f430c
Showing 29 changed files with 1 additions and 139 deletions Show diff stats
test/functional/account_controller_test.rb
test/functional/admin_panel_controller_test.rb
test/functional/application_controller_test.rb
test/functional/catalog_controller_test.rb
test/functional/categories_controller_test.rb
test/functional/cms_controller_test.rb
test/functional/content_viewer_controller_test.rb
test/functional/edit_template_controller_test.rb
test/functional/enterprise_registration_controller_test.rb
test/functional/enterprise_validation_controller_test.rb
test/functional/environment_design_controller_test.rb
test/functional/environment_role_manager_controller_test.rb
test/functional/favorite_enterprises_controller_test.rb
test/functional/features_controller_test.rb
test/functional/friends_controller_test.rb
test/functional/home_controller_test.rb
test/functional/manage_products_controller_test.rb
test/functional/memberships_controller_test.rb
test/functional/my_profile_controller_test.rb
test/functional/plugins_controller_test.rb
@@ -25,10 +25,6 @@ class AccountControllerTest &lt; ActionController::TestCase
     assert_local_files_reference
   end
-  def test_valid_xhtml
-    assert_valid_xhtml
-  end
-
   def test_should_login_and_redirect
     post :login, :user => {:login => 'johndoe', :password => 'test'}
     assert session[:user]
@@ -18,10 +18,6 @@ class AdminPanelControllerTest &lt; ActionController::TestCase
     assert_local_files_reference
   end
-  def test_valid_xhtml
-    assert_valid_xhtml
-  end
-
   should 'manage the correct environment' do
     current = fast_create(Environment, :name => 'test environment', :is_default => false)
     current.domains.create!(:name => 'example.com')
@@ -64,10 +64,6 @@ class ApplicationControllerTest &lt; ActionController::TestCase
     assert_local_files_reference
   end
-  def test_valid_xhtml
-    assert_valid_xhtml
-  end
-
   def test_exist_environment_variable_to_helper_environment_identification
     get :index
     assert_not_nil assigns(:environment)
@@ -20,10 +20,6 @@ class CatalogControllerTest &lt; ActionController::TestCase
     assert_local_files_reference :get, :index, :profile => @enterprise.identifier
   end
-  def test_valid_xhtml
-    assert_valid_xhtml
-  end
-
   should 'not display for non-enterprises' do
     u = create_user('testinguser').person
     get :index, :profile => 'testinguser'
@@ -24,10 +24,6 @@ class CategoriesControllerTest &lt; ActionController::TestCase
     assert_local_files_reference
   end
-  def test_valid_xhtml
-    assert_valid_xhtml
-  end
-  
   def test_index
     login_as(create_admin_user(Environment.default))
     get :index
@@ -22,10 +22,6 @@ class CmsControllerTest &lt; ActionController::TestCase
     assert_local_files_reference :get, :index, :profile => profile.identifier
   end
-  def test_valid_xhtml
-    assert_valid_xhtml
-  end
-
   should 'list top level documents on index' do
     get :index, :profile => profile.identifier
@@ -24,10 +24,6 @@ class ContentViewerControllerTest &lt; ActionController::TestCase
     assert_local_files_reference :get, :view_page, :profile => profile.identifier, :page => [ 'test' ]
   end
-  def test_valid_xhtml
-    assert_valid_xhtml
-  end
-
   def test_should_display_page
     page = profile.articles.build(:name => 'test')
     page.save!
@@ -19,10 +19,6 @@ class EditTemplateControllerTest &lt; ActionController::TestCase
     assert_local_files_reference
   end
-  def test_valid_xhtml
-    assert_valid_xhtml
-  end
-  
   def test_redirect_to_design_editor_when_index_action_is_called
     give_permission('ze', 'edit_environment_design', Environment.default)
     get :index
@@ -21,10 +21,6 @@ class EnterpriseRegistrationControllerTest &lt; ActionController::TestCase
     assert_local_files_reference
   end
-  def test_valid_xhtml
-    assert_valid_xhtml
-  end
-  
   should 'go to the first step on index' do
     get :index
     assert_response :success
@@ -23,14 +23,6 @@ class EnterpriseValidationControllerTest &lt; ActionController::TestCase
     assert_local_files_reference :get, :index, :profile => 'myorg'
   end
-  def test_valid_xhtml
-
-    # FIXME remove this after enable assert_valid_xhtml
-    Profile.find_by_identifier('myorg')
-
-    assert_valid_xhtml :get, :index, :profile => 'myorg'
-  end
-  
   should 'list pending validations on index' do
     empty = []
     @org.expects(:pending_validations).returns(empty)
@@ -21,10 +21,6 @@ class EnvironmentDesignControllerTest &lt; ActionController::TestCase
     assert_local_files_reference
   end
-  def test_valid_xhtml
-    assert_valid_xhtml
-  end
-
   should 'indicate only actual blocks as such' do
     assert(@controller.available_blocks.all? {|item| item.new.is_a? Block})
   end
@@ -15,12 +15,4 @@ class EnvironmentRoleManagerControllerTest &lt; ActionController::TestCase
     assert_local_files_reference
   end
-  def test_valid_xhtml
-    assert_valid_xhtml
-  end
-  
-  # Replace this with your real tests.
-  def test_truth
-    assert true
-  end
 end
@@ -22,10 +22,6 @@ class FavoriteEnterprisesControllerTest &lt; ActionController::TestCase
     assert_local_files_reference
   end
-  def test_valid_xhtml
-    assert_valid_xhtml
-  end
-  
   should 'list favorite enterprises' do
     get :index
     assert_response :success
@@ -18,10 +18,6 @@ class FeaturesControllerTest &lt; ActionController::TestCase
     assert_local_files_reference
   end
-  def test_valid_xhtml
-    assert_valid_xhtml
-  end
-  
   def test_listing_features
     uses_host 'anhetegua.net'
     get :index
@@ -22,10 +22,6 @@ class FriendsControllerTest &lt; ActionController::TestCase
     assert_local_files_reference
   end
-  def test_valid_xhtml
-    assert_valid_xhtml
-  end
-  
   should 'list friends' do
     get :index
     assert_response :success
@@ -21,10 +21,6 @@ class HomeControllerTest &lt; ActionController::TestCase
     assert_local_files_reference
   end
-  def test_valid_xhtml
-    assert_valid_xhtml
-  end
-
   should 'not display news from portal if disabled in environment' do
     env = Environment.default
     env.disable('use_portal_community')
@@ -22,10 +22,6 @@ class ManageProductsControllerTest &lt; ActionController::TestCase
     assert_local_files_reference :get, :index, :profile => @enterprise.identifier
   end
-  def test_valid_xhtml
-    assert_valid_xhtml
-  end
-
   should "not have permission" do
     u = create_user('user_test')
     login_as :user_test
@@ -23,10 +23,6 @@ class MembershipsControllerTest &lt; ActionController::TestCase
     assert_local_files_reference :get, :index, :profile => profile.identifier
   end
-  def test_valid_xhtml
-    assert_valid_xhtml
-  end
-
   should 'list current memberships' do
     get :index, :profile => profile.identifier
@@ -26,10 +26,6 @@ class MyProfileControllerTest &lt; ActionController::TestCase
     assert_local_files_reference :get, :index, :profile => user.identifier
   end
-  def test_valid_xhtml
-    assert_valid_xhtml
-  end
-  
   def test_should_allow_person
     @controller = OnlyForPersonTestController.new
     person = create_user('random_joe')
@@ -20,10 +20,6 @@ class PluginsControllerTest &lt; ActionController::TestCase
     assert_local_files_reference
   end
-  def test_valid_xhtml
-    assert_valid_xhtml
-  end
-
   should 'list system active plugins' do
     class Plugin1 < Noosfero::Plugin
       class << self
@@ -15,10 +15,6 @@ class ProfileControllerTest &lt; ActionController::TestCase
     assert_local_files_reference
   end
-  def test_valid_xhtml
-    assert_valid_xhtml
-  end
-
   noosfero_test :profile => 'testuser'
   should 'list friends' do
@@ -79,10 +79,6 @@ class ProfileDesignControllerTest &lt; ActionController::TestCase
     assert_local_files_reference :get, :index, :profile => 'designtestuser'
   end
-  def test_valid_xhtml
-    assert_valid_xhtml
-  end
-
   ######################################################
   # BEGIN - tests for BoxOrganizerController features
   ######################################################
@@ -20,11 +20,7 @@ class ProfileEditorControllerTest &lt; ActionController::TestCase
   def test_local_files_reference
     assert_local_files_reference :get, :index, :profile => profile.identifier
   end
-  
-  def test_valid_xhtml
-    assert_valid_xhtml
-  end
-  
+
   def test_index
     get :index, :profile => profile.identifier
     assert_template 'index'
@@ -17,10 +17,6 @@ class ProfileMembersControllerTest &lt; ActionController::TestCase
     assert_local_files_reference :get, :index, :profile => user.identifier
   end
-  def test_valid_xhtml
-    assert_valid_xhtml
-  end
-  
   should 'not access index if dont have permission' do
     user = create_user('test_user')
     fast_create(Enterprise, :identifier => 'test_enterprise', :name => 'test enterprise')
@@ -17,10 +17,6 @@ class RegionValidatorsControllerTest &lt; ActionController::TestCase
     assert_local_files_reference
   end
-  def test_valid_xhtml
-    assert_valid_xhtml
-  end
-  
   # Replace this with your real tests.
   should 'list regions at index' do
     get :index
@@ -19,10 +19,6 @@ class RoleControllerTest &lt; ActionController::TestCase
     assert_local_files_reference
   end
-  def test_valid_xhtml
-    assert_valid_xhtml
-  end
-  
   def test_index_should_get_roles
     get 'index'
     assert_response :success
@@ -49,10 +49,6 @@ class SearchControllerTest &lt; ActionController::TestCase
     assert_local_files_reference
   end
-  def test_valid_xhtml
-    assert_valid_xhtml
-  end
-
   should 'espape xss attack' do
     get 'index', :query => '<wslite>'
     assert_no_tag :tag => 'wslite'
@@ -26,10 +26,6 @@ class TasksControllerTest &lt; ActionController::TestCase
     assert_local_files_reference
   end
-  def test_valid_xhtml
-    assert_valid_xhtml
-  end
-  
   should 'list pending tasks' do
     get :index
@@ -3,7 +3,6 @@ ENV[&quot;RAILS_ENV&quot;] = &quot;test&quot;
 require File.expand_path(File.dirname(__FILE__) + "/../config/environment")
 require 'rails/test_help'
 require 'mocha'
-require 'tidy'
 require 'hpricot'
 require 'noosfero/test'
@@ -111,23 +110,6 @@ class ActiveSupport::TestCase
     assert_equal parent, child.superclass, "Class #{child} expected to be a subclass of #{parent}"
   end
-  def assert_valid_xhtml(method=:get, action=:index, params = {})
-    return true
-    if method.to_s() == 'post'
-      post action, params
-    else
-      get action, params
-    end
-    tidy = Tidy.open(:show_warnings=>false)
-    tidy.options.output_xml = true
-    tidy.clean @response.body
-    if tidy.errors
-      flunk "HTML ERROR - Tidy Diagnostics:\n  "+
-            tidy.errors.join("\n  ") +"\n  "+
-            tidy.diagnostics.join("\n  ")
-    end
-  end
-
   def assert_local_files_reference(method=:get, action=:index, params = {})
     if method.to_s() == 'post'
       post action, params
	@@ -23,14 +23,6 @@ class EnterpriseValidationControllerTest < ActionController::TestCase		@@ -23,14 +23,6 @@ class EnterpriseValidationControllerTest < ActionController::TestCase
23	assert_local_files_reference :get, :index, :profile => 'myorg'	23	assert_local_files_reference :get, :index, :profile => 'myorg'
24	end	24	end
25		25
26	- def test_valid_xhtml
27	-
28	- # FIXME remove this after enable assert_valid_xhtml
29	- Profile.find_by_identifier('myorg')
30	-
31	- assert_valid_xhtml :get, :index, :profile => 'myorg'
32	- end
33	-
34	should 'list pending validations on index' do	26	should 'list pending validations on index' do
35	empty = []	27	empty = []
36	@org.expects(:pending_validations).returns(empty)	28	@org.expects(:pending_validations).returns(empty)
	@@ -15,12 +15,4 @@ class EnvironmentRoleManagerControllerTest < ActionController::TestCase		@@ -15,12 +15,4 @@ class EnvironmentRoleManagerControllerTest < ActionController::TestCase
15	assert_local_files_reference	15	assert_local_files_reference
16	end	16	end
17		17
18	- def test_valid_xhtml
19	- assert_valid_xhtml
20	- end
21	-
22	- # Replace this with your real tests.
23	- def test_truth
24	- assert true
25	- end
26	end	18	end
	@@ -3,7 +3,6 @@ ENV["RAILS_ENV"] = "test"		@@ -3,7 +3,6 @@ ENV["RAILS_ENV"] = "test"
3	require File.expand_path(File.dirname(__FILE__) + "/../config/environment")	3	require File.expand_path(File.dirname(__FILE__) + "/../config/environment")
4	require 'rails/test_help'	4	require 'rails/test_help'
5	require 'mocha'	5	require 'mocha'
6	-require 'tidy'
7	require 'hpricot'	6	require 'hpricot'
8		7
9	require 'noosfero/test'	8	require 'noosfero/test'
	@@ -111,23 +110,6 @@ class ActiveSupport::TestCase		@@ -111,23 +110,6 @@ class ActiveSupport::TestCase
111	assert_equal parent, child.superclass, "Class #{child} expected to be a subclass of #{parent}"	110	assert_equal parent, child.superclass, "Class #{child} expected to be a subclass of #{parent}"
112	end	111	end
113		112
114	- def assert_valid_xhtml(method=:get, action=:index, params = {})
115	- return true
116	- if method.to_s() == 'post'
117	- post action, params
118	- else
119	- get action, params
120	- end
121	- tidy = Tidy.open(:show_warnings=>false)
122	- tidy.options.output_xml = true
123	- tidy.clean @response.body
124	- if tidy.errors
125	- flunk "HTML ERROR - Tidy Diagnostics:\n "+
126	- tidy.errors.join("\n ") +"\n "+
127	- tidy.diagnostics.join("\n ")
128	- end
129	- end
130	-
131	def assert_local_files_reference(method=:get, action=:index, params = {})	113	def assert_local_files_reference(method=:get, action=:index, params = {})
132	if method.to_s() == 'post'	114	if method.to_s() == 'post'
133	post action, params	115	post action, params