Fix cloned article body bug

Fabio Teixeira
1 parent f1279433
Showing 2 changed files with 13 additions and 12 deletions Show diff stats
app/controllers/my_profile/cms_controller.rb
test/functional/cms_controller_test.rb
@@ -118,10 +118,7 @@ class CmsController &lt; MyProfileController
       end
     end
-    unless @article.kind_of?(RssFeed)
-      @escaped_body = CGI::escapeHTML(@article.body || '')
-      @escaped_abstract = CGI::escapeHTML(@article.abstract || '')
-    end
+    escape_fields @article
   end
   def new
@@ -192,6 +189,8 @@ class CmsController &lt; MyProfileController
       end
     end
+    escape_fields @article
+
     render :action => 'edit'
   end
@@ -541,4 +540,10 @@ class CmsController &lt; MyProfileController
     end
   end
+  def escape_fields article
+    unless article.kind_of?(RssFeed)
+      @escaped_body = CGI::escapeHTML(article.body || '')
+      @escaped_abstract = CGI::escapeHTML(article.abstract || '')
+    end
+  end
 end
@@ -1839,14 +1839,6 @@ class CmsControllerTest &lt; ActionController::TestCase
     assert_equal 'first version', assigns(:article).name
   end
-  should 'clone article with its content' do
-    article = profile.articles.create(:name => 'first version')
-
-    get :new, :profile => profile.identifier, :id => article.id, :clone => true, :type => 'TinyMceArticle'
-
-    assert_match article.name, @response.body
-  end
-
   should 'save article with content from older version' do
     article = profile.articles.create(:name => 'first version')
     article.name = 'second version'; article.save
@@ -1918,6 +1910,10 @@ class CmsControllerTest &lt; ActionController::TestCase
     assert_equal main_article.parent_id, cloned_main_article.parent_id
+    get :new, :profile => profile.identifier, :id => cloned_main_article.id,
+              :clone => true, :type => 'TinyMceArticle'
+
+    assert_match main_article.body, @response.body
   end
   protected